Change in coreboot[master]: console/Kconfig - only print UART addresses for I/O based UARTs
Martin Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34247 )
Change subject: console/Kconfig - only print UART addresses for I/O based UARTs ......................................................................
console/Kconfig - only print UART addresses for I/O based UARTs
It doesn't make sense to print these values for memory-mapped UARTs.
Change-Id: Ie2d9cf95f0b0fdcf601e74de799b1390c08f2335 Signed-off-by: Martin Roth martinroth@google.com --- M src/console/Kconfig 1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/34247/1
diff --git a/src/console/Kconfig b/src/console/Kconfig index 61ba667..4cb407e 100644 --- a/src/console/Kconfig +++ b/src/console/Kconfig @@ -79,13 +79,13 @@ Map the COM port number to the respective I/O port.
comment "Serial port base address = 0x3f8" -depends on UART_FOR_CONSOLE = 0 +depends on DRIVERS_UART_8250IO && UART_FOR_CONSOLE = 0 comment "Serial port base address = 0x2f8" -depends on UART_FOR_CONSOLE = 1 +depends on DRIVERS_UART_8250IO && UART_FOR_CONSOLE = 1 comment "Serial port base address = 0x3e8" -depends on UART_FOR_CONSOLE = 2 +depends on DRIVERS_UART_8250IO && UART_FOR_CONSOLE = 2 comment "Serial port base address = 0x2e8" -depends on UART_FOR_CONSOLE = 3 +depends on DRIVERS_UART_8250IO && UART_FOR_CONSOLE = 3
config UART_OVERRIDE_BAUDRATE boolean
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34247 )
Change subject: console/Kconfig - only print UART addresses for I/O based UARTs ......................................................................
Patch Set 1: Code-Review+2
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34247 )
Change subject: console/Kconfig - only print UART addresses for I/O based UARTs ......................................................................
Patch Set 1: Code-Review+2
Thanks!
Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34247 )
Change subject: console/Kconfig - only print UART addresses for I/O based UARTs ......................................................................
console/Kconfig - only print UART addresses for I/O based UARTs
It doesn't make sense to print these values for memory-mapped UARTs.
Change-Id: Ie2d9cf95f0b0fdcf601e74de799b1390c08f2335 Signed-off-by: Martin Roth martinroth@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/34247 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/console/Kconfig 1 file changed, 4 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved Nico Huber: Looks good to me, approved
diff --git a/src/console/Kconfig b/src/console/Kconfig index 61ba667..4cb407e 100644 --- a/src/console/Kconfig +++ b/src/console/Kconfig @@ -79,13 +79,13 @@ Map the COM port number to the respective I/O port.
comment "Serial port base address = 0x3f8" -depends on UART_FOR_CONSOLE = 0 +depends on DRIVERS_UART_8250IO && UART_FOR_CONSOLE = 0 comment "Serial port base address = 0x2f8" -depends on UART_FOR_CONSOLE = 1 +depends on DRIVERS_UART_8250IO && UART_FOR_CONSOLE = 1 comment "Serial port base address = 0x3e8" -depends on UART_FOR_CONSOLE = 2 +depends on DRIVERS_UART_8250IO && UART_FOR_CONSOLE = 2 comment "Serial port base address = 0x2e8" -depends on UART_FOR_CONSOLE = 3 +depends on DRIVERS_UART_8250IO && UART_FOR_CONSOLE = 3
config UART_OVERRIDE_BAUDRATE boolean
-
Kyösti Mälkki (Code Review) -
Martin Roth (Code Review)
-
Nico Huber (Code Review)