Chen Wisley has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47733 )
Change subject: xmb/google/volteer: Add BOOT_*_SUPPORT to FW_CONFIG ......................................................................
xmb/google/volteer: Add BOOT_*_SUPPORT to FW_CONFIG
bit 22 for BOOT_SUPPORT_NVME bit 23 for BOOT_SUPPORT_SATA bit 24 for BOOT_SUPPORT_EMMC: bit24
BUG=none BRANCH=volteer TEST=emerge-volteer coreboot
Change-Id: I41a6c624c8e32a6115b496f523dbd7a7c3f038c4 Signed-off-by: Wisley Chen wisley.chen@quantatw.com --- M src/mainboard/google/volteer/variants/baseboard/devicetree.cb 1 file changed, 9 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/47733/1
diff --git a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb index 50be736..18d1f6b 100644 --- a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb @@ -38,6 +38,15 @@ option SD_GL9755S 1 option SD_RTS5261 2 end + field BOOT_NVME_MASK 22 + option BOOT_SUPPORT_NVME 1 + end + field BOOT_SATA_MASK 23 + option BOOT_SUPPORT_SATA 1 + end + field BOOT_EMMC_MASK 24 + option BOOT_SUPPORT_EMMC 1 + end end
chip soc/intel/tigerlake
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47733 )
Change subject: xmb/google/volteer: Add BOOT_*_SUPPORT to FW_CONFIG ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47733/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/47733/1/src/mainboard/google/voltee... PS1, Line 45: option BOOT_SUPPORT_SATA 1 trailing whitespace
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47733
to look at the new patch set (#2).
Change subject: xmb/google/volteer: Add BOOT_*_SUPPORT to FW_CONFIG ......................................................................
xmb/google/volteer: Add BOOT_*_SUPPORT to FW_CONFIG
bit 22 for BOOT_SUPPORT_NVME bit 23 for BOOT_SUPPORT_SATA bit 24 for BOOT_SUPPORT_EMMC: bit24
BUG=none BRANCH=volteer TEST=emerge-volteer coreboot
Change-Id: I41a6c624c8e32a6115b496f523dbd7a7c3f038c4 Signed-off-by: Wisley Chen wisley.chen@quantatw.com --- M src/mainboard/google/volteer/variants/baseboard/devicetree.cb 1 file changed, 9 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/47733/2
Stefan Reinauer has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/47733?usp=email )
Change subject: xmb/google/volteer: Add BOOT_*_SUPPORT to FW_CONFIG ......................................................................
Abandoned
-
build bot (Jenkins) (Code Review) -
Chen Wisley (Code Review)
-
Stefan Reinauer (Code Review)