Change in coreboot[master]: drivers/i2c/cs42l42: Make HS_BIAS_SENSE_EN optional - coreboot-gerrit

10 May 2021


      Attention is currently required from: Furquan Shaikh, Vitaly Rodionov, Marco Chen, Karthik Ramasubramanian.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52981 )
Change subject: drivers/i2c/cs42l42: Make HS_BIAS_SENSE_EN optional
......................................................................
Patch Set 4:
(1 comment)
File src/drivers/i2c/cs42l42/chip.h:
https://review.coreboot.org/c/coreboot/+/52981/comment/83c2b0f2_ad93012a 
PS4, Line 118: Default =
...
I think it would be helpful to have a comment before this struct (on lines 36-37) saying that the "D […]
In this case, coreboot will always generate the property, so the kernel default is meaningless.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/52981
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I87c6f01af1bdb5b1cb8e399191519598d7fbe9ea
Gerrit-Change-Number: 52981
Gerrit-PatchSet: 4
Gerrit-Owner: Vitaly Rodionov vitaly.rodionov@cirrus.corp-partner.google.com
Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Marco Chen marcochen@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Furquan Shaikh furquan@google.com
Gerrit-Attention: Vitaly Rodionov vitaly.rodionov@cirrus.corp-partner.google.com
Gerrit-Attention: Marco Chen marcochen@google.com
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Comment-Date: Mon, 10 May 2021 21:16:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh furquan@google.com
Gerrit-MessageType: comment