Attention is currently required from: Eloy, Stefan Reinauer. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63702 )
Change subject: util/inteltool: add lockdown mode detection ......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63702/comment/68255bff_260319ec PS2, Line 8: Why should Intel tool display the lockdown mode? Please add a commit message body.
File util/inteltool/inteltool.c:
https://review.coreboot.org/c/coreboot/+/63702/comment/b42faf2c_50a2c9e9 PS2, Line 808: /* Check if kernel is in lockdown mode. : * Whether this part of sysfs is considered a : * stable kernel API part is unknown, since : * there is no explicit documentation : * stating so. There does not seems to be : * any other interface for checking wether the : * kernel is in lockdown mode. Until there is : * something better, parse the sysfs file. : * Because it is a sysfs file, fseek(3) or : * stat(2) are ineffective. You can only : * iterate until the state of the file : * handle is EOF, while it is copied into : * a buffer. Please reflow for at least 72 characters per line.
-
Paul Menzel (Code Review)