Attention is currently required from: Sam McNally, Peter Marheine, Felix Held.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57298 )
Change subject: mb/google/zork: correct MST probes
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Patchset:
PS2:
There might be a case for the behavior this is working around being a bug, but since `device ref` be […]
The way the override feature works in device tree is by walking the tree in base tree and override tree and comparing the exact paths to ensure that the correct device from the base tree is overriden. Thus, even if reference is used, you still need to have the correct path. This can possibly be optimized, but not something that sconfig supports right now.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57298
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2a8feb544f3fc198fe6313b226ad8995aad31c3e
Gerrit-Change-Number: 57298
Gerrit-PatchSet: 2
Gerrit-Owner: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Sam McNally
sammc@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Daniel Kurtz
djkurtz@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sam McNally
sammc@google.com
Gerrit-Attention: Peter Marheine
pmarheine@chromium.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 01 Sep 2021 06:09:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Peter Marheine
pmarheine@chromium.org
Gerrit-MessageType: comment