Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74243?usp=email )
Change subject: arch/x86: Disable walkcbfs_asm code when CONFIG_CBFS_VERIFICATION is set
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Apparently the QEMU- target was still using it. […]
I'm not exactly sure what QEMU is doing there, looks like +Patrick wrote that code (CB:49228). The src/intel/common version of that code, as far as I can tell, uses the page table file directly from memory-mapped flash.
If that isn't possible for QEMU then I'd suggest just disabling CBFS verification for it (via Kconfig dependencies). It's not like anyone really _needs_ verification on an emulation board anyway.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74243?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I614a1b05881aa7c1539a7f7f296855ff708db56c
Gerrit-Change-Number: 74243
Gerrit-PatchSet: 2
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Comment-Date: Tue, 05 Mar 2024 02:28:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-MessageType: comment