Attention is currently required from: Raul Rangel, Rob Barnes. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57313 )
Change subject: nipperkin: Set eSPI alert as dedicated open drain ......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/guybrush/variants/nipperkin/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/57313/comment/902bfb8c_7856d9c2 PS1, Line 37: alert_pin = ESPI_ALERT_PIN_OPEN_DRAIN, I think this is the only thing that changed. IF so, I think we can configure the alert_pin as dedicated and OPEN_DRAIN in baseboard/devicetree.cb.
We can just override the alert_pin as IN_BAND in the guybrush/overridetree.cb as follows:
register "common_config.espi_config.alert_pin" = "ESPI_ALERT_PIN_IN_BAND"
This will avoid recurrent changes for new variants. This will also keep the change minimal in guybrush as well. Thoughts?
-
Karthik Ramasubramanian (Code Review)