Attention is currently required from: Nico Huber, Tim Wawrzynczak, Angel Pons, Patrick Rudolph, EricR Lai. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60721 )
Change subject: soc/intel/common/cse: Add config to disable CSE at pre-boot ......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/common/block/cse/Kconfig:
https://review.coreboot.org/c/coreboot/+/60721/comment/93c3b604_d5307b1b PS2, Line 13: This config decides the state of CSE/Heci1 device at the end of boot.
Hmm, Why not keep HECI in the name? DISABLE_HECI or HIDE_HECI
The only problem that I'm trying to avoid by not calling it "Heci" alone is that, there are multiple Heci devices so, DISABLE_HECI might sounds like we are providing API to make all heci devices disable.
device pci 16.0 alias heci1 off end device pci 16.1 alias heci2 off end device pci 16.4 alias heci3 off end device pci 16.5 alias heci4 off end
Otherwise we might need to say DISABLE/HIDE_HECI1 ? to specify its CSE/Heci1 alone. WDYT?
would be very clear to me. It could still say CSE in the prompt, e.g. "Disable CSE interface (HECI)".
Sure.
-
Subrata Banik (Code Review)