Change in coreboot[master]: mb/google/zork: fix SMMSTORE size, alignment in default FMAP - coreboot-gerrit

3 Mar 2022


      Attention is currently required from: Matt DeVillier, Arthur Heymans, Karthik Ramasubramanian.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62443 )
Change subject: mb/google/zork: fix SMMSTORE size, alignment in default FMAP
......................................................................
Patch Set 2: Code-Review+2
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62443/comment/c03598ad_b329ee40 
PS1, Line 9: 64k
...
...
Where is this documented? […]
Ack
https://review.coreboot.org/c/coreboot/+/62443/comment/9e1d417d_7216d62e 
PS1, Line 12: asserts
...
src/drivers/smmstore/store. […]
Ack
Patchset:
PS2: 
Just curious, what are you using SMMSTORE for? It's not enabled by default.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/62443
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ied04e93379e1507f5e6b2a1b71e4098a4561e5d8
Gerrit-Change-Number: 62443
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Matt DeVillier matt.devillier@gmail.com
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Comment-Date: Wed, 02 Mar 2022 23:21:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Raul Rangel rrangel@chromium.org
Comment-In-Reply-To: Matt DeVillier matt.devillier@gmail.com
Comment-In-Reply-To: Arthur Heymans arthur@aheymans.xyz
Gerrit-MessageType: comment