Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39980 )
Change subject: soc/intel/skylake: vr_config: enable PSI3 and PSI4 by default
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39980/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/39980/3//COMMIT_MSG@23
PS3, Line 23: Tested successfully with PSI3/4 enabled.
But does it have PSI3/PSI4 support?
I'm still trying to find out; the board has the MP2955 but there is no ds. MP2965 supports PS3 but no PS4. I assume MP2955 has PS3, too but no PS4 since PS4 needs to be acknowleged by the VR, it shouldn't hurt to be enabled (to be proven).
Maybe I should add that I tested with a CPU that does not support PS4 anyway (e3-1230v6), since it has no C9/C10 states
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39980
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5b5fd9fb3b9b89e80c47f15d706e2dd62dcc0748
Gerrit-Change-Number: 39980
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Matthew Garrett
mjg59@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Thu, 02 Apr 2020 08:52:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment