Change in coreboot[master]: Makefile: Set FMAP size to 0x200 for non-x86 boards with default fmd
Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40374 )
Change subject: Makefile: Set FMAP size to 0x200 for non-x86 boards with default fmd ......................................................................
Makefile: Set FMAP size to 0x200 for non-x86 boards with default fmd
This change updates FMAP_FMAP_SIZE for non-x86 boards using default fmd file to be 0x200 just like for x86 boards.
Signed-off-by: Furquan Shaikh furquan@google.com Change-Id: I3f58696b26fbb5363d67bec4056653da83485776 --- M Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/40374/1
diff --git a/Makefile.inc b/Makefile.inc index 076c139..ac430f7 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -953,7 +953,7 @@ FMAP_BIOS_SIZE := $(CONFIG_CBFS_SIZE) # position and size of flashmap, relative to BIOS_BASE FMAP_FMAP_BASE := 0x20000 -FMAP_FMAP_SIZE := 0x100 +FMAP_FMAP_SIZE := 0x200
FMAP_CURRENT_BASE := $(call int-add, $(FMAP_FMAP_BASE) $(FMAP_FMAP_SIZE))
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40374 )
Change subject: Makefile: Set FMAP size to 0x200 for non-x86 boards with default fmd ......................................................................
Patch Set 1: Code-Review+2
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40374 )
Change subject: Makefile: Set FMAP size to 0x200 for non-x86 boards with default fmd ......................................................................
Patch Set 1: Code-Review+2
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40374 )
Change subject: Makefile: Set FMAP size to 0x200 for non-x86 boards with default fmd ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40374 )
Change subject: Makefile: Set FMAP size to 0x200 for non-x86 boards with default fmd ......................................................................
Makefile: Set FMAP size to 0x200 for non-x86 boards with default fmd
This change updates FMAP_FMAP_SIZE for non-x86 boards using default fmd file to be 0x200 just like for x86 boards.
Signed-off-by: Furquan Shaikh furquan@google.com Change-Id: I3f58696b26fbb5363d67bec4056653da83485776 Reviewed-on: https://review.coreboot.org/c/coreboot/+/40374 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Julius Werner jwerner@chromium.org Reviewed-by: Arthur Heymans arthur@aheymans.xyz Reviewed-by: Aaron Durbin adurbin@chromium.org --- M Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved Julius Werner: Looks good to me, approved Arthur Heymans: Looks good to me, approved
diff --git a/Makefile.inc b/Makefile.inc index 8835ec3..e315732 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -953,7 +953,7 @@ FMAP_BIOS_SIZE := $(CONFIG_CBFS_SIZE) # position and size of flashmap, relative to BIOS_BASE FMAP_FMAP_BASE := 0x20000 -FMAP_FMAP_SIZE := 0x100 +FMAP_FMAP_SIZE := 0x200
FMAP_CURRENT_BASE := $(call int-add, $(FMAP_FMAP_BASE) $(FMAP_FMAP_SIZE))
-
Aaron Durbin (Code Review) -
Arthur Heymans (Code Review)
-
Furquan Shaikh (Code Review)
-
Julius Werner (Code Review)
-
Patrick Georgi (Code Review)