build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25019 )
Change subject: lib: Add FIT payload support ......................................................................
Patch Set 35:
(4 comments)
https://review.coreboot.org/#/c/25019/35/src/arch/arm64/fit_payload.c File src/arch/arm64/fit_payload.c:
https://review.coreboot.org/#/c/25019/35/src/arch/arm64/fit_payload.c@102 PS35, Line 102: if (scratch.header.image_size) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/25019/35/src/include/fit.h File src/include/fit.h:
https://review.coreboot.org/#/c/25019/35/src/include/fit.h@49 PS35, Line 49: const char* compat_string; "foo* bar" should be "foo *bar"
https://review.coreboot.org/#/c/25019/35/src/lib/fit.c File src/lib/fit.c:
https://review.coreboot.org/#/c/25019/35/src/lib/fit.c@66 PS35, Line 66: if ((board_id() != UNDEFINED_STRAPPING_ID)) { Unnecessary parentheses
https://review.coreboot.org/#/c/25019/35/src/lib/fit.c@284 PS35, Line 284: * Kernel likes its availabe memory areas at least 1MB 'availabe' may be misspelled - perhaps 'available'?
-
build bot (Jenkins) (Code Review)