Stefan Reinauer has uploaded this change for review. ( https://review.coreboot.org/c/em100/+/37133 )
Change subject: Cosmetic Makefile fixes ......................................................................
Cosmetic Makefile fixes
Signed-off-by: Stefan Reinauer stefan.reinauer@coreboot.org Change-Id: I3919f2ea87950aeb92c412778e875b4df8d19188 --- M Makefile 1 file changed, 6 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/em100 refs/changes/33/37133/1
diff --git a/Makefile b/Makefile index 41b5281..164a934 100644 --- a/Makefile +++ b/Makefile @@ -23,23 +23,23 @@ endif endif
-CFLAGS ?=-O2 -g -fomit-frame-pointer +CFLAGS ?= -O2 -g -fomit-frame-pointer CFLAGS += $(shell $(PKG_CONFIG) --cflags libusb-1.0)
CFLAGS += -Wall -Wundef -Wstrict-prototypes -Wmissing-prototypes CFLAGS += -Wwrite-strings -Wredundant-decls -Wstrict-aliasing -Wshadow -Wextra CFLAGS += -Wno-unused-but-set-variable # Remove after fixing -CFLAGS +=-Wno-sign-compare -Wno-discarded-qualifiers +CFLAGS += -Wno-sign-compare -Wno-discarded-qualifiers
LDFLAGS ?= LDFLAGS += $(shell $(PKG_CONFIG) --libs libusb-1.0)
-CC?=gcc -PKG_CONFIG?=pkg-config +CC ?= gcc +PKG_CONFIG ?= pkg-config
-SOURCES=em100.c firmware.c fpga.c hexdump.c sdram.c spi.c system.c trace.c usb.c -OBJECTS=$(SOURCES:.c=.o) +SOURCES = em100.c firmware.c fpga.c hexdump.c sdram.c spi.c system.c trace.c usb.c +OBJECTS = $(SOURCES:.c=.o)
all: dep em100
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/em100/+/37133 )
Change subject: Cosmetic Makefile fixes ......................................................................
Patch Set 2: Code-Review+2
Stefan Reinauer has submitted this change. ( https://review.coreboot.org/c/em100/+/37133 )
Change subject: Cosmetic Makefile fixes ......................................................................
Cosmetic Makefile fixes
Signed-off-by: Stefan Reinauer stefan.reinauer@coreboot.org Change-Id: I3919f2ea87950aeb92c412778e875b4df8d19188 Reviewed-on: https://review.coreboot.org/c/em100/+/37133 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com --- M Makefile 1 file changed, 6 insertions(+), 6 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved
diff --git a/Makefile b/Makefile index be7d6ad..d5142ae 100644 --- a/Makefile +++ b/Makefile @@ -23,23 +23,23 @@ endif endif
-CFLAGS ?=-O2 -g -fomit-frame-pointer +CFLAGS ?= -O2 -g -fomit-frame-pointer CFLAGS += $(shell $(PKG_CONFIG) --cflags libusb-1.0)
CFLAGS += -Wall -Wundef -Wstrict-prototypes -Wmissing-prototypes CFLAGS += -Wwrite-strings -Wredundant-decls -Wstrict-aliasing -Wshadow -Wextra CFLAGS += -Wno-unused-but-set-variable # Remove after fixing -CFLAGS +=-Wno-sign-compare -Wno-discarded-qualifiers +CFLAGS += -Wno-sign-compare -Wno-discarded-qualifiers
LDFLAGS ?= LDFLAGS += $(shell $(PKG_CONFIG) --libs libusb-1.0)
-CC?=gcc -PKG_CONFIG?=pkg-config +CC ?= gcc +PKG_CONFIG ?= pkg-config
-SOURCES=em100.c firmware.c fpga.c hexdump.c sdram.c spi.c system.c trace.c usb.c -OBJECTS=$(SOURCES:.c=.o) +SOURCES = em100.c firmware.c fpga.c hexdump.c sdram.c spi.c system.c trace.c usb.c +OBJECTS = $(SOURCES:.c=.o)
all: dep em100
-
Patrick Georgi (Code Review) -
Stefan Reinauer (Code Review)