Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31666 )
Change subject: soc/intel/cannonlake: Fix DSDT compile remarks ......................................................................
soc/intel/cannonlake: Fix DSDT compile remarks
The following remarks show up during cannonlake based platform coreboot build: dsdt.asl 55: Offset (0x00), Remark 2158 - ^ Unnecessary/redundant use of Offset operator
dsdt.asl 136: Offset (0xa8), Remark 2158 - ^ Unnecessary/redundant use of Offset operator
Address those two remarks in coreboot.
BUG=N/A TEST=Build coreboot and check build log to see no more remark.
Signed-off-by: Lijian Zhao lijian.zhao@intel.com Change-Id: Iad660347b32d90ac1176654820375e30a21b5ffe Reviewed-on: https://review.coreboot.org/c/31666 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Reviewed-by: Bora Guvendik bora.guvendik@intel.com --- M src/soc/intel/cannonlake/acpi/globalnvs.asl M src/soc/intel/cannonlake/acpi/northbridge.asl 2 files changed, 3 insertions(+), 6 deletions(-)
Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, but someone else must approve Bora Guvendik: Looks good to me, approved
diff --git a/src/soc/intel/cannonlake/acpi/globalnvs.asl b/src/soc/intel/cannonlake/acpi/globalnvs.asl index ac60b36..940cf43 100644 --- a/src/soc/intel/cannonlake/acpi/globalnvs.asl +++ b/src/soc/intel/cannonlake/acpi/globalnvs.asl @@ -32,7 +32,6 @@ Field (GNVS, ByteAcc, NoLock, Preserve) { /* Miscellaneous */ - Offset (0x00), OSYS, 16, // 0x00 - Operating System SMIF, 8, // 0x02 - SMI function PCNT, 8, // 0x03 - Processor Count diff --git a/src/soc/intel/cannonlake/acpi/northbridge.asl b/src/soc/intel/cannonlake/acpi/northbridge.asl index 68ab059..7fb4c09 100644 --- a/src/soc/intel/cannonlake/acpi/northbridge.asl +++ b/src/soc/intel/cannonlake/acpi/northbridge.asl @@ -54,11 +54,9 @@ , 11, DIBR, 20, /* DMIBAR [31:12] */
- Offset (0xa0), /* Top of Used Memory */ - TOM, 64, - - Offset (0xa8), /* Top of Upper Used Memory */ - TUUD, 64, + Offset (0xa0), + TOM, 64, /* Top of Used Memory */ + TUUD, 64, /* Top of Upper Used Memory */
Offset (0xbc), /* Top of Low Used Memory */ TLUD, 32,