Maxim Polyakov has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35386 )
Change subject: mb/asrock/h110m: configure SuperIO global registers ......................................................................
mb/asrock/h110m: configure SuperIO global registers
Information based on superiotool dump.
Change-Id: I24ae9b1a7eab3095518341354544efe613912a6a Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com --- M src/mainboard/asrock/h110m/devicetree.cb 1 file changed, 15 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/35386/1
diff --git a/src/mainboard/asrock/h110m/devicetree.cb b/src/mainboard/asrock/h110m/devicetree.cb index 88a4edc..572cd6a 100644 --- a/src/mainboard/asrock/h110m/devicetree.cb +++ b/src/mainboard/asrock/h110m/devicetree.cb @@ -327,12 +327,22 @@ subsystemid 0x1849 0x1a43 chip superio/nuvoton/nct6791d device pnp 2e.0 off end # Floppy - device pnp 2e.1 on # Parallel - # global - irq 0x1c = 0x10 + device pnp 2e.1 on + # Global Control Registers + # Device IRQ Polarity + irq 0x13 = 0x00 + irq 0x14 = 0x00 + # Global Option + irq 0x24 = 0xfb irq 0x27 = 0x10 - irq 0x2a = 0x64 - # parallel port + # Multi Function + irq 0x1a = 0xb0 + irq 0x1b = 0xe6 + irq 0x2a = 0x04 + irq 0x2c = 0x40 + irq 0x2d = 0x03 + + # Parallel Port io 0x60 = 0x0378 irq 0x70 = 7 drq 0x74 = 4 # No DMA
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35386 )
Change subject: mb/asrock/h110m: configure SuperIO global registers ......................................................................
Patch Set 1: Code-Review+2
didn't check the values with the datasheet, but since you got those from running under the vendor firmware, i'll assume that they are correct for the board
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35386 )
Change subject: mb/asrock/h110m: configure SuperIO global registers ......................................................................
mb/asrock/h110m: configure SuperIO global registers
Information based on superiotool dump.
Change-Id: I24ae9b1a7eab3095518341354544efe613912a6a Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35386 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Held felix-coreboot@felixheld.de --- M src/mainboard/asrock/h110m/devicetree.cb 1 file changed, 15 insertions(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved
diff --git a/src/mainboard/asrock/h110m/devicetree.cb b/src/mainboard/asrock/h110m/devicetree.cb index 88a4edc..572cd6a 100644 --- a/src/mainboard/asrock/h110m/devicetree.cb +++ b/src/mainboard/asrock/h110m/devicetree.cb @@ -327,12 +327,22 @@ subsystemid 0x1849 0x1a43 chip superio/nuvoton/nct6791d device pnp 2e.0 off end # Floppy - device pnp 2e.1 on # Parallel - # global - irq 0x1c = 0x10 + device pnp 2e.1 on + # Global Control Registers + # Device IRQ Polarity + irq 0x13 = 0x00 + irq 0x14 = 0x00 + # Global Option + irq 0x24 = 0xfb irq 0x27 = 0x10 - irq 0x2a = 0x64 - # parallel port + # Multi Function + irq 0x1a = 0xb0 + irq 0x1b = 0xe6 + irq 0x2a = 0x04 + irq 0x2c = 0x40 + irq 0x2d = 0x03 + + # Parallel Port io 0x60 = 0x0378 irq 0x70 = 7 drq 0x74 = 4 # No DMA
-
Felix Held (Code Review) -
Maxim Polyakov (Code Review)