Attention is currently required from: Elyes Haouas, Eric Lai.
Angel Pons has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83214?usp=email )
Change subject: treewide/azalia: Make codec_detect() common and use it ......................................................................
Patch Set 4:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83214/comment/d1a2f82b_3bfbf1f6?usp... : PS3, Line 7: treewide/azalia: Make codec_detect() common and use it I'd appreciate if you could make three separate changes, as this one removes three implementations at once:
- sb/intel/i82801ix - sb/intel/lynxpoint - soc/intel/common (used by Bay Trail)
File src/device/azalia_device.c:
https://review.coreboot.org/c/coreboot/+/83214/comment/a71231b7_0df1e033?usp... : PS3, Line 55: i82801ix does more stuff here:
``` if (azalia_enter_reset(base) < 0) goto no_codec; ```
https://review.coreboot.org/c/coreboot/+/83214/comment/f16e45fe_30bf1979?usp... : PS3, Line 59: if (CONFIG(AZALIA_LOCK_DOWN_R_WO_GCAP)) { This is only selected through `SOC_INTEL_COMMON_BLOCK_HDA_VERB`, which is only selected by some mainboards.
File src/southbridge/intel/lynxpoint/Kconfig:
https://review.coreboot.org/c/coreboot/+/83214/comment/ecc703f3_710a085a?usp... : PS3, Line 10: select AZALIA_LOCK_DOWN_R_WO_GCAP This is wrong. The original code is also wrong. CB:51645 is what actually locks GCAP on these platforms.