Subrata Banik has posted comments on this change. ( https://review.coreboot.org/19569 )
Change subject: common/block/cse: Use CSE PCH ID from device/pci_ids.h ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/19569/1/src/soc/intel/common/block/cse/cse.c File src/soc/intel/common/block/cse/cse.c:
Line 474: .device = PCI_DEVICE_ID_INTEL_APOLLOLAKE_CSE0
You might as well put this into a device_ids list so that we can append. Un
yes Aaron, i would like to wait, i could see lots of assumption here, for an example CSE BAR address can't be common for all soc. we will address CSE common code and push SKL use patch right after I2C. That time, we will take care.
/* default window for early boot, must be at least 12 bytes in size */ #define HECI1_BASE_ADDRESS 0xfed1a000