Attention is currently required from: Eran Mitrani, Kapil Porwal, Tarun, YH Lin.
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78260?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/rex/var/karis: add hook for WiFi SAR table
......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2:
Does it make sense if we make Kconfig change in a separate patch?
File src/mainboard/google/rex/Kconfig:
https://review.coreboot.org/c/coreboot/+/78260/comment/dcd36123_c3e996a8 :
PS2, Line 48: CHROMEOS_WIFI_SAR
As per the code changes here if required please add the information in commit message that adding this option for overall Rex baseboard and removing the same for Rex and Screebo models.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78260?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic989024ab9eb0fc439fc701c335a85986c4cfec5
Gerrit-Change-Number: 78260
Gerrit-PatchSet: 2
Gerrit-Owner: YH Lin
yueherngl@google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Attention: YH Lin
yueherngl@google.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Comment-Date: Mon, 09 Oct 2023 03:53:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment