Change in coreboot[master]: Revert "mb/google/octopus: Disable WLAN prior the entry of S5"

[Kane Chen (Code Review)]

Hello Chen Wisley, Justin TerAvest, Paul Menzel, build bot (Jenkins), Patrick Georgi, Furquan Shaikh,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/34309

to review the following change.

Change subject: Revert "mb/google/octopus: Disable WLAN prior the entry of S5"
......................................................................

Revert "mb/google/octopus: Disable WLAN prior the entry of S5"

This reverts commit 38dbd6892080c93ccd24fbfa46ed5d9bdb7d9e99.

Reason for revert: <INSERT REASONING HERE>
ODM helped to verify w/ BT runtime suspend disabled + revert this change
And issue is gone. so I revert this change

see the test result in https://partnerissuetracker.corp.google.com/issues/136039607#comment32

thanks

Change-Id: I248e9613cc39247a2bb88270c234c7d36d0ff60f
---
M src/mainboard/google/octopus/variants/baseboard/gpio.c
1 file changed, 0 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/34309/1

diff --git a/src/mainboard/google/octopus/variants/baseboard/gpio.c b/src/mainboard/google/octopus/variants/baseboard/gpio.c
index 3305c02..5326118 100644
--- a/src/mainboard/google/octopus/variants/baseboard/gpio.c
+++ b/src/mainboard/google/octopus/variants/baseboard/gpio.c
@@ -341,8 +341,6 @@
 static const struct pad_config sleep_s5_gpio_table[] = {
    /* BT_DISABLE_L */
    PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_109, 0, DEEP, NONE, Tx0RxDCRx1, SAME),
-	/* WLAN_DISABLE_L */
-	PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_116, 0, DEEP, NONE, Tx0RxDCRx1, SAME),
 };

const struct pad_config *__weak

[Kane Chen (Code Review)]

Hello Karthik Ramasubramanian, Tony Huang, Chen Wisley, Justin TerAvest, Paul Menzel, build bot (Jenkins), Patrick Georgi, Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34309

to look at the new patch set (#2).

Change subject: Revert "mb/google/octopus: Disable WLAN prior the entry of S5"
......................................................................

Revert "mb/google/octopus: Disable WLAN prior the entry of S5"

This reverts commit 38dbd6892080c93ccd24fbfa46ed5d9bdb7d9e99.

Reason for revert: <INSERT REASONING HERE>
ODM helped to verify w/ BT runtime suspend disabled + revert this change
And issue is gone. so I revert this change

see the test result in
https://partnerissuetracker.corp.google.com/issues/136039607#comment32

thanks

Change-Id: I248e9613cc39247a2bb88270c234c7d36d0ff60f
Signed-off-by: Kane Chen 
---
M src/mainboard/google/octopus/variants/baseboard/gpio.c
1 file changed, 0 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/34309/2

[Kane Chen (Code Review)]

Hello Karthik Ramasubramanian, Tony Huang, Chen Wisley, Justin TerAvest, Paul Menzel, build bot (Jenkins), Patrick Georgi, Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34309

to look at the new patch set (#3).

Change subject: Revert "mb/google/octopus: Disable WLAN prior the entry of S5"
......................................................................

Revert "mb/google/octopus: Disable WLAN prior the entry of S5"

This reverts commit 38dbd6892080c93ccd24fbfa46ed5d9bdb7d9e99.

Reason for revert: <INSERT REASONING HERE>
ODM helped to verify w/ BT runtime suspend disabled + revert this change
And issue is gone. so I revert this change

see the test result in
https://partnerissuetracker.corp.google.com/issues/136039607#comment32

Change-Id: I248e9613cc39247a2bb88270c234c7d36d0ff60f
Signed-off-by: Kane Chen 
---
M src/mainboard/google/octopus/variants/baseboard/gpio.c
1 file changed, 0 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/34309/3

[Justin TerAvest (Code Review)]

Justin TerAvest has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34309 )

Change subject: Revert "mb/google/octopus: Disable WLAN prior the entry of S5"
......................................................................

Patch Set 3:

Kane,
I'm still confused why the workaround here only applies to some octopus variants; are we sure this won't regress on ones besides meep/mimrock/bloog/blooguard?

[Kane Chen (Code Review)]

Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34309 )

Change subject: Revert "mb/google/octopus: Disable WLAN prior the entry of S5"
......................................................................

Patch Set 3:
> Patch Set 3:
>
> Kane,
> I'm still confused why the workaround here only applies to some octopus variants; are we sure this won't regress on ones besides meep/mimrock/bloog/blooguard?

Hi Justin, 
I've replied you in the email.
thanks

[Justin TerAvest (Code Review)]

Justin TerAvest has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34309 )

Change subject: Revert "mb/google/octopus: Disable WLAN prior the entry of S5"
......................................................................

Patch Set 3: Code-Review+2

Thanks for the offline explanation, Kane.

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34309 )

Change subject: Revert "mb/google/octopus: Disable WLAN prior the entry of S5"
......................................................................

Patch Set 3:

(2 comments)

https://review.coreboot.org/c/coreboot/+/34309/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/34309/3//COMMIT_MSG@11 
PS3, Line 11: <INSERT REASONING HERE>
Please remove this, as the reasoning is right below

https://review.coreboot.org/c/coreboot/+/34309/3//COMMIT_MSG@16 
PS3, Line 16: https://partnerissuetracker.corp.google.com/issues/136039607#comment32
This issue tracker seems to be restricted to people with a @google.com account. :(

[Kane Chen (Code Review)]

Hello Karthik Ramasubramanian, Tony Huang, Justin TerAvest, Chen Wisley, Paul Menzel, build bot (Jenkins), Patrick Georgi, Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34309

to look at the new patch set (#4).

Change subject: Revert "mb/google/octopus: Disable WLAN prior the entry of S5"
......................................................................

Revert "mb/google/octopus: Disable WLAN prior the entry of S5"

This reverts commit 38dbd6892080c93ccd24fbfa46ed5d9bdb7d9e99.

Reason for revert:
ODM helped to verify w/ BT runtime suspend disabled + revert this change
And issue is gone. so I revert this change

see the test result in
https://partnerissuetracker.corp.google.com/issues/136039607#comment32

Change-Id: I248e9613cc39247a2bb88270c234c7d36d0ff60f
Signed-off-by: Kane Chen 
---
M src/mainboard/google/octopus/variants/baseboard/gpio.c
1 file changed, 0 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/34309/4

[Kane Chen (Code Review)]

Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34309 )

Change subject: Revert "mb/google/octopus: Disable WLAN prior the entry of S5"
......................................................................

Patch Set 4:

hello, 
could we merge it?
thanks

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34309 )

Change subject: Revert "mb/google/octopus: Disable WLAN prior the entry of S5"
......................................................................

Patch Set 4:
> Patch Set 4:
>
> hello, 
> could we merge it?
> thanks

You need to resolve all unresolved commits on all patchsets. Until then, the submit option does not show up.

[Kane Chen (Code Review)]

Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34309 )

Change subject: Revert "mb/google/octopus: Disable WLAN prior the entry of S5"
......................................................................

Patch Set 4:

(2 comments)

https://review.coreboot.org/c/coreboot/+/34309/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/34309/3//COMMIT_MSG@11 
PS3, Line 11: <INSERT REASONING HERE>
> Please remove this, as the reasoning is right below

Done

https://review.coreboot.org/c/coreboot/+/34309/3//COMMIT_MSG@16 
PS3, Line 16: https://partnerissuetracker.corp.google.com/issues/136039607#comment32
> This issue tracker seems to be restricted to people with a @google.com account. […]

Done

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34309 )

Change subject: Revert "mb/google/octopus: Disable WLAN prior the entry of S5"
......................................................................

Revert "mb/google/octopus: Disable WLAN prior the entry of S5"

This reverts commit 38dbd6892080c93ccd24fbfa46ed5d9bdb7d9e99.

Reason for revert:
ODM helped to verify w/ BT runtime suspend disabled + revert this change
And issue is gone. so I revert this change

see the test result in
https://partnerissuetracker.corp.google.com/issues/136039607#comment32

Change-Id: I248e9613cc39247a2bb88270c234c7d36d0ff60f
Signed-off-by: Kane Chen 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/34309
Tested-by: build bot (Jenkins) 
Reviewed-by: Justin TerAvest 
---
M src/mainboard/google/octopus/variants/baseboard/gpio.c
1 file changed, 0 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Justin TerAvest: Looks good to me, approved

diff --git a/src/mainboard/google/octopus/variants/baseboard/gpio.c b/src/mainboard/google/octopus/variants/baseboard/gpio.c
index b3145d1..6f68522 100644
--- a/src/mainboard/google/octopus/variants/baseboard/gpio.c
+++ b/src/mainboard/google/octopus/variants/baseboard/gpio.c
@@ -361,8 +361,6 @@
 static const struct pad_config sleep_s5_gpio_table[] = {
    /* BT_DISABLE_L */
    PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_109, 0, DEEP, NONE, Tx0RxDCRx1, SAME),
-	/* WLAN_DISABLE_L */
-	PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_116, 0, DEEP, NONE, Tx0RxDCRx1, SAME),
 };

const struct pad_config *__weak