Change in coreboot[master]: mainboard/lenovo/x230: remove unnecessary code and comments for x230s
Bill XIE has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41390 )
Change subject: mainboard/lenovo/x230: remove unnecessary code and comments for x230s ......................................................................
mainboard/lenovo/x230: remove unnecessary code and comments for x230s
There are some unnecessary code and comments remaining before x230s support ( https://review.coreboot.org/c/coreboot/+/41168 ) gets accepted.
This commit will remove them.
Change-Id: Id59cdc5479aaf70809dd1ca613056263661455eb Signed-off-by: Bill XIE persmule@hardenedlinux.org --- M src/mainboard/lenovo/x230/variants/x230s/early_init.c M src/mainboard/lenovo/x230/variants/x230s/gma-mainboard.ads 2 files changed, 1 insertion(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/41390/1
diff --git a/src/mainboard/lenovo/x230/variants/x230s/early_init.c b/src/mainboard/lenovo/x230/variants/x230s/early_init.c index 0b4c084..17810fc 100644 --- a/src/mainboard/lenovo/x230/variants/x230s/early_init.c +++ b/src/mainboard/lenovo/x230/variants/x230s/early_init.c @@ -1,7 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* FIXME: Check if all includes are needed. */ - #include <stdint.h> #include <string.h> #include <timestamp.h> @@ -33,17 +31,7 @@ { 1, 1, -1 }, };
-void bootblock_mainboard_early_init(void) -{ - pci_write_config16(PCI_DEV(0, 0x1f, 0), 0x82, 0x3f0f); - pci_write_config16(PCI_DEV(0, 0x1f, 0), 0x80, 0x0010); -} - -/* FIXME: Put proper SPD map here. */ void mainboard_get_spd(spd_raw_data *spd, bool id_only) { read_spd(&spd[0], 0x50, id_only); - read_spd(&spd[1], 0x52, id_only); - read_spd(&spd[2], 0x51, id_only); - read_spd(&spd[3], 0x53, id_only); } diff --git a/src/mainboard/lenovo/x230/variants/x230s/gma-mainboard.ads b/src/mainboard/lenovo/x230/variants/x230s/gma-mainboard.ads index fb75293..fd2a5d5 100644 --- a/src/mainboard/lenovo/x230/variants/x230s/gma-mainboard.ads +++ b/src/mainboard/lenovo/x230/variants/x230s/gma-mainboard.ads @@ -16,7 +16,7 @@ HDMI2, HDMI3, Analog, - EDP, + eDP, others => Disabled);
end GMA.Mainboard;
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41390 )
Change subject: mainboard/lenovo/x230: remove unnecessary code and comments for x230s ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41390/1/src/mainboard/lenovo/x230/v... File src/mainboard/lenovo/x230/variants/x230s/early_init.c:
https://review.coreboot.org/c/coreboot/+/41390/1/src/mainboard/lenovo/x230/v... PS1, Line 3: #include <stdint.h> : #include <string.h> : #include <timestamp.h> : #include <arch/byteorder.h> : #include <device/mmio.h> : #include <device/pci_ops.h> : #include <device/pnp_ops.h> : #include <console/console.h> not used
https://review.coreboot.org/c/coreboot/+/41390/1/src/mainboard/lenovo/x230/v... PS1, Line 14: #include <southbridge/intel/bd82x6x/pch.h> : #include <southbridge/intel/common/gpio.h> not used
Hello build bot (Jenkins), Alexander Couzens, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41390
to look at the new patch set (#2).
Change subject: mainboard/lenovo/x230: remove unnecessary code and comments for x230s ......................................................................
mainboard/lenovo/x230: remove unnecessary code and comments for x230s
There are some unnecessary code and comments remaining before x230s support ( https://review.coreboot.org/c/coreboot/+/41168 ) gets accepted.
This commit will remove them.
Change-Id: Id59cdc5479aaf70809dd1ca613056263661455eb Signed-off-by: Bill XIE persmule@hardenedlinux.org --- M src/mainboard/lenovo/x230/variants/x230s/early_init.c M src/mainboard/lenovo/x230/variants/x230s/gma-mainboard.ads 2 files changed, 1 insertion(+), 23 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/41390/2
Hello build bot (Jenkins), Alexander Couzens, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41390
to look at the new patch set (#3).
Change subject: mainboard/lenovo/x230: remove unnecessary code and comments for x230s ......................................................................
mainboard/lenovo/x230: remove unnecessary code and comments for x230s
There are some unnecessary code and comments remaining before x230s support ( https://review.coreboot.org/c/coreboot/+/41168 ) gets accepted.
This commit will remove them, and in the mean time, set 3rdparty/libgfxinit which is mistakenly reverted to cdbfce27 by CB:41168 back to 2e87c0d4.
Change-Id: Id59cdc5479aaf70809dd1ca613056263661455eb Signed-off-by: Bill XIE persmule@hardenedlinux.org --- M src/mainboard/lenovo/x230/variants/x230s/early_init.c M src/mainboard/lenovo/x230/variants/x230s/gma-mainboard.ads 2 files changed, 1 insertion(+), 22 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/41390/3
Hello build bot (Jenkins), Alexander Couzens, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41390
to look at the new patch set (#4).
Change subject: mainboard/lenovo/x230: remove unnecessary code and comments for x230s ......................................................................
mainboard/lenovo/x230: remove unnecessary code and comments for x230s
There are some unnecessary code and comments remaining before x230s support ( https://review.coreboot.org/c/coreboot/+/41168 ) gets accepted.
This commit will remove them, and in the mean time, set 3rdparty/libgfxinit which is mistakenly reverted to cdbfce27 by CB:41168 back to 2e87c0d4.
Change-Id: Id59cdc5479aaf70809dd1ca613056263661455eb Signed-off-by: Bill XIE persmule@hardenedlinux.org --- M 3rdparty/libgfxinit M src/mainboard/lenovo/x230/variants/x230s/early_init.c M src/mainboard/lenovo/x230/variants/x230s/gma-mainboard.ads 3 files changed, 2 insertions(+), 23 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/41390/4
Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41390 )
Change subject: mainboard/lenovo/x230: remove unnecessary code and comments for x230s ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41390/1/src/mainboard/lenovo/x230/v... File src/mainboard/lenovo/x230/variants/x230s/early_init.c:
https://review.coreboot.org/c/coreboot/+/41390/1/src/mainboard/lenovo/x230/v... PS1, Line 14: #include <southbridge/intel/bd82x6x/pch.h> : #include <southbridge/intel/common/gpio.h>
not used
southbridge/intel/bd82x6x/pch.h is used, while southbridge/intel/common/gpio.h can be excluded.
Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41390 )
Change subject: mainboard/lenovo/x230: remove unnecessary code and comments for x230s ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41390/1/src/mainboard/lenovo/x230/v... File src/mainboard/lenovo/x230/variants/x230s/early_init.c:
https://review.coreboot.org/c/coreboot/+/41390/1/src/mainboard/lenovo/x230/v... PS1, Line 3: #include <stdint.h> : #include <string.h> : #include <timestamp.h> : #include <arch/byteorder.h> : #include <device/mmio.h> : #include <device/pci_ops.h> : #include <device/pnp_ops.h> : #include <console/console.h>
not used
Done
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41390 )
Change subject: mainboard/lenovo/x230: remove unnecessary code and comments for x230s ......................................................................
Patch Set 4: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/41390/1/src/mainboard/lenovo/x230/v... File src/mainboard/lenovo/x230/variants/x230s/early_init.c:
https://review.coreboot.org/c/coreboot/+/41390/1/src/mainboard/lenovo/x230/v... PS1, Line 14: #include <southbridge/intel/bd82x6x/pch.h> : #include <southbridge/intel/common/gpio.h>
southbridge/intel/bd82x6x/pch.h is used, while southbridge/intel/common/gpio.h can be excluded.
yes, <southbridge/intel/bd82x6x/pch.h> is used sorry
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41390 )
Change subject: mainboard/lenovo/x230: remove unnecessary code and comments for x230s ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41390/4/3rdparty/libgfxinit File 3rdparty/libgfxinit:
https://review.coreboot.org/c/coreboot/+/41390/4/3rdparty/libgfxinit@1 PS4, Line 1: Subproject commit 2e87c0d40a387c5b1f1afd3ce61ecdc7dad0e3e8 not related
Hello build bot (Jenkins), Alexander Couzens, Patrick Rudolph, HAOUAS Elyes,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41390
to look at the new patch set (#5).
Change subject: mainboard/lenovo/x230: remove unnecessary code and comments for x230s ......................................................................
mainboard/lenovo/x230: remove unnecessary code and comments for x230s
There are some unnecessary code and comments remaining before x230s support ( https://review.coreboot.org/c/coreboot/+/41168 ) gets accepted.
This commit will remove them.
Change-Id: Id59cdc5479aaf70809dd1ca613056263661455eb Signed-off-by: Bill XIE persmule@hardenedlinux.org --- M src/mainboard/lenovo/x230/variants/x230s/early_init.c M src/mainboard/lenovo/x230/variants/x230s/gma-mainboard.ads 2 files changed, 1 insertion(+), 22 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/41390/5
Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41390 )
Change subject: mainboard/lenovo/x230: remove unnecessary code and comments for x230s ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41390/4/3rdparty/libgfxinit File 3rdparty/libgfxinit:
https://review.coreboot.org/c/coreboot/+/41390/4/3rdparty/libgfxinit@1 PS4, Line 1: Subproject commit 2e87c0d40a387c5b1f1afd3ce61ecdc7dad0e3e8
not related
Now I split it as CB:41400.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41390 )
Change subject: mainboard/lenovo/x230: remove unnecessary code and comments for x230s ......................................................................
Patch Set 5: Code-Review+1
(4 comments)
https://review.coreboot.org/c/coreboot/+/41390/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41390/5//COMMIT_MSG@7 PS5, Line 7: m mb/lenovo/x230/var/x230s: Remove unnecessary code and comments
https://review.coreboot.org/c/coreboot/+/41390/5//COMMIT_MSG@10 PS5, Line 10: https://review.coreboot.org/c/coreboot/+/41168 I'd refer to the commit instead of gerrit
https://review.coreboot.org/c/coreboot/+/41390/5//COMMIT_MSG@11 PS5, Line 11: accepted "accepted"? What do you mean?
https://review.coreboot.org/c/coreboot/+/41390/5//COMMIT_MSG@13 PS5, Line 13: will remove present tense: removes
Hello build bot (Jenkins), Angel Pons, Alexander Couzens, Patrick Rudolph, HAOUAS Elyes,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41390
to look at the new patch set (#6).
Change subject: mainboard/lenovo/x230: Fix issues detected after 6b95507e is merged ......................................................................
mainboard/lenovo/x230: Fix issues detected after 6b95507e is merged
It seems that 6b95507ec5b087658178a325bdc68570bc48bb20 was not thoroughly reviewed at the time of submission. A lot of issues are still hanging.
This commit will fix them.
Change-Id: Id59cdc5479aaf70809dd1ca613056263661455eb Signed-off-by: Bill XIE persmule@hardenedlinux.org --- M Documentation/mainboard/lenovo/x230s.md M src/mainboard/lenovo/x230/devicetree.cb M src/mainboard/lenovo/x230/variants/x230/overridetree.cb M src/mainboard/lenovo/x230/variants/x230s/board_info.txt M src/mainboard/lenovo/x230/variants/x230s/early_init.c M src/mainboard/lenovo/x230/variants/x230s/gma-mainboard.ads M src/mainboard/lenovo/x230/variants/x230s/overridetree.cb 7 files changed, 11 insertions(+), 39 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/41390/6
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41390 )
Change subject: mainboard/lenovo/x230: Fix issues detected after 6b95507e is merged ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41390/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41390/6//COMMIT_MSG@7 PS6, Line 7: mainboard mb
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41390 )
Change subject: mainboard/lenovo/x230: Fix issues detected after 6b95507e is merged ......................................................................
Patch Set 6:
Why not make one commit per logical change? I’d prefer that.
Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41390 )
Change subject: mainboard/lenovo/x230: Fix issues detected after 6b95507e is merged ......................................................................
Patch Set 6:
Patch Set 6:
Why not make one commit per logical change? I’d prefer that.
I prefer it too. The problem is, before more issues can be detected, 6b95507e got merged.
Hello build bot (Jenkins), Angel Pons, Alexander Couzens, Patrick Rudolph, HAOUAS Elyes,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41390
to look at the new patch set (#7).
Change subject: mb/lenovo/x230: Fix issues detected after 6b95507e is merged ......................................................................
mb/lenovo/x230: Fix issues detected after 6b95507e is merged
It seems that 6b95507ec5b087658178a325bdc68570bc48bb20 was not thoroughly reviewed at the time of submission. A lot of issues are still hanging.
This commit will fix them.
Change-Id: Id59cdc5479aaf70809dd1ca613056263661455eb Signed-off-by: Bill XIE persmule@hardenedlinux.org --- M Documentation/mainboard/lenovo/x230s.md M src/mainboard/lenovo/x230/devicetree.cb M src/mainboard/lenovo/x230/variants/x230/overridetree.cb M src/mainboard/lenovo/x230/variants/x230s/board_info.txt M src/mainboard/lenovo/x230/variants/x230s/early_init.c M src/mainboard/lenovo/x230/variants/x230s/gma-mainboard.ads M src/mainboard/lenovo/x230/variants/x230s/overridetree.cb 7 files changed, 11 insertions(+), 39 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/41390/7
Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41390 )
Change subject: mb/lenovo/x230: Fix issues detected after 6b95507e is merged ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41390/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41390/6//COMMIT_MSG@7 PS6, Line 7: mainboard
mb
Done
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41390 )
Change subject: mb/lenovo/x230: Fix issues detected after 6b95507e is merged ......................................................................
Patch Set 8: Code-Review+1
(5 comments)
https://review.coreboot.org/c/coreboot/+/41390/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41390/5//COMMIT_MSG@10 PS5, Line 10: https://review.coreboot.org/c/coreboot/+/41168
I'd refer to the commit instead of gerrit
Done
https://review.coreboot.org/c/coreboot/+/41390/5//COMMIT_MSG@11 PS5, Line 11: accepted
"accepted"? What do you mean?
Done
https://review.coreboot.org/c/coreboot/+/41390/8/src/mainboard/lenovo/x230/d... File src/mainboard/lenovo/x230/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/41390/8/src/mainboard/lenovo/x230/d... PS8, Line 9: register "gpu_panel_port_select" = "0" # LVDS This should probably go to the variant overridetree
https://review.coreboot.org/c/coreboot/+/41390/8/src/mainboard/lenovo/x230/v... File src/mainboard/lenovo/x230/variants/x230s/board_info.txt:
https://review.coreboot.org/c/coreboot/+/41390/8/src/mainboard/lenovo/x230/v... PS8, Line 2: baseboard I don't think you meant to add "baseboard" here
https://review.coreboot.org/c/coreboot/+/41390/8/src/mainboard/lenovo/x230/v... File src/mainboard/lenovo/x230/variants/x230s/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/41390/8/src/mainboard/lenovo/x230/v... PS8, Line 2: # Disable DisplayPort Hotplug : register "gpu_dp_b_hotplug" = "4" : register "gpu_dp_c_hotplug" = "4" : register "gpu_dp_d_hotplug" = "4" Did you try dropping these completely?
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41390 )
Change subject: mb/lenovo/x230: Fix issues detected after 6b95507e is merged ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41390/8/src/mainboard/lenovo/x230/v... File src/mainboard/lenovo/x230/variants/x230/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/41390/8/src/mainboard/lenovo/x230/v... PS8, Line 4: docking_supported Why is it removed?
Hello build bot (Jenkins), Angel Pons, Alexander Couzens, Patrick Rudolph, HAOUAS Elyes,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41390
to look at the new patch set (#9).
Change subject: mb/lenovo/x230: Fix issues detected after 6b95507e is merged ......................................................................
mb/lenovo/x230: Fix issues detected after 6b95507e is merged
It seems that 6b95507ec5b087658178a325bdc68570bc48bb20 was not thoroughly reviewed at the time of submission. A lot of issues are still hanging.
This commit will fix them.
Change-Id: Id59cdc5479aaf70809dd1ca613056263661455eb Signed-off-by: Bill XIE persmule@hardenedlinux.org --- M Documentation/mainboard/lenovo/x230s.md M src/mainboard/lenovo/x230/devicetree.cb M src/mainboard/lenovo/x230/variants/x230/overridetree.cb M src/mainboard/lenovo/x230/variants/x230s/board_info.txt M src/mainboard/lenovo/x230/variants/x230s/early_init.c M src/mainboard/lenovo/x230/variants/x230s/gma-mainboard.ads M src/mainboard/lenovo/x230/variants/x230s/overridetree.cb 7 files changed, 11 insertions(+), 38 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/41390/9
Hello build bot (Jenkins), Angel Pons, Alexander Couzens, Patrick Rudolph, HAOUAS Elyes,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41390
to look at the new patch set (#10).
Change subject: mb/lenovo/x230: Fix issues detected after 6b95507e is merged ......................................................................
mb/lenovo/x230: Fix issues detected after 6b95507e is merged
It seems that 6b95507ec5b087658178a325bdc68570bc48bb20 was not thoroughly reviewed at the time of submission. A lot of issues are still hanging.
This commit will fix them.
Change-Id: Id59cdc5479aaf70809dd1ca613056263661455eb Signed-off-by: Bill XIE persmule@hardenedlinux.org --- M Documentation/mainboard/lenovo/x230s.md M src/mainboard/lenovo/x230/devicetree.cb M src/mainboard/lenovo/x230/variants/x230/overridetree.cb M src/mainboard/lenovo/x230/variants/x230s/early_init.c M src/mainboard/lenovo/x230/variants/x230s/gma-mainboard.ads M src/mainboard/lenovo/x230/variants/x230s/overridetree.cb 6 files changed, 10 insertions(+), 37 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/41390/10
Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41390 )
Change subject: mb/lenovo/x230: Fix issues detected after 6b95507e is merged ......................................................................
Patch Set 9:
(4 comments)
https://review.coreboot.org/c/coreboot/+/41390/8/src/mainboard/lenovo/x230/d... File src/mainboard/lenovo/x230/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/41390/8/src/mainboard/lenovo/x230/d... PS8, Line 9: register "gpu_panel_port_select" = "0" # LVDS
This should probably go to the variant overridetree
It also applies to x230.
https://review.coreboot.org/c/coreboot/+/41390/8/src/mainboard/lenovo/x230/v... File src/mainboard/lenovo/x230/variants/x230/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/41390/8/src/mainboard/lenovo/x230/v... PS8, Line 4: docking_supported
Why is it removed?
It does not present in the original devicetree.cb of x230, but presents in that of t430s. I do believe that it could be added here.
https://review.coreboot.org/c/coreboot/+/41390/8/src/mainboard/lenovo/x230/v... File src/mainboard/lenovo/x230/variants/x230s/board_info.txt:
https://review.coreboot.org/c/coreboot/+/41390/8/src/mainboard/lenovo/x230/v... PS8, Line 2: baseboard
I don't think you meant to add "baseboard" here
Done
https://review.coreboot.org/c/coreboot/+/41390/8/src/mainboard/lenovo/x230/v... File src/mainboard/lenovo/x230/variants/x230s/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/41390/8/src/mainboard/lenovo/x230/v... PS8, Line 2: # Disable DisplayPort Hotplug : register "gpu_dp_b_hotplug" = "4" : register "gpu_dp_c_hotplug" = "4" : register "gpu_dp_d_hotplug" = "4"
Did you try dropping these completely?
No. These values are obtained via autoport, which means they are set so with vendor firmware, too.
Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41390 )
Change subject: mb/lenovo/x230: Fix issues detected after 6b95507e is merged ......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41390/8/src/mainboard/lenovo/x230/v... File src/mainboard/lenovo/x230/variants/x230s/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/41390/8/src/mainboard/lenovo/x230/v... PS8, Line 2: # Disable DisplayPort Hotplug : register "gpu_dp_b_hotplug" = "4" : register "gpu_dp_c_hotplug" = "4" : register "gpu_dp_d_hotplug" = "4"
No. These values are obtained via autoport, which means they are set so with vendor firmware, too.
src/northbridge/intel/sandybridge/gma.h says 4 means "Enabled, 2ms short pulse".
Hello build bot (Jenkins), Angel Pons, Alexander Couzens, Patrick Rudolph, HAOUAS Elyes,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41390
to look at the new patch set (#11).
Change subject: mb/lenovo/x230: Fix issues detected after 6b95507e is merged ......................................................................
mb/lenovo/x230: Fix issues detected after 6b95507e is merged
It seems that 6b95507ec5b087658178a325bdc68570bc48bb20 was not thoroughly reviewed at the time of submission. A lot of issues are still hanging.
This commit will fix them.
Change-Id: Id59cdc5479aaf70809dd1ca613056263661455eb Signed-off-by: Bill XIE persmule@hardenedlinux.org --- M Documentation/mainboard/lenovo/x230s.md M src/mainboard/lenovo/x230/devicetree.cb M src/mainboard/lenovo/x230/variants/x230/overridetree.cb M src/mainboard/lenovo/x230/variants/x230s/early_init.c M src/mainboard/lenovo/x230/variants/x230s/gma-mainboard.ads M src/mainboard/lenovo/x230/variants/x230s/overridetree.cb 6 files changed, 10 insertions(+), 37 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/41390/11
Alexander Couzens has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41390 )
Change subject: mb/lenovo/x230: Fix issues detected after 6b95507e is merged ......................................................................
Patch Set 11: Code-Review-1
(1 comment)
The content LGTM. Can you split the commit up into multiple commits?
* docs: fix typo * x230s: disable unconnected ports * x230/x230s: disable superseed capabilities for usb port 3 - there are no RXP/TXP lines (one line dts change) * x230/x230s: reorganisze baseboard & overrides devices (all remaining dts changes, since this is a no-op) * x230s: clean up early_init as similiar to x230.
https://review.coreboot.org/c/coreboot/+/41390/11/src/mainboard/lenovo/x230/... File src/mainboard/lenovo/x230/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/41390/11/src/mainboard/lenovo/x230/... PS11, Line 65: register "superspeed_capable_ports" = "0xf" please move superspeed_capable_ports into a seperate commit.
Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41390 )
Change subject: mb/lenovo/x230: Fix issues detected after 6b95507e is merged ......................................................................
Patch Set 11:
Patch Set 11: Code-Review-1
(1 comment)
The content LGTM. Can you split the commit up into multiple commits?
- docs: fix typo
- x230s: disable unconnected ports
- x230/x230s: disable superseed capabilities for usb port 3 - there are no RXP/TXP lines (one line dts change)
- x230/x230s: reorganisze baseboard & overrides devices (all remaining dts changes, since this is a no-op)
- x230s: clean up early_init as similiar to x230.
I can only accept to split "disabling superspeed capabilities" stuff into a separate commit. It is not my fault that my commit trying to introducing x230s (CB:41168) got merged semi-finished.
I would rather completely revert CB:41168 and commit it again in a more elegant way, with "disabling superspeed capabilities" splitted out, as you wish.
Alexander Couzens has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41390 )
Change subject: mb/lenovo/x230: Fix issues detected after 6b95507e is merged ......................................................................
Patch Set 11: -Code-Review
I can only accept to split "disabling superspeed capabilities" stuff into a separate commit. It is not my fault that my commit trying to introducing x230s (CB:41168) got merged semi-finished.
I would rather completely revert CB:41168 and commit it again in a more elegant way, with "disabling superspeed capabilities" splitted out, as you wish.
Sure, you can revert the original commit, but I don't think it's necessary.
I don't think who's fault is important here. The x230s is part of the tree and you like to improve it. Great! Just imagine the original x230s commit came from me. Why do you want to improve everything in one commit?
Usually smaller commits are much faster reviewed and most times people don't overseen stuff. If you like to have only one commit (except the disable superseed), please rework the commit message, since it doesn't really describe what you do. Only the reason what lead to the commit.
(removed -1)
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41390 )
Change subject: mb/lenovo/x230: Fix issues detected after 6b95507e is merged ......................................................................
Patch Set 11:
Patch Set 6:
Patch Set 6:
Why not make one commit per logical change? I’d prefer that.
I prefer it too. The problem is, before more issues can be detected, 6b95507e got merged.
I understood. But I meant, as Lynxis now pointed out too, that the fix-ups in this change-sets should be added as one commit per each logical fix, and not all together.
Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41390 )
Change subject: mb/lenovo/x230: Fix issues detected after 6b95507e is merged ......................................................................
Patch Set 11:
Patch Set 11: -Code-Review
I can only accept to split "disabling superspeed capabilities" stuff into a separate commit. It is not my fault that my commit trying to introducing x230s (CB:41168) got merged semi-finished.
I would rather completely revert CB:41168 and commit it again in a more elegant way, with "disabling superspeed capabilities" splitted out, as you wish.
Sure, you can revert the original commit, but I don't think it's necessary.
I don't think who's fault is important here. The x230s is part of the tree and you like to improve it. Great! Just imagine the original x230s commit came from me. Why do you want to improve everything in one commit?
Usually smaller commits are much faster reviewed and most times people don't overseen stuff. If you like to have only one commit (except the disable superseed), please rework the commit message, since it doesn't really describe what you do. Only the reason what lead to the commit.
(removed -1)
Why do you want to improve everything in one commit?
Because I believe they should be done in the workflow to add x230s support.
Hello build bot (Jenkins), Angel Pons, Alexander Couzens, Patrick Rudolph, HAOUAS Elyes,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41390
to look at the new patch set (#12).
Change subject: mainboard/lenovo/x230: Add ThinkPad x230s as a variant ......................................................................
mainboard/lenovo/x230: Add ThinkPad x230s as a variant
The code is based on autoport and that for X230. Major differences are: - Only one DDR3 slot - HM77 PCH - M.2 socket instead of mini pci-e - no docking - no tpm
Tested: - CPU i5-3337U - Slotted DIMM 8GiB - Camera - pci-e and usb2 on M.2 slot with A key for wlan - sata and usb2 (no superspeed components) on M.2 slot with B key for wwan - On board SDHCI connected to pci-e - USB3 ports - libgfxinit-based graphic init - NVRAM options for North and South bridges - Sound - Thinkpad EC - S3 - Linux 4.9 within Debian GNU/Linux stable, loaded from Seabios.
Untested: - Touch screen, which is said to work under ubuntu but not debian.
Change-Id: Id59cdc5479aaf70809dd1ca613056263661455eb Signed-off-by: Bill XIE persmule@hardenedlinux.org --- M Documentation/mainboard/index.md M Documentation/mainboard/lenovo/Ivy_Bridge_series.md A Documentation/mainboard/lenovo/x230s.md A Documentation/mainboard/lenovo/x230s_bc_removed.jpg M src/mainboard/lenovo/x230/Kconfig M src/mainboard/lenovo/x230/Kconfig.name M src/mainboard/lenovo/x230/Makefile.inc M src/mainboard/lenovo/x230/board_info.txt M src/mainboard/lenovo/x230/devicetree.cb M src/mainboard/lenovo/x230/hda_verb.c A src/mainboard/lenovo/x230/variants/x230/board_info.txt R src/mainboard/lenovo/x230/variants/x230/data.vbt R src/mainboard/lenovo/x230/variants/x230/early_init.c R src/mainboard/lenovo/x230/variants/x230/gma-mainboard.ads R src/mainboard/lenovo/x230/variants/x230/gpio.c A src/mainboard/lenovo/x230/variants/x230/hda_verb.c A src/mainboard/lenovo/x230/variants/x230/overridetree.cb A src/mainboard/lenovo/x230/variants/x230s/board_info.txt A src/mainboard/lenovo/x230/variants/x230s/data.vbt A src/mainboard/lenovo/x230/variants/x230s/early_init.c A src/mainboard/lenovo/x230/variants/x230s/gma-mainboard.ads A src/mainboard/lenovo/x230/variants/x230s/gpio.c A src/mainboard/lenovo/x230/variants/x230s/hda_verb.c A src/mainboard/lenovo/x230/variants/x230s/overridetree.cb 24 files changed, 485 insertions(+), 101 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/41390/12
Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41390 )
Change subject: mainboard/lenovo/x230: Add ThinkPad x230s as a variant ......................................................................
Patch Set 12:
Patch Set 11:
Patch Set 6:
Patch Set 6:
Why not make one commit per logical change? I’d prefer that.
I prefer it too. The problem is, before more issues can be detected, 6b95507e got merged.
I understood. But I meant, as Lynxis now pointed out too, that the fix-ups in this change-sets should be added as one commit per each logical fix, and not all together.
Then adding support for x230s should be one single logical change, so rather than create fragmented fix-ups, I prefer to revert, recommit and re-review the x230s commit (combine the fix-ups into the main commit), to make it one single logical change again.
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Angel Pons, Alexander Couzens, Patrick Rudolph, HAOUAS Elyes,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41390
to look at the new patch set (#13).
Change subject: mainboard/lenovo/x230: Add ThinkPad x230s as a variant ......................................................................
mainboard/lenovo/x230: Add ThinkPad x230s as a variant
The code is based on autoport and that for X230. Major differences are: - Only one DDR3 slot - HM77 PCH - M.2 socket instead of mini pci-e - no docking - no tpm
Tested: - CPU i5-3337U - Slotted DIMM 8GiB - Camera - pci-e and usb2 on M.2 slot with A key for wlan - sata and usb2 (no superspeed components) on M.2 slot with B key for wwan - On board SDHCI connected to pci-e - USB3 ports - libgfxinit-based graphic init - NVRAM options for North and South bridges - Sound - Thinkpad EC - S3 - Linux 4.9 within Debian GNU/Linux stable, loaded from Seabios.
Untested: - Touch screen, which is said to work under ubuntu but not debian.
Change-Id: Id59cdc5479aaf70809dd1ca613056263661455eb Signed-off-by: Bill XIE persmule@hardenedlinux.org --- M Documentation/mainboard/index.md M Documentation/mainboard/lenovo/Ivy_Bridge_series.md A Documentation/mainboard/lenovo/x230s.md A Documentation/mainboard/lenovo/x230s_bc_removed.jpg M src/mainboard/lenovo/x230/Kconfig M src/mainboard/lenovo/x230/Kconfig.name M src/mainboard/lenovo/x230/Makefile.inc M src/mainboard/lenovo/x230/board_info.txt M src/mainboard/lenovo/x230/devicetree.cb M src/mainboard/lenovo/x230/hda_verb.c A src/mainboard/lenovo/x230/variants/x230/board_info.txt R src/mainboard/lenovo/x230/variants/x230/data.vbt R src/mainboard/lenovo/x230/variants/x230/early_init.c R src/mainboard/lenovo/x230/variants/x230/gma-mainboard.ads R src/mainboard/lenovo/x230/variants/x230/gpio.c A src/mainboard/lenovo/x230/variants/x230/hda_verb.c A src/mainboard/lenovo/x230/variants/x230/overridetree.cb A src/mainboard/lenovo/x230/variants/x230s/board_info.txt A src/mainboard/lenovo/x230/variants/x230s/data.vbt A src/mainboard/lenovo/x230/variants/x230s/early_init.c A src/mainboard/lenovo/x230/variants/x230s/gma-mainboard.ads A src/mainboard/lenovo/x230/variants/x230s/gpio.c A src/mainboard/lenovo/x230/variants/x230s/hda_verb.c A src/mainboard/lenovo/x230/variants/x230s/overridetree.cb 24 files changed, 485 insertions(+), 101 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/41390/13
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Angel Pons, Alexander Couzens, Patrick Rudolph, HAOUAS Elyes,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41390
to look at the new patch set (#14).
Change subject: mainboard/lenovo/x230: Add ThinkPad x230s as a variant ......................................................................
mainboard/lenovo/x230: Add ThinkPad x230s as a variant
The code is based on autoport and that for X230. Major differences are: - Only one DDR3 slot - HM77 PCH - M.2 socket instead of mini pci-e - no docking - no tpm
Tested: - CPU i5-3337U - Slotted DIMM 8GiB - Camera - pci-e and usb2 on M.2 slot with A key for wlan - sata and usb2 (no superspeed components) on M.2 slot with B key for wwan - On board SDHCI connected to pci-e - USB3 ports - libgfxinit-based graphic init - NVRAM options for North and South bridges - Sound - Thinkpad EC - S3 - Linux 4.9 within Debian GNU/Linux stable, loaded from Seabios.
Untested: - Touch screen, which is said to work under ubuntu but not debian.
Change-Id: Id59cdc5479aaf70809dd1ca613056263661455eb Signed-off-by: Bill XIE persmule@hardenedlinux.org --- M Documentation/mainboard/index.md M Documentation/mainboard/lenovo/Ivy_Bridge_series.md A Documentation/mainboard/lenovo/x230s.md A Documentation/mainboard/lenovo/x230s_bc_removed.jpg M src/mainboard/lenovo/x230/Kconfig M src/mainboard/lenovo/x230/Kconfig.name A src/mainboard/lenovo/x230/variants/x230s/board_info.txt A src/mainboard/lenovo/x230/variants/x230s/data.vbt A src/mainboard/lenovo/x230/variants/x230s/early_init.c A src/mainboard/lenovo/x230/variants/x230s/gma-mainboard.ads A src/mainboard/lenovo/x230/variants/x230s/gpio.c A src/mainboard/lenovo/x230/variants/x230s/hda_verb.c A src/mainboard/lenovo/x230/variants/x230s/overridetree.cb 13 files changed, 367 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/41390/14
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Angel Pons, Alexander Couzens, Patrick Rudolph, HAOUAS Elyes,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41390
to look at the new patch set (#15).
Change subject: mainboard/lenovo/x230: Add ThinkPad x230s as a variant ......................................................................
mainboard/lenovo/x230: Add ThinkPad x230s as a variant
The code is based on autoport and that for X230. Major differences are: - Only one DDR3 slot - HM77 PCH - M.2 socket instead of mini pci-e - no docking - no tpm
Tested: - CPU i5-3337U - Slotted DIMM 8GiB - Camera - pci-e and usb2 on M.2 slot with A key for wlan - sata and usb2 (no superspeed components) on M.2 slot with B key for wwan - On board SDHCI connected to pci-e - USB3 ports - libgfxinit-based graphic init - NVRAM options for North and South bridges - Sound - Thinkpad EC - S3 - Linux 4.9 within Debian GNU/Linux stable, loaded from Seabios.
Untested: - Touch screen, which is said to work under ubuntu but not debian.
Change-Id: Id59cdc5479aaf70809dd1ca613056263661455eb Signed-off-by: Bill XIE persmule@hardenedlinux.org --- M Documentation/mainboard/index.md M Documentation/mainboard/lenovo/Ivy_Bridge_series.md A Documentation/mainboard/lenovo/x230s.md A Documentation/mainboard/lenovo/x230s_bc_removed.jpg M src/mainboard/lenovo/x230/Kconfig M src/mainboard/lenovo/x230/Kconfig.name A src/mainboard/lenovo/x230/variants/x230s/board_info.txt A src/mainboard/lenovo/x230/variants/x230s/data.vbt A src/mainboard/lenovo/x230/variants/x230s/early_init.c A src/mainboard/lenovo/x230/variants/x230s/gma-mainboard.ads A src/mainboard/lenovo/x230/variants/x230s/gpio.c A src/mainboard/lenovo/x230/variants/x230s/hda_verb.c A src/mainboard/lenovo/x230/variants/x230s/overridetree.cb 13 files changed, 363 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/41390/15
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41390 )
Change subject: mainboard/lenovo/x230: Add ThinkPad x230s as a variant ......................................................................
Patch Set 16: Code-Review+1
(20 comments)
https://review.coreboot.org/c/coreboot/+/41390/16//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41390/16//COMMIT_MSG@12 PS16, Line 12: pci-e PCIe
https://review.coreboot.org/c/coreboot/+/41390/16//COMMIT_MSG@13 PS16, Line 13: n Capitalize all elements of the list?
https://review.coreboot.org/c/coreboot/+/41390/16//COMMIT_MSG@14 PS16, Line 14: tpm TPM
https://review.coreboot.org/c/coreboot/+/41390/16//COMMIT_MSG@18 PS16, Line 18: DIMM 8GiB 8 GiB SO-DIMM
https://review.coreboot.org/c/coreboot/+/41390/16//COMMIT_MSG@20 PS16, Line 20: usb2 USB2
https://review.coreboot.org/c/coreboot/+/41390/16//COMMIT_MSG@20 PS16, Line 20: pci-e PCIe
https://review.coreboot.org/c/coreboot/+/41390/16//COMMIT_MSG@21 PS16, Line 21: sata SATA
https://review.coreboot.org/c/coreboot/+/41390/16//COMMIT_MSG@21 PS16, Line 21: usb2 USB2
https://review.coreboot.org/c/coreboot/+/41390/16//COMMIT_MSG@21 PS16, Line 21: two spaces
https://review.coreboot.org/c/coreboot/+/41390/16//COMMIT_MSG@21 PS16, Line 21: wwan WWAN
https://review.coreboot.org/c/coreboot/+/41390/16//COMMIT_MSG@22 PS16, Line 22: pci-e PCIe
https://review.coreboot.org/c/coreboot/+/41390/16//COMMIT_MSG@24 PS16, Line 24: graphic I'd use plural here, "graphics init"
https://review.coreboot.org/c/coreboot/+/41390/16//COMMIT_MSG@27 PS16, Line 27: Thinkpad ThinkPad
https://review.coreboot.org/c/coreboot/+/41390/16//COMMIT_MSG@30 PS16, Line 30: Seabios SeaBIOS
And it fits on the previous line
https://review.coreboot.org/c/coreboot/+/41390/16/Documentation/mainboard/le... File Documentation/mainboard/lenovo/x230s.md:
https://review.coreboot.org/c/coreboot/+/41390/16/Documentation/mainboard/le... PS16, Line 1: missing "ThinkPad"
https://review.coreboot.org/c/coreboot/+/41390/16/Documentation/mainboard/le... PS16, Line 11: Its I assume the "Its" possessive pronoun refers to "the ThinkPad X230s", but it is not clear at all.
Instead, I would use "The".
https://review.coreboot.org/c/coreboot/+/41390/16/Documentation/mainboard/le... PS16, Line 13: mine not sure if documentation should refer to the author. It's not directly visible in doc.cb.o who wrote what part of it.
https://review.coreboot.org/c/coreboot/+/41390/16/src/mainboard/lenovo/x230/... File src/mainboard/lenovo/x230/Kconfig:
https://review.coreboot.org/c/coreboot/+/41390/16/src/mainboard/lenovo/x230/... PS16, Line 22: !BOARD_LENOVO_X230S That there are mixed `!BOARD_LENOVO_X230S` and `BOARD_LENOVO_X230 || BOARD_LENOVO_X230T` is odd.
https://review.coreboot.org/c/coreboot/+/41390/16/src/mainboard/lenovo/x230/... File src/mainboard/lenovo/x230/variants/x230s/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/41390/16/src/mainboard/lenovo/x230/... PS16, Line 17: 0x0065 0x0065 = 101, this is redundant
https://review.coreboot.org/c/coreboot/+/41390/16/src/mainboard/lenovo/x230/... PS16, Line 23: # Huh? An empty comment?
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41390 )
Change subject: mainboard/lenovo/x230: Add ThinkPad x230s as a variant ......................................................................
Patch Set 16:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41390/16/src/mainboard/lenovo/x230/... File src/mainboard/lenovo/x230/variants/x230s/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/41390/16/src/mainboard/lenovo/x230/... PS16, Line 21: This should be:
register "xhci_switchable_ports" = "0x3" register "superspeed_capable_ports" = "0x3"
Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41390 )
Change subject: mainboard/lenovo/x230: Add ThinkPad x230s as a variant ......................................................................
Patch Set 16:
(20 comments)
https://review.coreboot.org/c/coreboot/+/41390/16//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41390/16//COMMIT_MSG@12 PS16, Line 12: pci-e
PCIe
Done
https://review.coreboot.org/c/coreboot/+/41390/16//COMMIT_MSG@13 PS16, Line 13: n
Capitalize all elements of the list?
Done
https://review.coreboot.org/c/coreboot/+/41390/16//COMMIT_MSG@14 PS16, Line 14: tpm
TPM
Done
https://review.coreboot.org/c/coreboot/+/41390/16//COMMIT_MSG@18 PS16, Line 18: DIMM 8GiB
8 GiB SO-DIMM
Done
https://review.coreboot.org/c/coreboot/+/41390/16//COMMIT_MSG@20 PS16, Line 20: usb2
USB2
Done
https://review.coreboot.org/c/coreboot/+/41390/16//COMMIT_MSG@20 PS16, Line 20: pci-e
PCIe
Done
https://review.coreboot.org/c/coreboot/+/41390/16//COMMIT_MSG@21 PS16, Line 21: wwan
WWAN
Done
https://review.coreboot.org/c/coreboot/+/41390/16//COMMIT_MSG@21 PS16, Line 21:
two spaces
Done
https://review.coreboot.org/c/coreboot/+/41390/16//COMMIT_MSG@21 PS16, Line 21: usb2
USB2
Done
https://review.coreboot.org/c/coreboot/+/41390/16//COMMIT_MSG@21 PS16, Line 21: sata
SATA
Done
https://review.coreboot.org/c/coreboot/+/41390/16//COMMIT_MSG@22 PS16, Line 22: pci-e
PCIe
Done
https://review.coreboot.org/c/coreboot/+/41390/16//COMMIT_MSG@24 PS16, Line 24: graphic
I'd use plural here, "graphics init"
Done
https://review.coreboot.org/c/coreboot/+/41390/16//COMMIT_MSG@27 PS16, Line 27: Thinkpad
ThinkPad
Done
https://review.coreboot.org/c/coreboot/+/41390/16//COMMIT_MSG@30 PS16, Line 30: Seabios
SeaBIOS […]
Done
https://review.coreboot.org/c/coreboot/+/41390/16/Documentation/mainboard/le... File Documentation/mainboard/lenovo/x230s.md:
https://review.coreboot.org/c/coreboot/+/41390/16/Documentation/mainboard/le... PS16, Line 1:
missing "ThinkPad"
Done
https://review.coreboot.org/c/coreboot/+/41390/16/Documentation/mainboard/le... PS16, Line 11: Its
I assume the "Its" possessive pronoun refers to "the ThinkPad X230s", but it is not clear at all. […]
Done
https://review.coreboot.org/c/coreboot/+/41390/16/Documentation/mainboard/le... PS16, Line 13: mine
not sure if documentation should refer to the author. It's not directly visible in doc.cb. […]
Done
https://review.coreboot.org/c/coreboot/+/41390/16/src/mainboard/lenovo/x230/... File src/mainboard/lenovo/x230/variants/x230s/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/41390/16/src/mainboard/lenovo/x230/... PS16, Line 17: 0x0065
0x0065 = 101, this is redundant
Done
https://review.coreboot.org/c/coreboot/+/41390/16/src/mainboard/lenovo/x230/... PS16, Line 21:
This should be: […]
They may be added in CB:41505, but is 0x3 really necessary? since xhci port3 of X230s is not exposed anywhere.
https://review.coreboot.org/c/coreboot/+/41390/16/src/mainboard/lenovo/x230/... PS16, Line 23: #
Huh? An empty comment?
Done
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Angel Pons, Alexander Couzens, Patrick Rudolph, HAOUAS Elyes,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41390
to look at the new patch set (#17).
Change subject: mainboard/lenovo/x230: Add ThinkPad x230s as a variant ......................................................................
mainboard/lenovo/x230: Add ThinkPad x230s as a variant
The code is based on autoport and that for X230. Major differences are: - Only one DDR3 slot - HM77 PCH - M.2 socket instead of mini PCIe - No docking - No TPM
Tested: - CPU i5-3337U - 8GiB SO-DIMM - Camera - PCIe and USB2 on M.2 slot with A key for WLAN - SATA and USB2 (no SuperSpeed components) on M.2 slot with B key for WWAN - On board SDHCI connected to PCIe - USB3 ports - libgfxinit-based graphics init - NVRAM options for North and South bridges - Sound - ThinkPad EC - S3 - Linux 4.9 within Debian GNU/Linux stable, loaded from SeaBIOS.
Untested: - Touch screen, which is said to work under ubuntu but not debian.
Change-Id: Id59cdc5479aaf70809dd1ca613056263661455eb Signed-off-by: Bill XIE persmule@hardenedlinux.org --- M Documentation/mainboard/index.md M Documentation/mainboard/lenovo/Ivy_Bridge_series.md A Documentation/mainboard/lenovo/x230s.md A Documentation/mainboard/lenovo/x230s_bc_removed.jpg M src/mainboard/lenovo/x230/Kconfig M src/mainboard/lenovo/x230/Kconfig.name A src/mainboard/lenovo/x230/variants/x230s/board_info.txt A src/mainboard/lenovo/x230/variants/x230s/data.vbt A src/mainboard/lenovo/x230/variants/x230s/early_init.c A src/mainboard/lenovo/x230/variants/x230s/gma-mainboard.ads A src/mainboard/lenovo/x230/variants/x230s/gpio.c A src/mainboard/lenovo/x230/variants/x230s/hda_verb.c A src/mainboard/lenovo/x230/variants/x230s/overridetree.cb 13 files changed, 362 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/41390/17
Alexander Couzens has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41390 )
Change subject: mainboard/lenovo/x230: Add ThinkPad x230s as a variant ......................................................................
Patch Set 17:
(1 comment)
If you have the schematics, it would be nice if you could add commnets in early_init.
https://review.coreboot.org/c/coreboot/+/41390/17/src/mainboard/lenovo/x230/... File src/mainboard/lenovo/x230/variants/x230s/early_init.c:
https://review.coreboot.org/c/coreboot/+/41390/17/src/mainboard/lenovo/x230/... PS17, Line 9: { 1, 3, 0 }, can you add the description of the usb ports here?
Alexander Couzens has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41390 )
Change subject: mainboard/lenovo/x230: Add ThinkPad x230s as a variant ......................................................................
Patch Set 17: Code-Review+1
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Angel Pons, Alexander Couzens, Patrick Rudolph, HAOUAS Elyes,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41390
to look at the new patch set (#18).
Change subject: mainboard/lenovo/x230: Add ThinkPad x230s as a variant ......................................................................
mainboard/lenovo/x230: Add ThinkPad x230s as a variant
The code is based on autoport and that for X230. Major differences are: - Only one DDR3 slot - HM77 PCH - M.2 socket instead of mini PCIe - No docking - No TPM
Tested: - CPU i5-3337U - 8GiB SO-DIMM - Camera - PCIe and USB2 on M.2 slot with A key for WLAN - SATA and USB2 (no SuperSpeed components) on M.2 slot with B key for WWAN - On board SDHCI connected to PCIe - USB3 ports - libgfxinit-based graphics init - NVRAM options for North and South bridges - Sound - ThinkPad EC - S3 - Linux 4.9 within Debian GNU/Linux stable, loaded from SeaBIOS.
Untested: - Touch screen, which is said to work under ubuntu but not debian.
Change-Id: Id59cdc5479aaf70809dd1ca613056263661455eb Signed-off-by: Bill XIE persmule@hardenedlinux.org --- M 3rdparty/libgfxinit M Documentation/mainboard/index.md M Documentation/mainboard/lenovo/Ivy_Bridge_series.md A Documentation/mainboard/lenovo/x230s.md A Documentation/mainboard/lenovo/x230s_bc_removed.jpg M src/mainboard/lenovo/x230/Kconfig M src/mainboard/lenovo/x230/Kconfig.name A src/mainboard/lenovo/x230/variants/x230s/board_info.txt A src/mainboard/lenovo/x230/variants/x230s/data.vbt A src/mainboard/lenovo/x230/variants/x230s/early_init.c A src/mainboard/lenovo/x230/variants/x230s/gma-mainboard.ads A src/mainboard/lenovo/x230/variants/x230s/gpio.c A src/mainboard/lenovo/x230/variants/x230s/hda_verb.c A src/mainboard/lenovo/x230/variants/x230s/overridetree.cb 14 files changed, 363 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/41390/18
Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41390 )
Change subject: mainboard/lenovo/x230: Add ThinkPad x230s as a variant ......................................................................
Patch Set 18:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41390/17/src/mainboard/lenovo/x230/... File src/mainboard/lenovo/x230/variants/x230s/early_init.c:
https://review.coreboot.org/c/coreboot/+/41390/17/src/mainboard/lenovo/x230/... PS17, Line 9: { 1, 3, 0 },
can you add the description of the usb ports here?
Done
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41390 )
Change subject: mainboard/lenovo/x230: Add ThinkPad x230s as a variant ......................................................................
Patch Set 19:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41390/19/3rdparty/libgfxinit File 3rdparty/libgfxinit:
https://review.coreboot.org/c/coreboot/+/41390/19/3rdparty/libgfxinit@a1 PS19, Line 1: Subproject commit 8fc8e49a932c7a011429b333765c6b0ed09cd742 Related?
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Angel Pons, Alexander Couzens, Patrick Rudolph, HAOUAS Elyes,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41390
to look at the new patch set (#20).
Change subject: mainboard/lenovo/x230: Add ThinkPad x230s as a variant ......................................................................
mainboard/lenovo/x230: Add ThinkPad x230s as a variant
The code is based on autoport and that for X230. Major differences are: - Only one DDR3 slot - HM77 PCH - M.2 socket instead of mini PCIe - No docking - No TPM
Tested: - CPU i5-3337U - 8GiB SO-DIMM - Camera - PCIe and USB2 on M.2 slot with A key for WLAN - SATA and USB2 (no SuperSpeed components) on M.2 slot with B key for WWAN - On board SDHCI connected to PCIe - USB3 ports - libgfxinit-based graphics init - NVRAM options for North and South bridges - Sound - ThinkPad EC - S3 - Linux 4.9 within Debian GNU/Linux stable, loaded from SeaBIOS.
Untested: - Touch screen, which is said to work under ubuntu but not debian.
Change-Id: Id59cdc5479aaf70809dd1ca613056263661455eb Signed-off-by: Bill XIE persmule@hardenedlinux.org --- M 3rdparty/libgfxinit M Documentation/mainboard/index.md M Documentation/mainboard/lenovo/Ivy_Bridge_series.md A Documentation/mainboard/lenovo/x230s.md A Documentation/mainboard/lenovo/x230s_bc_removed.jpg M src/mainboard/lenovo/x230/Kconfig M src/mainboard/lenovo/x230/Kconfig.name A src/mainboard/lenovo/x230/variants/x230s/board_info.txt A src/mainboard/lenovo/x230/variants/x230s/data.vbt A src/mainboard/lenovo/x230/variants/x230s/early_init.c A src/mainboard/lenovo/x230/variants/x230s/gma-mainboard.ads A src/mainboard/lenovo/x230/variants/x230s/gpio.c A src/mainboard/lenovo/x230/variants/x230s/hda_verb.c A src/mainboard/lenovo/x230/variants/x230s/overridetree.cb 14 files changed, 363 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/41390/20
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Angel Pons, Alexander Couzens, Patrick Rudolph, HAOUAS Elyes,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41390
to look at the new patch set (#21).
Change subject: mainboard/lenovo/x230: Add ThinkPad x230s as a variant ......................................................................
mainboard/lenovo/x230: Add ThinkPad x230s as a variant
The code is based on autoport and that for X230. Major differences are: - Only one DDR3 slot - HM77 PCH - M.2 socket instead of mini PCIe - No docking - No TPM
Tested: - CPU i5-3337U - 8GiB SO-DIMM - Camera - PCIe and USB2 on M.2 slot with A key for WLAN - SATA and USB2 (no SuperSpeed components) on M.2 slot with B key for WWAN - On board SDHCI connected to PCIe - USB3 ports - libgfxinit-based graphics init - NVRAM options for North and South bridges - Sound - ThinkPad EC - S3 - Linux 4.9 within Debian GNU/Linux stable, loaded from SeaBIOS.
Untested: - Touch screen, which is said to work under ubuntu but not debian.
Change-Id: Id59cdc5479aaf70809dd1ca613056263661455eb Signed-off-by: Bill XIE persmule@hardenedlinux.org --- M Documentation/mainboard/index.md M Documentation/mainboard/lenovo/Ivy_Bridge_series.md A Documentation/mainboard/lenovo/x230s.md A Documentation/mainboard/lenovo/x230s_bc_removed.jpg M src/mainboard/lenovo/x230/Kconfig M src/mainboard/lenovo/x230/Kconfig.name A src/mainboard/lenovo/x230/variants/x230s/board_info.txt A src/mainboard/lenovo/x230/variants/x230s/data.vbt A src/mainboard/lenovo/x230/variants/x230s/early_init.c A src/mainboard/lenovo/x230/variants/x230s/gma-mainboard.ads A src/mainboard/lenovo/x230/variants/x230s/gpio.c A src/mainboard/lenovo/x230/variants/x230s/hda_verb.c A src/mainboard/lenovo/x230/variants/x230s/overridetree.cb 13 files changed, 362 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/41390/21
Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41390 )
Change subject: mainboard/lenovo/x230: Add ThinkPad x230s as a variant ......................................................................
Patch Set 21:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41390/19/3rdparty/libgfxinit File 3rdparty/libgfxinit:
https://review.coreboot.org/c/coreboot/+/41390/19/3rdparty/libgfxinit@a1 PS19, Line 1: Subproject commit 8fc8e49a932c7a011429b333765c6b0ed09cd742
Related?
Unrelated. Removed.
Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41390 )
Change subject: mainboard/lenovo/x230: Add ThinkPad x230s as a variant ......................................................................
Patch Set 22:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41390/16/src/mainboard/lenovo/x230/... File src/mainboard/lenovo/x230/variants/x230s/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/41390/16/src/mainboard/lenovo/x230/... PS16, Line 21:
They may be added in CB:41505, but is 0x3 really necessary? since xhci port3 of X230s is not exposed […]
XHCI port3 of X230s is disabled (in its early_init.c). Is it necessary to mask it here via xhci_switchable_ports and superspeed_capable_ports? Doing so seems to make no real difference.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41390 )
Change subject: mainboard/lenovo/x230: Add ThinkPad x230s as a variant ......................................................................
Patch Set 22: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/41390/16/src/mainboard/lenovo/x230/... File src/mainboard/lenovo/x230/variants/x230s/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/41390/16/src/mainboard/lenovo/x230/... PS16, Line 21:
XHCI port3 of X230s is disabled (in its early_init.c). […]
I don't care, but it would be nice to find out why there are redundant settings
Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41390 )
Change subject: mainboard/lenovo/x230: Add ThinkPad x230s as a variant ......................................................................
Patch Set 24:
Could someone review this commit for more issues? It has hung here for half a month.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41390 )
Change subject: mainboard/lenovo/x230: Add ThinkPad x230s as a variant ......................................................................
Patch Set 24: Code-Review+1
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41390 )
Change subject: mainboard/lenovo/x230: Add ThinkPad x230s as a variant ......................................................................
Patch Set 24: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/41390/24/Documentation/mainboard/le... File Documentation/mainboard/lenovo/x230s.md:
https://review.coreboot.org/c/coreboot/+/41390/24/Documentation/mainboard/le... PS24, Line 11: Manual Lines are too long
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Angel Pons, Alexander Couzens, Patrick Rudolph, HAOUAS Elyes,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41390
to look at the new patch set (#25).
Change subject: mainboard/lenovo/x230: Add ThinkPad x230s as a variant ......................................................................
mainboard/lenovo/x230: Add ThinkPad x230s as a variant
The code is based on autoport and that for X230. Major differences are: - Only one DDR3 slot - HM77 PCH - M.2 socket instead of mini PCIe - No docking - No TPM
Tested: - CPU i5-3337U - 8GiB SO-DIMM - Camera - PCIe and USB2 on M.2 slot with A key for WLAN - SATA and USB2 (no SuperSpeed components) on M.2 slot with B key for WWAN - On board SDHCI connected to PCIe - USB3 ports - libgfxinit-based graphics init - NVRAM options for North and South bridges - Sound - ThinkPad EC - S3 - Linux 4.9 within Debian GNU/Linux stable, loaded from SeaBIOS.
Untested: - Touch screen, which is said to work under ubuntu but not debian.
Change-Id: Id59cdc5479aaf70809dd1ca613056263661455eb Signed-off-by: Bill XIE persmule@hardenedlinux.org --- M Documentation/mainboard/index.md M Documentation/mainboard/lenovo/Ivy_Bridge_series.md A Documentation/mainboard/lenovo/x230s.md A Documentation/mainboard/lenovo/x230s_bc_removed.jpg M src/mainboard/lenovo/x230/Kconfig M src/mainboard/lenovo/x230/Kconfig.name A src/mainboard/lenovo/x230/variants/x230s/board_info.txt A src/mainboard/lenovo/x230/variants/x230s/data.vbt A src/mainboard/lenovo/x230/variants/x230s/early_init.c A src/mainboard/lenovo/x230/variants/x230s/gma-mainboard.ads A src/mainboard/lenovo/x230/variants/x230s/gpio.c A src/mainboard/lenovo/x230/variants/x230s/hda_verb.c A src/mainboard/lenovo/x230/variants/x230s/overridetree.cb 13 files changed, 363 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/41390/25
Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41390 )
Change subject: mainboard/lenovo/x230: Add ThinkPad x230s as a variant ......................................................................
Patch Set 25:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41390/24/Documentation/mainboard/le... File Documentation/mainboard/lenovo/x230s.md:
https://review.coreboot.org/c/coreboot/+/41390/24/Documentation/mainboard/le... PS24, Line 11: Manual
Lines are too long
Done
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Angel Pons, Alexander Couzens, Patrick Rudolph, HAOUAS Elyes,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41390
to look at the new patch set (#26).
Change subject: mainboard/lenovo/x230: Add ThinkPad x230s as a variant ......................................................................
mainboard/lenovo/x230: Add ThinkPad x230s as a variant
The code is based on autoport and that for X230. Major differences are: - Only one DDR3 slot - HM77 PCH - M.2 socket instead of mini PCIe - No docking - No TPM
Tested: - CPU i5-3337U - 8GiB SO-DIMM - Camera - PCIe and USB2 on M.2 slot with A key for WLAN - SATA and USB2 (no SuperSpeed components) on M.2 slot with B key for WWAN - On board SDHCI connected to PCIe - USB3 ports - libgfxinit-based graphics init - NVRAM options for North and South bridges - Sound - ThinkPad EC - S3 - Linux 4.9 within Debian GNU/Linux stable, loaded from SeaBIOS.
Untested: - Touch screen, which is said to work under ubuntu but not debian.
Change-Id: Id59cdc5479aaf70809dd1ca613056263661455eb Signed-off-by: Bill XIE persmule@hardenedlinux.org --- M Documentation/mainboard/index.md M Documentation/mainboard/lenovo/Ivy_Bridge_series.md A Documentation/mainboard/lenovo/x230s.md A Documentation/mainboard/lenovo/x230s_bc_removed.jpg M src/mainboard/lenovo/x230/Kconfig M src/mainboard/lenovo/x230/Kconfig.name A src/mainboard/lenovo/x230/variants/x230s/board_info.txt A src/mainboard/lenovo/x230/variants/x230s/data.vbt A src/mainboard/lenovo/x230/variants/x230s/early_init.c A src/mainboard/lenovo/x230/variants/x230s/gma-mainboard.ads A src/mainboard/lenovo/x230/variants/x230s/gpio.c A src/mainboard/lenovo/x230/variants/x230s/hda_verb.c A src/mainboard/lenovo/x230/variants/x230s/overridetree.cb 13 files changed, 365 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/41390/26
Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41390 )
Change subject: mainboard/lenovo/x230: Add ThinkPad x230s as a variant ......................................................................
Patch Set 26:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41390/24/Documentation/mainboard/le... File Documentation/mainboard/lenovo/x230s.md:
https://review.coreboot.org/c/coreboot/+/41390/24/Documentation/mainboard/le... PS24, Line 11: Manual
Done
Is it okay to break the line in the middle of the hyperlink syntax of markdown?
Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41390 )
Change subject: mainboard/lenovo/x230: Add ThinkPad x230s as a variant ......................................................................
Patch Set 26:
Is this change okay now?
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41390 )
Change subject: mainboard/lenovo/x230: Add ThinkPad x230s as a variant ......................................................................
Patch Set 26:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41390/26/src/mainboard/lenovo/x230/... File src/mainboard/lenovo/x230/variants/x230s/early_init.c:
https://review.coreboot.org/c/coreboot/+/41390/26/src/mainboard/lenovo/x230/... PS26, Line 2: : #include <bootblock_common.h> : #include <northbridge/intel/sandybridge/sandybridge.h> : #include <northbridge/intel/sandybridge/raminit_native.h> : #include <southbridge/intel/bd82x6x/pch.h> please include only what you use
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Angel Pons, Alexander Couzens, Patrick Rudolph, HAOUAS Elyes,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41390
to look at the new patch set (#27).
Change subject: mainboard/lenovo/x230: Add ThinkPad x230s as a variant ......................................................................
mainboard/lenovo/x230: Add ThinkPad x230s as a variant
The code is based on autoport and that for X230. Major differences are: - Only one DDR3 slot - HM77 PCH - M.2 socket instead of mini PCIe - No docking - No TPM
Tested: - CPU i5-3337U - 8GiB SO-DIMM - Camera - PCIe and USB2 on M.2 slot with A key for WLAN - SATA and USB2 (no SuperSpeed components) on M.2 slot with B key for WWAN - On board SDHCI connected to PCIe - USB3 ports - libgfxinit-based graphics init - NVRAM options for North and South bridges - Sound - ThinkPad EC - S3 - Linux 4.9 within Debian GNU/Linux stable, loaded from SeaBIOS.
Untested: - Touch screen, which is said to work under ubuntu but not debian.
Change-Id: Id59cdc5479aaf70809dd1ca613056263661455eb Signed-off-by: Bill XIE persmule@hardenedlinux.org --- M Documentation/mainboard/index.md M Documentation/mainboard/lenovo/Ivy_Bridge_series.md A Documentation/mainboard/lenovo/x230s.md A Documentation/mainboard/lenovo/x230s_bc_removed.jpg M src/mainboard/lenovo/x230/Kconfig M src/mainboard/lenovo/x230/Kconfig.name A src/mainboard/lenovo/x230/variants/x230s/board_info.txt A src/mainboard/lenovo/x230/variants/x230s/data.vbt A src/mainboard/lenovo/x230/variants/x230s/early_init.c A src/mainboard/lenovo/x230/variants/x230s/gma-mainboard.ads A src/mainboard/lenovo/x230/variants/x230s/gpio.c A src/mainboard/lenovo/x230/variants/x230s/hda_verb.c A src/mainboard/lenovo/x230/variants/x230s/overridetree.cb 13 files changed, 363 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/41390/27
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41390 )
Change subject: mainboard/lenovo/x230: Add ThinkPad x230s as a variant ......................................................................
Patch Set 27:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41390/26/src/mainboard/lenovo/x230/... File src/mainboard/lenovo/x230/variants/x230s/early_init.c:
https://review.coreboot.org/c/coreboot/+/41390/26/src/mainboard/lenovo/x230/... PS26, Line 2: : #include <bootblock_common.h> : #include <northbridge/intel/sandybridge/sandybridge.h> : #include <northbridge/intel/sandybridge/raminit_native.h> : #include <southbridge/intel/bd82x6x/pch.h>
please include only what you use
Done
Thank you
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41390 )
Change subject: mainboard/lenovo/x230: Add ThinkPad x230s as a variant ......................................................................
Patch Set 27: Code-Review+1
Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41390 )
Change subject: mainboard/lenovo/x230: Add ThinkPad x230s as a variant ......................................................................
Patch Set 28:
Is there any flaw that prevents this commit from being Code-Review +2 now?
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41390 )
Change subject: mainboard/lenovo/x230: Add ThinkPad x230s as a variant ......................................................................
Patch Set 28: Code-Review+1
Patch Set 28:
Is there any flaw that prevents this commit from being Code-Review +2 now?
There are some unresolved comments which should be addressed or marked as resolved.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41390 )
Change subject: mainboard/lenovo/x230: Add ThinkPad x230s as a variant ......................................................................
Patch Set 28:
Patch Set 28: Code-Review+1
Patch Set 28:
Is there any flaw that prevents this commit from being Code-Review +2 now?
There are some unresolved comments which should be addressed or marked as resolved.
To expand on this, until all comments are marked resolved, the patch can't be merged even if it has +2. If you look in the code review section, you'll see the "All-Comments resolved" section marked "No votes."
To see what still needs to be addressed, click on one of the patchset selectors at the top of the files section and look for anything that says 'X comments, Y unresolved'.
Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41390 )
Change subject: mainboard/lenovo/x230: Add ThinkPad x230s as a variant ......................................................................
Patch Set 28:
(4 comments)
https://review.coreboot.org/c/coreboot/+/41390/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41390/5//COMMIT_MSG@7 PS5, Line 7: m
mb/lenovo/x230/var/x230s: Remove unnecessary code and comments
Done
https://review.coreboot.org/c/coreboot/+/41390/5//COMMIT_MSG@13 PS5, Line 13: will remove
present tense: removes
Done
https://review.coreboot.org/c/coreboot/+/41390/16/src/mainboard/lenovo/x230/... File src/mainboard/lenovo/x230/Kconfig:
https://review.coreboot.org/c/coreboot/+/41390/16/src/mainboard/lenovo/x230/... PS16, Line 22: !BOARD_LENOVO_X230S
That there are mixed `!BOARD_LENOVO_X230S` and `BOARD_LENOVO_X230 || BOARD_LENOVO_X230T` is odd.
Done
https://review.coreboot.org/c/coreboot/+/41390/11/src/mainboard/lenovo/x230/... File src/mainboard/lenovo/x230/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/41390/11/src/mainboard/lenovo/x230/... PS11, Line 65: register "superspeed_capable_ports" = "0xf"
please move superspeed_capable_ports into a seperate commit.
Done, as CB:41510.
Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41390 )
Change subject: mainboard/lenovo/x230: Add ThinkPad x230s as a variant ......................................................................
Patch Set 28:
Patch Set 28:
Patch Set 28: Code-Review+1
Patch Set 28:
Is there any flaw that prevents this commit from being Code-Review +2 now?
There are some unresolved comments which should be addressed or marked as resolved.
To expand on this, until all comments are marked resolved, the patch can't be merged even if it has +2. If you look in the code review section, you'll see the "All-Comments resolved" section marked "No votes."
To see what still needs to be addressed, click on one of the patchset selectors at the top of the files section and look for anything that says 'X comments, Y unresolved'.
Thanks. I have missed the point of "All-Comments resolved" until now.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41390 )
Change subject: mainboard/lenovo/x230: Add ThinkPad x230s as a variant ......................................................................
Patch Set 29: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41390 )
Change subject: mainboard/lenovo/x230: Add ThinkPad x230s as a variant ......................................................................
mainboard/lenovo/x230: Add ThinkPad x230s as a variant
The code is based on autoport and that for X230. Major differences are: - Only one DDR3 slot - HM77 PCH - M.2 socket instead of mini PCIe - No docking - No TPM
Tested: - CPU i5-3337U - 8GiB SO-DIMM - Camera - PCIe and USB2 on M.2 slot with A key for WLAN - SATA and USB2 (no SuperSpeed components) on M.2 slot with B key for WWAN - On board SDHCI connected to PCIe - USB3 ports - libgfxinit-based graphics init - NVRAM options for North and South bridges - Sound - ThinkPad EC - S3 - Linux 4.9 within Debian GNU/Linux stable, loaded from SeaBIOS.
Untested: - Touch screen, which is said to work under ubuntu but not debian.
Change-Id: Id59cdc5479aaf70809dd1ca613056263661455eb Signed-off-by: Bill XIE persmule@hardenedlinux.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/41390 Reviewed-by: Patrick Georgi pgeorgi@google.com Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M Documentation/mainboard/index.md M Documentation/mainboard/lenovo/Ivy_Bridge_series.md A Documentation/mainboard/lenovo/x230s.md A Documentation/mainboard/lenovo/x230s_bc_removed.jpg M src/mainboard/lenovo/x230/Kconfig M src/mainboard/lenovo/x230/Kconfig.name A src/mainboard/lenovo/x230/variants/x230s/board_info.txt A src/mainboard/lenovo/x230/variants/x230s/data.vbt A src/mainboard/lenovo/x230/variants/x230s/early_init.c A src/mainboard/lenovo/x230/variants/x230s/gma-mainboard.ads A src/mainboard/lenovo/x230/variants/x230s/gpio.c A src/mainboard/lenovo/x230/variants/x230s/hda_verb.c A src/mainboard/lenovo/x230/variants/x230s/overridetree.cb 13 files changed, 363 insertions(+), 7 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved HAOUAS Elyes: Looks good to me, but someone else must approve Angel Pons: Looks good to me, but someone else must approve
diff --git a/Documentation/mainboard/index.md b/Documentation/mainboard/index.md index c5503e2..c229b06 100644 --- a/Documentation/mainboard/index.md +++ b/Documentation/mainboard/index.md @@ -102,6 +102,7 @@ - [W530](lenovo/w530.md) - [T430 / T530 / X230 / W530 common](lenovo/Ivy_Bridge_series.md) - [T431s](lenovo/t431s.md) +- [X230s](lenovo/x230s.md) - [Internal flashing](lenovo/ivb_internal_flashing.md)
### Haswell series diff --git a/Documentation/mainboard/lenovo/Ivy_Bridge_series.md b/Documentation/mainboard/lenovo/Ivy_Bridge_series.md index f4f0eff..5f15166 100644 --- a/Documentation/mainboard/lenovo/Ivy_Bridge_series.md +++ b/Documentation/mainboard/lenovo/Ivy_Bridge_series.md @@ -1,6 +1,6 @@ # Lenovo Ivy Bridge series
-This information is valid for all supported models, except T430s and T431s. +This information is valid for all supported models, except T430s, [T431s](t431s.md) and [X230s](x230s.md).
## Flashing coreboot ```eval_rst diff --git a/Documentation/mainboard/lenovo/x230s.md b/Documentation/mainboard/lenovo/x230s.md new file mode 100644 index 0000000..845410e --- /dev/null +++ b/Documentation/mainboard/lenovo/x230s.md @@ -0,0 +1,19 @@ +# ThinkPad Lenovo X230s + +## Disassembly Instructions + +You must remove the following parts to access the SPI flash chip: + + + +* Base cover + +The [Hardware Maintenance Manual](https://download.lenovo.com/ibmdl/pub/pc/pccbbs/ +mobiles_pdf/x230s_hmm_en_0c10860_01.pdf) could be used as a guidance of disassembly. + +The SPI flash chip (W25Q128.V in the form of SOIC-8 for the author's X230s, but varying is possible) +is located at the circled place. + +Unlike [most Ivy Bridge ThinkPads](Ivy_Bridge_series.md), X230s has a single 16MiB SPI flash chip. + +The general [flashing tutorial](../../flash_tutorial/index.md) has more details. diff --git a/Documentation/mainboard/lenovo/x230s_bc_removed.jpg b/Documentation/mainboard/lenovo/x230s_bc_removed.jpg new file mode 100644 index 0000000..1735e81 --- /dev/null +++ b/Documentation/mainboard/lenovo/x230s_bc_removed.jpg Binary files differ diff --git a/src/mainboard/lenovo/x230/Kconfig b/src/mainboard/lenovo/x230/Kconfig index 8e5b857..39238f5 100644 --- a/src/mainboard/lenovo/x230/Kconfig +++ b/src/mainboard/lenovo/x230/Kconfig @@ -1,4 +1,4 @@ -if BOARD_LENOVO_X230 || BOARD_LENOVO_X230T +if BOARD_LENOVO_X230 || BOARD_LENOVO_X230T || BOARD_LENOVO_X230S
config BOARD_SPECIFIC_OPTIONS def_bool y @@ -9,18 +9,20 @@ select EC_LENOVO_PMH7 select EC_LENOVO_H8 select H8_HAS_BAT_TRESHOLDS_IMPL + select H8_HAS_PRIMARY_FN_KEYS if BOARD_LENOVO_X230S select NO_UART_ON_SUPERIO - select BOARD_ROMSIZE_KB_12288 + select BOARD_ROMSIZE_KB_12288 if BOARD_LENOVO_X230 || BOARD_LENOVO_X230T + select BOARD_ROMSIZE_KB_16384 if BOARD_LENOVO_X230S select HAVE_ACPI_TABLES select HAVE_OPTION_TABLE select HAVE_CMOS_DEFAULT select HAVE_ACPI_RESUME select INTEL_INT15 select DRIVERS_RICOH_RCE822 - select MAINBOARD_HAS_LPC_TPM - select MAINBOARD_HAS_TPM1 + select MAINBOARD_HAS_LPC_TPM if BOARD_LENOVO_X230 || BOARD_LENOVO_X230T + select MAINBOARD_HAS_TPM1 if BOARD_LENOVO_X230 || BOARD_LENOVO_X230T select MAINBOARD_HAS_LIBGFXINIT - select GFX_GMA_PANEL_1_ON_LVDS + select GFX_GMA_PANEL_1_ON_LVDS if BOARD_LENOVO_X230 || BOARD_LENOVO_X230T select INTEL_GMA_HAVE_VBT select MAINBOARD_USES_IFD_GBE_REGION
@@ -53,11 +55,13 @@ config VARIANT_DIR string default "x230" if BOARD_LENOVO_X230 || BOARD_LENOVO_X230T + default "x230s" if BOARD_LENOVO_X230S
config MAINBOARD_PART_NUMBER string default "ThinkPad X230" if BOARD_LENOVO_X230 default "ThinkPad X230t" if BOARD_LENOVO_X230T + default "ThinkPad X230s" if BOARD_LENOVO_X230S
config OVERRIDE_DEVICETREE string @@ -88,4 +92,4 @@ config THINKPADEC_HKEY_EISAID default "LEN0068"
-endif # BOARD_LENOVO_X230 || BOARD_LENOVO_X230T +endif # BOARD_LENOVO_X230 || BOARD_LENOVO_X230T || BOARD_LENOVO_X230S diff --git a/src/mainboard/lenovo/x230/Kconfig.name b/src/mainboard/lenovo/x230/Kconfig.name index 10fdc2e..1a01436 100644 --- a/src/mainboard/lenovo/x230/Kconfig.name +++ b/src/mainboard/lenovo/x230/Kconfig.name @@ -3,3 +3,6 @@
config BOARD_LENOVO_X230T bool "ThinkPad X230t" + +config BOARD_LENOVO_X230S + bool "ThinkPad X230s" diff --git a/src/mainboard/lenovo/x230/variants/x230s/board_info.txt b/src/mainboard/lenovo/x230/variants/x230s/board_info.txt new file mode 100644 index 0000000..67b2294 --- /dev/null +++ b/src/mainboard/lenovo/x230/variants/x230s/board_info.txt @@ -0,0 +1,7 @@ +Category: laptop +Board name: ThinkPad X230s +ROM package: SOIC-8 +ROM protocol: SPI +ROM socketed: n +Flashrom support: n +Release year: 2013 diff --git a/src/mainboard/lenovo/x230/variants/x230s/data.vbt b/src/mainboard/lenovo/x230/variants/x230s/data.vbt new file mode 100644 index 0000000..42b0394 --- /dev/null +++ b/src/mainboard/lenovo/x230/variants/x230s/data.vbt Binary files differ diff --git a/src/mainboard/lenovo/x230/variants/x230s/early_init.c b/src/mainboard/lenovo/x230/variants/x230s/early_init.c new file mode 100644 index 0000000..362e7fa --- /dev/null +++ b/src/mainboard/lenovo/x230/variants/x230s/early_init.c @@ -0,0 +1,26 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include <northbridge/intel/sandybridge/raminit_native.h> +#include <southbridge/intel/bd82x6x/pch.h> + +const struct southbridge_usb_port mainboard_usb_ports[] = { + {1, 3, 0}, /* SSP1: Right */ + {1, 3, 1}, /* SSP2: Left, EHCI Debug */ + {0, 1, 3}, /* SSP3 */ + {1, 3, -1}, /* B0P4: WWAN USB */ + {0, 1, 2}, /* B0P5 */ + {0, 1, -1}, /* B0P6 */ + {0, 1, -1}, /* B0P7 */ + {0, 1, -1}, /* B0P8 */ + {0, 1, -1}, /* B1P1 */ + {0, 1, 5}, /* B1P2 */ + {1, 1, -1}, /* B1P3: Fingerprint Reader */ + {0, 1, -1}, /* B1P4 */ + {1, 3, -1}, /* B1P5: WLAN USB */ + {1, 1, -1}, /* B1P6: Camera */ +}; + +void mainboard_get_spd(spd_raw_data *spd, bool id_only) +{ + read_spd(&spd[0], 0x50, id_only); +} diff --git a/src/mainboard/lenovo/x230/variants/x230s/gma-mainboard.ads b/src/mainboard/lenovo/x230/variants/x230s/gma-mainboard.ads new file mode 100644 index 0000000..fe9efd5 --- /dev/null +++ b/src/mainboard/lenovo/x230/variants/x230s/gma-mainboard.ads @@ -0,0 +1,18 @@ +-- SPDX-License-Identifier: GPL-2.0-or-later + +with HW.GFX.GMA; +with HW.GFX.GMA.Display_Probing; + +use HW.GFX.GMA; +use HW.GFX.GMA.Display_Probing; + +private package GMA.Mainboard is + + ports : constant Port_List := + (DP1, + HDMI1, + Analog, + eDP, + others => Disabled); + +end GMA.Mainboard; diff --git a/src/mainboard/lenovo/x230/variants/x230s/gpio.c b/src/mainboard/lenovo/x230/variants/x230s/gpio.c new file mode 100644 index 0000000..a216c6b --- /dev/null +++ b/src/mainboard/lenovo/x230/variants/x230s/gpio.c @@ -0,0 +1,212 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include <southbridge/intel/common/gpio.h> + +static const struct pch_gpio_set1 pch_gpio_set1_mode = { + .gpio0 = GPIO_MODE_GPIO, + .gpio1 = GPIO_MODE_GPIO, + .gpio2 = GPIO_MODE_GPIO, + .gpio3 = GPIO_MODE_GPIO, + .gpio4 = GPIO_MODE_GPIO, + .gpio5 = GPIO_MODE_GPIO, + .gpio6 = GPIO_MODE_GPIO, + .gpio7 = GPIO_MODE_GPIO, + .gpio8 = GPIO_MODE_GPIO, + .gpio9 = GPIO_MODE_NATIVE, + .gpio10 = GPIO_MODE_GPIO, + .gpio11 = GPIO_MODE_NATIVE, + .gpio12 = GPIO_MODE_NATIVE, + .gpio13 = GPIO_MODE_GPIO, + .gpio14 = GPIO_MODE_NATIVE, + .gpio15 = GPIO_MODE_GPIO, + .gpio16 = GPIO_MODE_GPIO, + .gpio17 = GPIO_MODE_GPIO, + .gpio18 = GPIO_MODE_NATIVE, + .gpio19 = GPIO_MODE_GPIO, + .gpio20 = GPIO_MODE_NATIVE, + .gpio21 = GPIO_MODE_GPIO, + .gpio22 = GPIO_MODE_GPIO, + .gpio23 = GPIO_MODE_NATIVE, + .gpio24 = GPIO_MODE_GPIO, + .gpio25 = GPIO_MODE_NATIVE, + .gpio26 = GPIO_MODE_GPIO, + .gpio27 = GPIO_MODE_GPIO, + .gpio28 = GPIO_MODE_GPIO, + .gpio29 = GPIO_MODE_GPIO, + .gpio30 = GPIO_MODE_NATIVE, + .gpio31 = GPIO_MODE_NATIVE, +}; + +static const struct pch_gpio_set1 pch_gpio_set1_direction = { + .gpio0 = GPIO_DIR_INPUT, + .gpio1 = GPIO_DIR_INPUT, + .gpio2 = GPIO_DIR_INPUT, + .gpio3 = GPIO_DIR_INPUT, + .gpio4 = GPIO_DIR_INPUT, + .gpio5 = GPIO_DIR_INPUT, + .gpio6 = GPIO_DIR_INPUT, + .gpio7 = GPIO_DIR_INPUT, + .gpio8 = GPIO_DIR_OUTPUT, + .gpio10 = GPIO_DIR_OUTPUT, + .gpio13 = GPIO_DIR_INPUT, + .gpio15 = GPIO_DIR_OUTPUT, + .gpio16 = GPIO_DIR_INPUT, + .gpio17 = GPIO_DIR_INPUT, + .gpio19 = GPIO_DIR_INPUT, + .gpio21 = GPIO_DIR_INPUT, + .gpio22 = GPIO_DIR_OUTPUT, + .gpio24 = GPIO_DIR_OUTPUT, + .gpio26 = GPIO_DIR_INPUT, + .gpio27 = GPIO_DIR_INPUT, + .gpio28 = GPIO_DIR_OUTPUT, + .gpio29 = GPIO_DIR_OUTPUT, +}; + +static const struct pch_gpio_set1 pch_gpio_set1_level = { + .gpio8 = GPIO_LEVEL_LOW, + .gpio10 = GPIO_LEVEL_HIGH, + .gpio15 = GPIO_LEVEL_LOW, + .gpio22 = GPIO_LEVEL_HIGH, + .gpio24 = GPIO_LEVEL_LOW, + .gpio28 = GPIO_LEVEL_LOW, + .gpio29 = GPIO_LEVEL_HIGH, +}; + +static const struct pch_gpio_set1 pch_gpio_set1_reset = { + .gpio24 = GPIO_RESET_RSMRST, +}; + +static const struct pch_gpio_set1 pch_gpio_set1_invert = { + .gpio1 = GPIO_INVERT, + .gpio6 = GPIO_INVERT, + .gpio13 = GPIO_INVERT, +}; + +static const struct pch_gpio_set1 pch_gpio_set1_blink = { +}; + +static const struct pch_gpio_set2 pch_gpio_set2_mode = { + .gpio32 = GPIO_MODE_NATIVE, + .gpio33 = GPIO_MODE_GPIO, + .gpio34 = GPIO_MODE_GPIO, + .gpio35 = GPIO_MODE_GPIO, + .gpio36 = GPIO_MODE_GPIO, + .gpio37 = GPIO_MODE_GPIO, + .gpio38 = GPIO_MODE_GPIO, + .gpio39 = GPIO_MODE_GPIO, + .gpio40 = GPIO_MODE_NATIVE, + .gpio41 = GPIO_MODE_NATIVE, + .gpio42 = GPIO_MODE_NATIVE, + .gpio43 = GPIO_MODE_GPIO, + .gpio44 = GPIO_MODE_GPIO, + .gpio45 = GPIO_MODE_GPIO, + .gpio46 = GPIO_MODE_NATIVE, + .gpio47 = GPIO_MODE_GPIO, + .gpio48 = GPIO_MODE_GPIO, + .gpio49 = GPIO_MODE_GPIO, + .gpio50 = GPIO_MODE_GPIO, + .gpio51 = GPIO_MODE_GPIO, + .gpio52 = GPIO_MODE_GPIO, + .gpio53 = GPIO_MODE_GPIO, + .gpio54 = GPIO_MODE_GPIO, + .gpio55 = GPIO_MODE_GPIO, + .gpio56 = GPIO_MODE_GPIO, + .gpio57 = GPIO_MODE_GPIO, + .gpio58 = GPIO_MODE_NATIVE, + .gpio59 = GPIO_MODE_NATIVE, + .gpio60 = GPIO_MODE_NATIVE, + .gpio61 = GPIO_MODE_NATIVE, + .gpio62 = GPIO_MODE_NATIVE, + .gpio63 = GPIO_MODE_NATIVE, +}; + +static const struct pch_gpio_set2 pch_gpio_set2_direction = { + .gpio33 = GPIO_DIR_OUTPUT, + .gpio34 = GPIO_DIR_INPUT, + .gpio35 = GPIO_DIR_INPUT, + .gpio36 = GPIO_DIR_INPUT, + .gpio37 = GPIO_DIR_INPUT, + .gpio38 = GPIO_DIR_INPUT, + .gpio39 = GPIO_DIR_INPUT, + .gpio43 = GPIO_DIR_OUTPUT, + .gpio44 = GPIO_DIR_INPUT, + .gpio45 = GPIO_DIR_INPUT, + .gpio47 = GPIO_DIR_INPUT, + .gpio48 = GPIO_DIR_INPUT, + .gpio49 = GPIO_DIR_INPUT, + .gpio50 = GPIO_DIR_INPUT, + .gpio51 = GPIO_DIR_OUTPUT, + .gpio52 = GPIO_DIR_OUTPUT, + .gpio53 = GPIO_DIR_OUTPUT, + .gpio54 = GPIO_DIR_INPUT, + .gpio55 = GPIO_DIR_OUTPUT, + .gpio56 = GPIO_DIR_INPUT, + .gpio57 = GPIO_DIR_INPUT, +}; + +static const struct pch_gpio_set2 pch_gpio_set2_level = { + .gpio33 = GPIO_LEVEL_HIGH, + .gpio43 = GPIO_LEVEL_HIGH, + .gpio51 = GPIO_LEVEL_HIGH, + .gpio52 = GPIO_LEVEL_HIGH, + .gpio53 = GPIO_LEVEL_HIGH, + .gpio55 = GPIO_LEVEL_HIGH, +}; + +static const struct pch_gpio_set2 pch_gpio_set2_reset = { +}; + +static const struct pch_gpio_set3 pch_gpio_set3_mode = { + .gpio64 = GPIO_MODE_GPIO, + .gpio65 = GPIO_MODE_GPIO, + .gpio66 = GPIO_MODE_GPIO, + .gpio67 = GPIO_MODE_GPIO, + .gpio68 = GPIO_MODE_GPIO, + .gpio69 = GPIO_MODE_GPIO, + .gpio70 = GPIO_MODE_GPIO, + .gpio71 = GPIO_MODE_GPIO, + .gpio72 = GPIO_MODE_NATIVE, + .gpio73 = GPIO_MODE_NATIVE, + .gpio74 = GPIO_MODE_NATIVE, + .gpio75 = GPIO_MODE_NATIVE, +}; + +static const struct pch_gpio_set3 pch_gpio_set3_direction = { + .gpio64 = GPIO_DIR_INPUT, + .gpio65 = GPIO_DIR_INPUT, + .gpio66 = GPIO_DIR_INPUT, + .gpio67 = GPIO_DIR_INPUT, + .gpio68 = GPIO_DIR_INPUT, + .gpio69 = GPIO_DIR_INPUT, + .gpio70 = GPIO_DIR_INPUT, + .gpio71 = GPIO_DIR_INPUT, +}; + +static const struct pch_gpio_set3 pch_gpio_set3_level = { +}; + +static const struct pch_gpio_set3 pch_gpio_set3_reset = { +}; + +const struct pch_gpio_map mainboard_gpio_map = { + .set1 = { + .mode = &pch_gpio_set1_mode, + .direction = &pch_gpio_set1_direction, + .level = &pch_gpio_set1_level, + .blink = &pch_gpio_set1_blink, + .invert = &pch_gpio_set1_invert, + .reset = &pch_gpio_set1_reset, + }, + .set2 = { + .mode = &pch_gpio_set2_mode, + .direction = &pch_gpio_set2_direction, + .level = &pch_gpio_set2_level, + .reset = &pch_gpio_set2_reset, + }, + .set3 = { + .mode = &pch_gpio_set3_mode, + .direction = &pch_gpio_set3_direction, + .level = &pch_gpio_set3_level, + .reset = &pch_gpio_set3_reset, + }, +}; diff --git a/src/mainboard/lenovo/x230/variants/x230s/hda_verb.c b/src/mainboard/lenovo/x230/variants/x230s/hda_verb.c new file mode 100644 index 0000000..7791904 --- /dev/null +++ b/src/mainboard/lenovo/x230/variants/x230s/hda_verb.c @@ -0,0 +1,33 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include <device/azalia_device.h> + +const u32 cim_verb_data[] = { + 0x10ec0269, /* Codec Vendor / Device ID: Realtek */ + 0x17aa2209, /* Subsystem ID */ + 11, /* Number of 4 dword sets */ + AZALIA_SUBVENDOR(0, 0x17aa2209), + AZALIA_PIN_CFG(0, 0x12, 0x90a60140), + AZALIA_PIN_CFG(0, 0x14, 0x90170110), + AZALIA_PIN_CFG(0, 0x15, 0x03211020), + AZALIA_PIN_CFG(0, 0x17, 0x40008000), + AZALIA_PIN_CFG(0, 0x18, 0x03a11030), + AZALIA_PIN_CFG(0, 0x19, 0x411111f0), + AZALIA_PIN_CFG(0, 0x1a, 0x411111f0), + AZALIA_PIN_CFG(0, 0x1b, 0x411111f0), + AZALIA_PIN_CFG(0, 0x1d, 0x40f38205), + AZALIA_PIN_CFG(0, 0x1e, 0x411111f0), + + 0x80862806, /* Codec Vendor / Device ID: Intel */ + 0x80860101, /* Subsystem ID */ + 4, /* Number of 4 dword sets */ + AZALIA_SUBVENDOR(3, 0x80860101), + AZALIA_PIN_CFG(3, 0x05, 0x18560010), + AZALIA_PIN_CFG(3, 0x06, 0x58560020), + AZALIA_PIN_CFG(3, 0x07, 0x58560030), + +}; + +const u32 pc_beep_verbs[0] = {}; + +AZALIA_ARRAY_SIZES; diff --git a/src/mainboard/lenovo/x230/variants/x230s/overridetree.cb b/src/mainboard/lenovo/x230/variants/x230s/overridetree.cb new file mode 100644 index 0000000..6d37aab --- /dev/null +++ b/src/mainboard/lenovo/x230/variants/x230s/overridetree.cb @@ -0,0 +1,33 @@ +chip northbridge/intel/sandybridge + # Enable DisplayPort Hotplug with 2ms pulse + register "gpu_dp_b_hotplug" = "4" + register "gpu_dp_c_hotplug" = "4" + register "gpu_dp_d_hotplug" = "4" + + # Enable Panel as eDP and configure power delays + register "gpu_panel_port_select" = "1" # eDP + register "gpu_panel_power_backlight_off_delay" = "1" # 0.1ms + register "gpu_panel_power_backlight_on_delay" = "1" # 0.1ms + register "gpu_panel_power_down_delay" = "500" # 50ms + register "gpu_panel_power_up_delay" = "2000" # 200ms + + device domain 0 on + subsystemid 0x17aa 0x2209 inherit + chip southbridge/intel/bd82x6x # Intel Series 7 Panther Point PCH + # X230s does not support docking + # Enable SATA ports 0 (HDD bay) & 1 (WWAN M.2 SATA) + register "sata_port_map" = "0x3" + + device pci 1f.0 on # LPC bridge + chip ec/lenovo/h8 + register "config1" = "0x05" + register "config3" = "0xc4" + register "event5_enable" = "0x3c" + register "evente_enable" = "0x1d" + # X230s only has BT on wlan card + register "has_bdc_detection" = "0" + end + end # LPC Controller + end + end +end
-
Alexander Couzens (Code Review) -
Angel Pons (Code Review)
-
Bill XIE (Code Review)
-
HAOUAS Elyes (Code Review)
-
Martin Roth (Code Review)
-
Patrick Georgi (Code Review)
-
Patrick Rudolph (Code Review)
-
Paul Menzel (Code Review)