Attention is currently required from: Nico Huber, Martin L Roth, Subrata Banik, Patrick Rudolph, Benjamin Doron, Julius Werner, Arthur Heymans.
Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67735 )
Change subject: cpu/x86/smm_stub.S: Add a retpoline around the main C handler
......................................................................
Patch Set 2:
(1 comment)
File src/cpu/x86/smm/smm_stub.S:
https://review.coreboot.org/c/coreboot/+/67735/comment/933a08ec_f01a5bb6
PS2, Line 256: jmp 2f
would it make sense to do:
call call_c_handler
here and leave the 1: and 2: label code out? So it would basically result in this:
```
call call_c_handler
trap:
pause
lfence
jmp trap
call_c_handler:
movq %rax, (%rsp)
ret
int3
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/67735
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I93be3cd6a8c5f1ec29b3bc43195823ac49ec61c5
Gerrit-Change-Number: 67735
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Jan Samek
jan.samek@siemens.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Wed, 03 May 2023 23:11:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment