Attention is currently required from: Julius Werner, Yu-Ping Wu. Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56444 )
Change subject: tests/Makefile.inc: Correct dependency file suffix ......................................................................
Patch Set 1:
(1 comment)
File tests/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/56444/comment/dd8f6293_be38561e PS1, Line 145: DEPENDENCIES += $(addsuffix .d,$(all-test-objs))
I'm not sure if we should correct the path here, or fix the recipe like this: […]
We should correct the path here, and in the recipe. ``` $(OBJCOPY) $$@.orig $$(OBJCOPY_FLAGS) $$@ mv -f $$@.orig.d $$@.d ``` The recipe should produce `file.o` and `file.o.d`. Just moving the dependency file should suffice.
-
Jakub Czapiga (Code Review)