Attention is currently required from: Kevin Chiu, Bhanu Prakash Maiya, Eric Peers, Karthik Ramasubramanian.
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59051 )
Change subject: mb/google/guybrush/var/nipperkin: Update SPKR GPIO configuration
......................................................................
Patch Set 3:
(3 comments)
File src/mainboard/google/guybrush/variants/nipperkin/gpio.c:
https://review.coreboot.org/c/coreboot/+/59051/comment/bf19d5b6_ed865fcc
PS3, Line 39: /* EN_SPKR */
Should disconnect baseboard EN_SPKR / GPIO_31
https://review.coreboot.org/c/coreboot/+/59051/comment/4c683ad9_b6846e29
PS3, Line 40: PAD_GPO(GPIO_70, HIGH),
Should sdmode_gpio in nipperkin/overridetree.cb be GPIO_70?
https://review.coreboot.org/c/coreboot/+/59051/comment/eb74a8b6_60171b0f
PS3, Line 61: PAD_NC(GPIO_18),
GPIO_70 is disconnected in baseboard pcie_gpio_table. Should connect here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59051
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3d82292b116f53d85d9518364ffd2169bd915a7e
Gerrit-Change-Number: 59051
Gerrit-PatchSet: 3
Gerrit-Owner: Kevin Chiu
kevin.chiu.17802@gmail.com
Gerrit-Reviewer: Bhanu Prakash Maiya
bhanumaiya@google.com
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Kevin Chiu
kevin.chiu.17802@gmail.com
Gerrit-Attention: Bhanu Prakash Maiya
bhanumaiya@google.com
Gerrit-Attention: Eric Peers
epeers@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Wed, 10 Nov 2021 16:06:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment