Attention is currently required from: Ashish Kumar Mishra, Paul Menzel, Sowmya Aralguppe, Subrata Banik, Wonkyu Kim.
Jérémy Compostella has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/83946?usp=email )
Change subject: soc/intel/common/block/cpu: Add Kconfig for effective way size for NEM+ ......................................................................
Patch Set 11:
(9 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83946/comment/a6e2f38b_7f04c2d2?usp... : PS10, Line 7: NEM+
This (with +) is not mentioned in the commit message body.
Done
https://review.coreboot.org/c/coreboot/+/83946/comment/5424a5af_f07cad29?usp... : PS10, Line 7: Use the effective way size for NEM+
Maybe: […]
Done
https://review.coreboot.org/c/coreboot/+/83946/comment/840e6fd6_d820eb54?usp... : PS10, Line 10: the : way size which should be considered for No-Eviction Mode (NEM) : purposes
Add a comma at the end?
Done
https://review.coreboot.org/c/coreboot/+/83946/comment/ebc2f719_b0c565c0?usp... : PS10, Line 21: has been
is
Done
https://review.coreboot.org/c/coreboot/+/83946/comment/62e15d90_4cbbdb20?usp... : PS10, Line 25: TEST=Verified on PTL Intel reference platform
How? List the way size before and after?
Done
File src/soc/intel/common/block/cpu/Kconfig:
https://review.coreboot.org/c/coreboot/+/83946/comment/2a987603_e7c775a6?usp... : PS10, Line 84: INTEL_CAR_ENEM_USE_EFFECTIVE_WAY_SIZE
I would misinterpret it, that platforms not selecting this use an *in*effective way size, but from y […]
Your interpretation is correct, I modified the commit message to avoid this confusion.
https://review.coreboot.org/c/coreboot/+/83946/comment/fda9307f_41065be4?usp... : PS10, Line 87: On some platforms
List the known ones?
Done
https://review.coreboot.org/c/coreboot/+/83946/comment/492603cd_fddd2662?usp... : PS10, Line 87: the way size : which should be considered for eNEM purposes
Add a comma at the end?
Done
File src/soc/intel/common/block/cpu/car/cache_as_ram.S:
https://review.coreboot.org/c/coreboot/+/83946/comment/2a1fdb96_16a724ac?usp... : PS4, Line 498: INTEL_CAR_ENEM_USE_EFFECTIVE_WAY_SIZE
why would we consider the # of active cores ? This is just about complying with the ADL EDS or the M […]
Done