Attention is currently required from: Star Labs. Andy Pont has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52797 )
Change subject: ec: Add Star Labs ITE 8987E support ......................................................................
Patch Set 8:
(3 comments)
Patchset:
PS8: Found a couple of issues that were missed in the code tidy up.
File src/ec/starlabs/it8987/acpi/ec.asl:
https://review.coreboot.org/c/coreboot/+/52797/comment/eb16a6e9_c63d2dfb PS8, Line 97: Store (0x03, _SB.PCI0.GFX0.CLID) This doesn't exist in coreboot, hence being commented out, so we should probably take it out.
File src/ec/starlabs/it8987/chip.h:
https://review.coreboot.org/c/coreboot/+/52797/comment/b8965378_e5fdbf0e PS8, Line 10: _EC_ITE_IT8987_CHIP_H Oops, comment didn't get corrected when the include guard got changed.
-
Andy Pont (Code Review)