EricR Lai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48115 )
Change subject: mb/google/brya:Add EC smihandler ......................................................................
mb/google/brya:Add EC smihandler
Add implementation of EC smihandler
BUG=b:174266035 TEST=Build Test
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I211f5755ff44514ab7ab4083f684ddd88c23fe48 --- M src/mainboard/google/brya/Makefile.inc A src/mainboard/google/brya/smihandler.c 2 files changed, 38 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/48115/1
diff --git a/src/mainboard/google/brya/Makefile.inc b/src/mainboard/google/brya/Makefile.inc index ba81ff5..6f73181 100644 --- a/src/mainboard/google/brya/Makefile.inc +++ b/src/mainboard/google/brya/Makefile.inc @@ -10,6 +10,8 @@ ramstage-y += mainboard.c ramstage-y += ec.c
+smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c + VARIANT_DIR:=$(call strip_quotes,$(CONFIG_VARIANT_DIR))
subdirs-y += variants/baseboard diff --git a/src/mainboard/google/brya/smihandler.c b/src/mainboard/google/brya/smihandler.c new file mode 100644 index 0000000..717facff --- /dev/null +++ b/src/mainboard/google/brya/smihandler.c @@ -0,0 +1,36 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <cpu/x86/smm.h> +#include <ec/google/chromeec/ec.h> +#include <ec/google/chromeec/smm.h> +#include <elog.h> +#include <intelblocks/smihandler.h> +#include <variant/ec.h> + +void mainboard_smi_gpi_handler(const struct gpi_status *sts) +{ + /* TODO: Process SMI events from GPI */ +} + +void mainboard_smi_sleep(u8 slp_typ) +{ + chromeec_smi_sleep(slp_typ, MAINBOARD_EC_S3_WAKE_EVENTS, + MAINBOARD_EC_S5_WAKE_EVENTS); +} + +int mainboard_smi_apmc(u8 apmc) +{ + chromeec_smi_apmc(apmc, MAINBOARD_EC_SCI_EVENTS, + MAINBOARD_EC_SMI_EVENTS); + return 0; +} + +void elog_gsmi_cb_mainboard_log_wake_source(void) +{ + google_chromeec_log_events(MAINBOARD_EC_LOG_EVENTS | MAINBOARD_EC_S0IX_WAKE_EVENTS); +} + +void mainboard_smi_espi_handler(void) +{ + chromeec_smi_process_events(); +}
Hello Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48115
to look at the new patch set (#2).
Change subject: mb/google/brya: Add EC smihandler ......................................................................
mb/google/brya: Add EC smihandler
Add implementation of EC smihandler
BUG=b:174266035 TEST=Build Test
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I211f5755ff44514ab7ab4083f684ddd88c23fe48 --- M src/mainboard/google/brya/Makefile.inc A src/mainboard/google/brya/smihandler.c 2 files changed, 38 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/48115/2
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48115 )
Change subject: mb/google/brya: Add EC smihandler ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/48115/3/src/mainboard/google/brya/s... File src/mainboard/google/brya/smihandler.c:
https://review.coreboot.org/c/coreboot/+/48115/3/src/mainboard/google/brya/s... PS3, Line 10: void mainboard_smi_gpi_handler(const struct gpi_status *sts) : { : /* TODO: Process SMI events from GPI */ : } Are there plans for GPIO SMIs?
https://review.coreboot.org/c/coreboot/+/48115/3/src/mainboard/google/brya/s... PS3, Line 18: MAINBOARD_EC_S5_WAKE_EVENTS); fits on previous line (96 chars)
https://review.coreboot.org/c/coreboot/+/48115/3/src/mainboard/google/brya/s... PS3, Line 24: MAINBOARD_EC_SMI_EVENTS); fits on previous line (96 chars)
Hello build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48115
to look at the new patch set (#4).
Change subject: mb/google/brya: Add EC smihandler ......................................................................
mb/google/brya: Add EC smihandler
Add implementation of EC smihandler
BUG=b:174266035 TEST=Build Test
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I211f5755ff44514ab7ab4083f684ddd88c23fe48 --- M src/mainboard/google/brya/Makefile.inc A src/mainboard/google/brya/smihandler.c 2 files changed, 31 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/48115/4
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48115 )
Change subject: mb/google/brya: Add EC smihandler ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48115/3/src/mainboard/google/brya/s... File src/mainboard/google/brya/smihandler.c:
https://review.coreboot.org/c/coreboot/+/48115/3/src/mainboard/google/brya/s... PS3, Line 18: MAINBOARD_EC_S5_WAKE_EVENTS);
fits on previous line (96 chars)
Done
https://review.coreboot.org/c/coreboot/+/48115/3/src/mainboard/google/brya/s... PS3, Line 24: MAINBOARD_EC_SMI_EVENTS);
fits on previous line (96 chars)
Done
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48115 )
Change subject: mb/google/brya: Add EC smihandler ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48115/3/src/mainboard/google/brya/s... File src/mainboard/google/brya/smihandler.c:
https://review.coreboot.org/c/coreboot/+/48115/3/src/mainboard/google/brya/s... PS3, Line 10: void mainboard_smi_gpi_handler(const struct gpi_status *sts) : { : /* TODO: Process SMI events from GPI */ : }
Are there plans for GPIO SMIs?
Done
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48115 )
Change subject: mb/google/brya: Add EC smihandler ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48115/3/src/mainboard/google/brya/s... File src/mainboard/google/brya/smihandler.c:
https://review.coreboot.org/c/coreboot/+/48115/3/src/mainboard/google/brya/s... PS3, Line 10: void mainboard_smi_gpi_handler(const struct gpi_status *sts) : { : /* TODO: Process SMI events from GPI */ : }
Done
We can add it back if needed. dedede keep this but volteer remove it, so.. I like to remove it for now.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48115 )
Change subject: mb/google/brya: Add EC smihandler ......................................................................
Patch Set 5: Code-Review+2
Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48115 )
Change subject: mb/google/brya: Add EC smihandler ......................................................................
mb/google/brya: Add EC smihandler
Add implementation of EC smihandler
BUG=b:174266035 TEST=Build Test
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I211f5755ff44514ab7ab4083f684ddd88c23fe48 Reviewed-on: https://review.coreboot.org/c/coreboot/+/48115 Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/brya/Makefile.inc A src/mainboard/google/brya/smihandler.c 2 files changed, 31 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/mainboard/google/brya/Makefile.inc b/src/mainboard/google/brya/Makefile.inc index a7bc425..a186bfc 100644 --- a/src/mainboard/google/brya/Makefile.inc +++ b/src/mainboard/google/brya/Makefile.inc @@ -9,6 +9,8 @@ ramstage-y += mainboard.c ramstage-y += ec.c
+smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c + VARIANT_DIR:=$(call strip_quotes,$(CONFIG_VARIANT_DIR))
subdirs-y += variants/baseboard diff --git a/src/mainboard/google/brya/smihandler.c b/src/mainboard/google/brya/smihandler.c new file mode 100644 index 0000000..9208d51 --- /dev/null +++ b/src/mainboard/google/brya/smihandler.c @@ -0,0 +1,29 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <cpu/x86/smm.h> +#include <ec/google/chromeec/ec.h> +#include <ec/google/chromeec/smm.h> +#include <elog.h> +#include <intelblocks/smihandler.h> +#include <variant/ec.h> + +void mainboard_smi_sleep(u8 slp_typ) +{ + chromeec_smi_sleep(slp_typ, MAINBOARD_EC_S3_WAKE_EVENTS, MAINBOARD_EC_S5_WAKE_EVENTS); +} + +int mainboard_smi_apmc(u8 apmc) +{ + chromeec_smi_apmc(apmc, MAINBOARD_EC_SCI_EVENTS, MAINBOARD_EC_SMI_EVENTS); + return 0; +} + +void elog_gsmi_cb_mainboard_log_wake_source(void) +{ + google_chromeec_log_events(MAINBOARD_EC_LOG_EVENTS | MAINBOARD_EC_S0IX_WAKE_EVENTS); +} + +void mainboard_smi_espi_handler(void) +{ + chromeec_smi_process_events(); +}
-
EricR Lai (Code Review) -
Tim Wawrzynczak (Code Review)