Attention is currently required from: Paul Menzel, Lean Sheng Tan, Werner Zeh.
Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71229 )
Change subject: soc/intel/elkhartlake: Make SATA speed limit configurable
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File src/soc/intel/elkhartlake/chip.h:
https://review.coreboot.org/c/coreboot/+/71229/comment/42b0997e_0787e49e
PS2, Line 108: SATA_DEFAULT = 0,
: SATA_GEN1,
: SATA_GEN2
Since Gen 3 is the highest SATA speed grade it is not really a limit then. […]
I have also looked inside FSP and there it is defined as you already mentioned. So I just thought that maybe it's good to keep it the same, but it's good for me.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/71229
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I610263b34b0947378d2025211ece4a9ec8fbfef6
Gerrit-Change-Number: 71229
Gerrit-PatchSet: 2
Gerrit-Owner: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Wed, 04 Jan 2023 11:39:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Mario Scheithauer
mario.scheithauer@siemens.com
Comment-In-Reply-To: Werner Zeh
werner.zeh@siemens.com
Gerrit-MessageType: comment