Attention is currently required from: Paul Menzel, Derek Huang, Curtis Chen, Brandon Breitenstein.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57139 )
Change subject: soc/intel/common/tcss: Optimize USB-C DP flow and code structure
......................................................................
Patch Set 22:
(2 comments)
File src/soc/intel/common/block/tcss/tcss.c:
https://review.coreboot.org/c/coreboot/+/57139/comment/b2ae24da_f808302c
PS22, Line 297: port_bitmask = ops->dp_ops.wait_for_connection(WAIT_FOR_DISPLAYPORT_TIMEOUT_MS);
suggestion: after getting `ops`, return early if ops is NULL
https://review.coreboot.org/c/coreboot/+/57139/comment/e75bb0dc_41dad844
PS22, Line 331: if (ret)
: printk(BIOS_ERR, "Port C%zd mux set failed with error %d\n", i, ret);
: else {
: printk(BIOS_INFO, "Port C%zd is configured to DP mode!\n", i);
: return;
: }
style: if one arm of a conditional requires braces, then all branches should have them
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57139
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia7e6dd952d3183ecb76de6d4887ee573ef89bb50
Gerrit-Change-Number: 57139
Gerrit-PatchSet: 22
Gerrit-Owner: Derek Huang
derek.huang@intel.corp-partner.google.com
Gerrit-Reviewer: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Curtis Chen
curtis.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Curtis Chen
curtis.chen@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Derek Huang
derek.huang@intel.corp-partner.google.com
Gerrit-Attention: Curtis Chen
curtis.chen@intel.com
Gerrit-Attention: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Attention: Curtis Chen
curtis.chen@intel.corp-partner.google.com
Gerrit-Comment-Date: Mon, 04 Oct 2021 17:44:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment