Attention is currently required from: Nick Vaccaro, Paul Menzel.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78009?usp=email )
Change subject: mb/google/brox: Create new Brox baseboard ......................................................................
Patch Set 11:
(3 comments)
File src/mainboard/google/brox/Kconfig:
https://review.coreboot.org/c/coreboot/+/78009/comment/d4e9aace_e6b8d31c : PS9, Line 84: BOARD_GOOGLE_BASEBOARD_HADES
You can get rid of checks for hades, hades has been deprecated and wouldn't be part of the brox fami […]
Done
https://review.coreboot.org/c/coreboot/+/78009/comment/484623a0_56592fb3 : PS9, Line 85: BOARD_GOOGLE_BASEBOARD_HADES
same
Done
https://review.coreboot.org/c/coreboot/+/78009/comment/c5f100d4_8b851764 : PS9, Line 154: BOARD_GOOGLE_PIRRHA
Is pirrha a Brox variant? If not, this check should be deleted.
Done