HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33891
Change subject: mainboard/biostar: remove stdlib.h when unused ......................................................................
mainboard/biostar: remove stdlib.h when unused
Change-Id: I03d1af0858952972c92b83375a55dbda87e69f8a Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/biostar/a68n_5200/BiosCallOuts.c M src/mainboard/biostar/a68n_5200/buildOpts.c M src/mainboard/biostar/am1ml/BiosCallOuts.c M src/mainboard/biostar/am1ml/buildOpts.c 4 files changed, 0 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/33891/1
diff --git a/src/mainboard/biostar/a68n_5200/BiosCallOuts.c b/src/mainboard/biostar/a68n_5200/BiosCallOuts.c index 8f55fb6..cc5081b 100644 --- a/src/mainboard/biostar/a68n_5200/BiosCallOuts.c +++ b/src/mainboard/biostar/a68n_5200/BiosCallOuts.c @@ -17,7 +17,6 @@ #include <northbridge/amd/agesa/BiosCallOuts.h> #include <northbridge/amd/agesa/state_machine.h> #include <FchPlatform.h> -#include <stdlib.h>
#include "imc.h"
diff --git a/src/mainboard/biostar/a68n_5200/buildOpts.c b/src/mainboard/biostar/a68n_5200/buildOpts.c index 65b86b8..bb8527d 100644 --- a/src/mainboard/biostar/a68n_5200/buildOpts.c +++ b/src/mainboard/biostar/a68n_5200/buildOpts.c @@ -25,7 +25,6 @@ * */
-#include <stdlib.h> #include <AGESA.h>
#define INSTALL_FT3_SOCKET_SUPPORT TRUE diff --git a/src/mainboard/biostar/am1ml/BiosCallOuts.c b/src/mainboard/biostar/am1ml/BiosCallOuts.c index 17c25ae..6181226 100644 --- a/src/mainboard/biostar/am1ml/BiosCallOuts.c +++ b/src/mainboard/biostar/am1ml/BiosCallOuts.c @@ -20,7 +20,6 @@ #include <northbridge/amd/agesa/BiosCallOuts.h> #include <northbridge/amd/agesa/state_machine.h> #include <FchPlatform.h> -#include <stdlib.h>
const BIOS_CALLOUT_STRUCT BiosCallouts[] = { diff --git a/src/mainboard/biostar/am1ml/buildOpts.c b/src/mainboard/biostar/am1ml/buildOpts.c index 30c0699..74216f0 100644 --- a/src/mainboard/biostar/am1ml/buildOpts.c +++ b/src/mainboard/biostar/am1ml/buildOpts.c @@ -25,7 +25,6 @@ * */
-#include <stdlib.h> #include <AGESA.h>
#define INSTALL_FT3_SOCKET_SUPPORT TRUE
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33891
to look at the new patch set (#2).
Change subject: mainboard/biostar: Remove stdlib.h when unused ......................................................................
mainboard/biostar: Remove stdlib.h when unused
Change-Id: I03d1af0858952972c92b83375a55dbda87e69f8a Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/biostar/a68n_5200/BiosCallOuts.c M src/mainboard/biostar/a68n_5200/buildOpts.c M src/mainboard/biostar/am1ml/BiosCallOuts.c M src/mainboard/biostar/am1ml/buildOpts.c 4 files changed, 0 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/33891/2
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/33891 )
Change subject: mainboard/biostar: Remove stdlib.h when unused ......................................................................
Abandoned
see 32023
HAOUAS Elyes has restored this change. ( https://review.coreboot.org/c/coreboot/+/33891 )
Change subject: mainboard/biostar: Remove stdlib.h when unused ......................................................................
Restored
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33891
to look at the new patch set (#3).
Change subject: mb/{bap,biostar}: Remove unused <stdlib.h> ......................................................................
mb/{bap,biostar}: Remove unused <stdlib.h>
Change-Id: I03d1af0858952972c92b83375a55dbda87e69f8a Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/bap/ode_e20XX/BiosCallOuts.c M src/mainboard/bap/ode_e20XX/buildOpts.c M src/mainboard/bap/ode_e21XX/BiosCallOuts.c M src/mainboard/biostar/a68n_5200/BiosCallOuts.c M src/mainboard/biostar/a68n_5200/buildOpts.c M src/mainboard/biostar/am1ml/BiosCallOuts.c M src/mainboard/biostar/am1ml/buildOpts.c 7 files changed, 0 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/33891/3
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33891
to look at the new patch set (#7).
Change subject: mb/{bap,biostar}: Remove unused <stdlib.h> ......................................................................
mb/{bap,biostar}: Remove unused <stdlib.h>
Change-Id: I03d1af0858952972c92b83375a55dbda87e69f8a Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/biostar/am1ml/BiosCallOuts.c M src/mainboard/biostar/am1ml/buildOpts.c 2 files changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/33891/7
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33891
to look at the new patch set (#8).
Change subject: mb/biostar: Remove unused <stdlib.h> ......................................................................
mb/biostar: Remove unused <stdlib.h>
Change-Id: I03d1af0858952972c92b83375a55dbda87e69f8a Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/biostar/am1ml/BiosCallOuts.c M src/mainboard/biostar/am1ml/buildOpts.c 2 files changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/33891/8
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33891 )
Change subject: mb/biostar: Remove unused <stdlib.h> ......................................................................
Patch Set 8: Code-Review+2
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33891 )
Change subject: mb/biostar: Remove unused <stdlib.h> ......................................................................
Patch Set 8: Code-Review+2
Kyösti Mälkki has submitted this change. ( https://review.coreboot.org/c/coreboot/+/33891 )
Change subject: mb/biostar: Remove unused <stdlib.h> ......................................................................
mb/biostar: Remove unused <stdlib.h>
Change-Id: I03d1af0858952972c92b83375a55dbda87e69f8a Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/33891 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Frans Hendriks fhendriks@eltan.com Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/mainboard/biostar/am1ml/BiosCallOuts.c M src/mainboard/biostar/am1ml/buildOpts.c 2 files changed, 0 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved Frans Hendriks: Looks good to me, approved
diff --git a/src/mainboard/biostar/am1ml/BiosCallOuts.c b/src/mainboard/biostar/am1ml/BiosCallOuts.c index 17c25ae..6181226 100644 --- a/src/mainboard/biostar/am1ml/BiosCallOuts.c +++ b/src/mainboard/biostar/am1ml/BiosCallOuts.c @@ -20,7 +20,6 @@ #include <northbridge/amd/agesa/BiosCallOuts.h> #include <northbridge/amd/agesa/state_machine.h> #include <FchPlatform.h> -#include <stdlib.h>
const BIOS_CALLOUT_STRUCT BiosCallouts[] = { diff --git a/src/mainboard/biostar/am1ml/buildOpts.c b/src/mainboard/biostar/am1ml/buildOpts.c index 30c0699..74216f0 100644 --- a/src/mainboard/biostar/am1ml/buildOpts.c +++ b/src/mainboard/biostar/am1ml/buildOpts.c @@ -25,7 +25,6 @@ * */
-#include <stdlib.h> #include <AGESA.h>
#define INSTALL_FT3_SOCKET_SUPPORT TRUE
-
Frans Hendriks (Code Review) -
HAOUAS Elyes (Code Review)
-
Kyösti Mälkki (Code Review)