Change in coreboot[master]: util/mtkheader: Port gen-bl-img.py to python3

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Stefan Reinauer (Code Review)

12 Jun 2020 12 Jun '20

9:52 p.m.

Stefan Reinauer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42320 )

Change subject: util/mtkheader: Port gen-bl-img.py to python3 ......................................................................

util/mtkheader: Port gen-bl-img.py to python3

converted with 2to3 and manually changed shebang to reflect python3. Tested by calling the script on the command line.

Change-Id: Ia7b46093f1dcecd03d16fbe5f37d1aae7679bac3 Signed-off-by: Stefan Reinauer stefan.reinauer@coreboot.org --- M util/mtkheader/gen-bl-img.py 1 file changed, 4 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/42320/1

diff --git a/util/mtkheader/gen-bl-img.py b/util/mtkheader/gen-bl-img.py index 282dfbf..e1672fa 100755 --- a/util/mtkheader/gen-bl-img.py +++ b/util/mtkheader/gen-bl-img.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python2 +#!/usr/bin/env python3 # # SPDX-License-Identifier: GPL-2.0-only

@@ -77,9 +77,9 @@

def main(argv): if len(argv) != 5: - print 'Usage: %s <chip> <flash_type> <input_file> <output_file>' % argv[0] - print '\t flash_type: emmc|sf' - print '\t chip : mt8173|mt8183' + print('Usage: %s <chip> <flash_type> <input_file> <output_file>' % argv[0]) + print('\t flash_type: emmc|sf') + print('\t chip : mt8173|mt8183')

exit(1) write(argv[4], gen_preloader(argv[1], argv[2], read(argv[3])))

Attachments:

attachment.htm (text/html — 3.2 KB)

Show replies by date

Julius Werner (Code Review)

12 Jun 12 Jun

10:05 p.m.

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42320 )

Change subject: util/mtkheader: Port gen-bl-img.py to python3 ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/42320 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia7b46093f1dcecd03d16fbe5f37d1aae7679bac3 Gerrit-Change-Number: 42320 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Hung-Te Lin hungte@chromium.org Gerrit-Comment-Date: Fri, 12 Jun 2020 22:05:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Felix Singer (Code Review)

17 Jun 17 Jun

12:48 a.m.

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42320 )

Change subject: util/mtkheader: Port gen-bl-img.py to python3 ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/42320 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia7b46093f1dcecd03d16fbe5f37d1aae7679bac3 Gerrit-Change-Number: 42320 Gerrit-PatchSet: 2 Gerrit-Owner: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Hung-Te Lin hungte@chromium.org Gerrit-Comment-Date: Wed, 17 Jun 2020 00:48:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Hung-Te Lin (Code Review)

2:16 a.m.

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42320 )

Change subject: util/mtkheader: Port gen-bl-img.py to python3 ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/42320 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia7b46093f1dcecd03d16fbe5f37d1aae7679bac3 Gerrit-Change-Number: 42320 Gerrit-PatchSet: 2 Gerrit-Owner: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 17 Jun 2020 02:16:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Paul Menzel (Code Review)

8:21 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42320 )

Change subject: util/mtkheader: Port gen-bl-img.py to python3 ......................................................................

Patch Set 3:

(1 comment)

Ok, only `print()` is needed.

https://review.coreboot.org/c/coreboot/+/42320/3/util/mtkheader/gen-bl-img.p... File util/mtkheader/gen-bl-img.py:

https://review.coreboot.org/c/coreboot/+/42320/3/util/mtkheader/gen-bl-img.p... PS3, Line 1: #!/usr/bin/env python3 Can it stay with `python`, as `print()` is supported by Python 2 too?

-- To view, visit https://review.coreboot.org/c/coreboot/+/42320 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia7b46093f1dcecd03d16fbe5f37d1aae7679bac3 Gerrit-Change-Number: 42320 Gerrit-PatchSet: 3 Gerrit-Owner: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 17 Jun 2020 08:21:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Hung-Te Lin (Code Review)

8:24 a.m.

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42320 )

Change subject: util/mtkheader: Port gen-bl-img.py to python3 ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42320/3/util/mtkheader/gen-bl-img.p... File util/mtkheader/gen-bl-img.py:

https://review.coreboot.org/c/coreboot/+/42320/3/util/mtkheader/gen-bl-img.p... PS3, Line 1: #!/usr/bin/env python3

...

Can it stay with `python`, as `print()` is supported by Python 2 too?

you will need to add

from __future__ import print_function

But yes, that may be a good plan.

-- To view, visit https://review.coreboot.org/c/coreboot/+/42320 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia7b46093f1dcecd03d16fbe5f37d1aae7679bac3 Gerrit-Change-Number: 42320 Gerrit-PatchSet: 3 Gerrit-Owner: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 17 Jun 2020 08:24:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Idwer Vollering (Code Review)

12:42 p.m.

Idwer Vollering has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42320 )

Change subject: util/mtkheader: Port gen-bl-img.py to python3 ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42320/3/util/mtkheader/gen-bl-img.p... File util/mtkheader/gen-bl-img.py:

https://review.coreboot.org/c/coreboot/+/42320/3/util/mtkheader/gen-bl-img.p... PS3, Line 80: output_file While you're updating this code to python3, may I suggest using string literals instead? print(f"Usage: {argv[0]} ...")

https://docs.python.org/3/reference/lexical_analysis.html#formatted-string-l...

-- To view, visit https://review.coreboot.org/c/coreboot/+/42320 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia7b46093f1dcecd03d16fbe5f37d1aae7679bac3 Gerrit-Change-Number: 42320 Gerrit-PatchSet: 3 Gerrit-Owner: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Idwer Vollering vidwer@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 17 Jun 2020 12:42:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Idwer Vollering (Code Review)

13 Aug 13 Aug

4:16 p.m.

Idwer Vollering has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42320 )

Change subject: util/mtkheader: Port gen-bl-img.py to python3 ......................................................................

Patch Set 3:

ping

-- To view, visit https://review.coreboot.org/c/coreboot/+/42320 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia7b46093f1dcecd03d16fbe5f37d1aae7679bac3 Gerrit-Change-Number: 42320 Gerrit-PatchSet: 3 Gerrit-Owner: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Idwer Vollering vidwer@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 13 Aug 2020 16:16:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Stefan Reinauer (Code Review)

15 Aug 15 Aug

3:26 a.m.

Stefan Reinauer has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/42320 )

Change subject: util/mtkheader: Port gen-bl-img.py to python3 ......................................................................

Abandoned

-- To view, visit https://review.coreboot.org/c/coreboot/+/42320 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia7b46093f1dcecd03d16fbe5f37d1aae7679bac3 Gerrit-Change-Number: 42320 Gerrit-PatchSet: 3 Gerrit-Owner: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Idwer Vollering vidwer@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: abandon

1507

days inactive

1571

days old

coreboot-gerrit@coreboot.org

8 comments

6 participants

tags (0)

participants (6)

Felix Singer (Code Review)
Hung-Te Lin (Code Review)
Idwer Vollering (Code Review)
Julius Werner (Code Review)
Paul Menzel (Code Review)
Stefan Reinauer (Code Review)