[S] Change in coreboot[main]: soc/mediatek/mt8196: Remove useless LVTS controller

[Jarried Lin (Code Review)]

Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu, Zhaoqing Jiu.

Hello Zhaoqing Jiu,

I'd like you to do a code review.
Please visit

https://review.coreboot.org/c/coreboot/+/86687?usp=email

to review the following change.

Change subject: soc/mediatek/mt8196: Remove useless LVTS controller
......................................................................

soc/mediatek/mt8196: Remove useless LVTS controller

Controller2 and controller3 are disabled, remove them from soure code.

BRANCH=rauru
BUG=b:389026545
TEST=Boot up to kernel

Signed-off-by: Zhaoqing Jiu 
Change-Id: I69c1e76e7de544fd4e24e8e94e4f676de783e205
---
M src/soc/mediatek/mt8196/include/soc/thermal_internal.h
M src/soc/mediatek/mt8196/thermal.c
2 files changed, 0 insertions(+), 44 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/86687/1

diff --git a/src/soc/mediatek/mt8196/include/soc/thermal_internal.h b/src/soc/mediatek/mt8196/include/soc/thermal_internal.h
index 55c300d..7ced0b0 100644
--- a/src/soc/mediatek/mt8196/include/soc/thermal_internal.h
+++ b/src/soc/mediatek/mt8196/include/soc/thermal_internal.h
@@ -23,28 +23,18 @@
    L_TS_LVTS12_1,		/* LVTS12-1 SOC-BOT */
    L_TS_LVTS12_2,		/* LVTS12-2 SOC-BOT */
    L_TS_LVTS12_3,		/* LVTS12-3 SOC-BOT */
-	L_TS_LVTS13_0,		/* LVTS13-0 MD-AP */
-	L_TS_LVTS13_1,		/* LVTS13-1 MD-AP */
-	L_TS_LVTS13_2,		/* LVTS13-2 MD-AP */
-	L_TS_LVTS13_3,		/* LVTS13-3 MD-AP */
-	L_TS_LVTS14_0,		/* LVTS14-0 SOC-ADCT */
-	L_TS_LVTS14_3,		/* LVTS14-3 SOC-ADCT */
    L_TS_LVTS_NUM,
 };

enum lvts_tc {
    LVTS_AP_CONTROLLER0 = 0,
    LVTS_AP_CONTROLLER1,
-	LVTS_AP_CONTROLLER2,
-	LVTS_AP_CONTROLLER3,
    LVTS_CONTROLLER_NUM,
 };

enum lvts_tc_offset {
    TS_OFFSET_AP_CONTROLLER0 = 0,
    TS_OFFSET_AP_CONTROLLER1 = 0x100,
-	TS_OFFSET_AP_CONTROLLER2 = 0x200,
-	TS_OFFSET_AP_CONTROLLER3 = 0x300,
 };

enum sensor_switch_status {
@@ -80,10 +70,6 @@
    mtk_lvts_ap_controller0 = (void *)(THERM_CTRL_BASE + TS_OFFSET_AP_CONTROLLER0);
 static struct mtk_thermal_controller_regs *const
    mtk_lvts_ap_controller1 = (void *)(THERM_CTRL_BASE + TS_OFFSET_AP_CONTROLLER1);
-static struct mtk_thermal_controller_regs *const
-	mtk_lvts_ap_controller2 = (void *)(THERM_CTRL_BASE + TS_OFFSET_AP_CONTROLLER2);
-static struct mtk_thermal_controller_regs *const
-	mtk_lvts_ap_controller3 = (void *)(THERM_CTRL_BASE + TS_OFFSET_AP_CONTROLLER3);

struct mtk_thermal_controller_regs {
    u32 lvtsmonctl0_0;
diff --git a/src/soc/mediatek/mt8196/thermal.c b/src/soc/mediatek/mt8196/thermal.c
index 0e284ce..84cd8d8 100644
--- a/src/soc/mediatek/mt8196/thermal.c
+++ b/src/soc/mediatek/mt8196/thermal.c
@@ -67,36 +67,6 @@
    	},
    	.regs = mtk_lvts_ap_controller1,
    },
-	[LVTS_AP_CONTROLLER2] = { /* MD-AP */
-		.ts = {L_TS_LVTS13_0, L_TS_LVTS13_1, L_TS_LVTS13_2, L_TS_LVTS13_3},
-		.sensor_on_off = {SEN_ON, SEN_ON, SEN_ON, SEN_ON},
-		.ctrl_on_off = CTRL_OFF,
-		.ts_number = 4,
-		.reboot_temperature = 118800,
-		.dominator_ts_idx = 0,
-		.speed = {
-			.group_interval_delay = 0x7fff,
-			.period_unit = 0x001,
-			.filter_interval_delay = 0x001,
-			.sensor_interval_delay = 0x001,
-		},
-		.regs = mtk_lvts_ap_controller2,
-	},
-	[LVTS_AP_CONTROLLER3] = { /* SOC-ADCT */
-		.ts = {L_TS_LVTS14_0, L_TS_LVTS14_3},
-		.sensor_on_off = {SEN_ON, SEN_ON},
-		.ctrl_on_off = CTRL_OFF,
-		.ts_number = 2,
-		.reboot_temperature = 118800,
-		.dominator_ts_idx = 0,
-		.speed = {
-			.group_interval_delay = 0x7fff,
-			.period_unit = 0x001,
-			.filter_interval_delay = 0x001,
-			.sensor_interval_delay = 0x001,
-		},
-		.regs = mtk_lvts_ap_controller3,
-	},
 };

static uint32_t golden_temp;