Attention is currently required from: Dinesh Gehlot, Nick Vaccaro, Paul Menzel, Poornima Tom, V Sowmya.
Felix Held has posted comments on this change by Poornima Tom. ( https://review.coreboot.org/c/coreboot/+/83138?usp=email )
Change subject: mb/google/nissa/var/nivviks: Update config for CNVi
......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83138/comment/d6333bc2_afaac5ab?usp... :
PS3, Line 9: Added
Add
Done
https://review.coreboot.org/c/coreboot/+/83138/comment/7551ae6e_394a3109?usp... :
PS3, Line 9: Also, set 'add_acpi_dma_property' to
: true.
:
Why?
see https://learn.microsoft.com/en-us/windows-hardware/drivers/pci/dsd-for-pcie-...
not sure if this needs more explanation in the commit message. maybe "set 'add_acpi_dma_property' to true to tell the OS to enforce DMA protection for this device"
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83138?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If04539fe8dceb5c2edfc06a324ede11147b78b6d
Gerrit-Change-Number: 83138
Gerrit-PatchSet: 4
Gerrit-Owner: Poornima Tom
poornima.tom@intel.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Poornima Tom
poornima.tom@intel.corp-partner.google.com
Gerrit-Attention: Poornima Tom
poornima.tom@intel.com
Gerrit-Attention: V Sowmya
v.sowmya@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Thu, 27 Jun 2024 16:04:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org