Change in coreboot[master]: src/device/pci: add support for AMD_DGPU_WITHOUT_EEPROM init and OpRO...

[Arthur Heymans (Code Review)]

Attention is currently required from: [e-mail], Paul Menzel, Mike Banon.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58652 )

Change subject: src/device/pci: add support for AMD_DGPU_WITHOUT_EEPROM init and OpROM loading
......................................................................

Patch Set 1: Code-Review-1

(1 comment)

Patchset:

PS1:
> This change is critically important: it helps the platforms like Lenovo G505S (see CB:58653) and HP Pavilion m6-1035dx (see CB:58654) to get their discrete GPU working - a really major hardware feature!
>
> Arthur Heymans, thank you for advising the alternative implementation at the previous change version: it's still here in the moved comments. However, although this alternative may be nicer, it's going to take plenty of time & effort to implement. Meanwhile, the coreboot users of multiple platforms would like to have their discrete GPUs working as soon as possible, and instead of this solution being painfully delayed more and more (which only discourages the further work) it should be merged ASAP.

No sorry, not going for that 'it needs to be merged ASAP'. This touches common code for a problem on boards you care about. This problem can be solved in a better way without touching common code. It's nice that this hack makes a feature work on your hardware, but that's not sufficient for the master branch that needs to remain maintainable for a ton of other boards and platforms. I suggest you put this hack in mainboard specific code or create a PCI driver for it. Or just figure out how to add both to VFCT.