Attention is currently required from: Nico Huber, Tarun Tuli, Subrata Banik, Kapil Porwal, Sridhar Siricilla.
Pratikkumar V Prajapati has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72722 )
Change subject: soc/intel/common: Add Intel Trace Hub driver
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS3:
That's a good question. IMO, Not all devices may have 4+ GiB RAM. […]
Nico, Sorry for the long pause in replying.
Is the platform has more than 4GB of memory it can be used to store larger amount of traces from Intel Trace HUB (TH) IP. If the memory is smaller than 4GB, we can still user internal buffer of TH to store traces. In either cases we can still use streaming to the host machine to get traces. This driver adds support for devices that have larger memory. If the platform has memory larger than 4GB then FSP will allocate region for traces in DRAM (per UPD params), if platform has lesser memory then we need to use internal buffer or use streaming mode.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/72722
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie5a348071b6c6a35e8be3efd1b2b658a991aed0e
Gerrit-Change-Number: 72722
Gerrit-PatchSet: 4
Gerrit-Owner: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Comment-Date: Tue, 07 Mar 2023 02:53:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-MessageType: comment