Change in coreboot[master]: mb/google/hatch/var: Increase Goodix touchscreen reset delay to 500ms
Philip Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35350 )
Change subject: mb/google/hatch/var: Increase Goodix touchscreen reset delay to 500ms ......................................................................
mb/google/hatch/var: Increase Goodix touchscreen reset delay to 500ms
Even though GT7375P programming guide rev0.4 only requires a reset delay of 120ms, in practice, we have to increase the reset delay to 500ms, or Goodix FW update would fail.
BUG=b:138795891, b:138796844 TEST=boot helios board and verify Goodix FW update succeeded
Signed-off-by: Philip Chen philipchen@google.com Change-Id: Ic0049bf240de0a1c7f1b1f39bf155d48bb76fb86 --- M src/mainboard/google/hatch/variants/hatch/overridetree.cb M src/mainboard/google/hatch/variants/helios/overridetree.cb 2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/35350/1
diff --git a/src/mainboard/google/hatch/variants/hatch/overridetree.cb b/src/mainboard/google/hatch/variants/hatch/overridetree.cb index 6ed25c8..df2cc38 100644 --- a/src/mainboard/google/hatch/variants/hatch/overridetree.cb +++ b/src/mainboard/google/hatch/variants/hatch/overridetree.cb @@ -98,7 +98,7 @@ register "generic.probed" = "1" register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D15)" - register "generic.reset_delay_ms" = "120" + register "generic.reset_delay_ms" = "500" register "generic.reset_off_delay_ms" = "3" register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D9)" register "generic.enable_delay_ms" = "12" diff --git a/src/mainboard/google/hatch/variants/helios/overridetree.cb b/src/mainboard/google/hatch/variants/helios/overridetree.cb index b3da8c9..8ca878d 100644 --- a/src/mainboard/google/hatch/variants/helios/overridetree.cb +++ b/src/mainboard/google/hatch/variants/helios/overridetree.cb @@ -103,7 +103,7 @@ register "generic.probed" = "1" register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D15)" - register "generic.reset_delay_ms" = "120" + register "generic.reset_delay_ms" = "500" register "generic.reset_off_delay_ms" = "1" register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D9)"
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35350 )
Change subject: mb/google/hatch/var: Increase Goodix touchscreen reset delay to 500ms ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35350/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35350/1//COMMIT_MSG@11 PS1, Line 11: Goodix FW update would fail. Can you please add that this is a workaround until a real fix is found?
Hello Paul Fagerburg, Tim Wawrzynczak, Shelley Chen, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35350
to look at the new patch set (#2).
Change subject: mb/google/hatch/var: Increase Goodix touchscreen reset delay to 500ms ......................................................................
mb/google/hatch/var: Increase Goodix touchscreen reset delay to 500ms
Even though GT7375P programming guide rev0.4 only requires a reset delay of 120ms, in practice, we have to increase the reset delay to 500ms, or Goodix FW update would fail.
This is a workaround. In the long run, we hope Goodix can fix the power sequence in touch firmware.
BUG=b:138795891, b:138796844 TEST=boot helios board and verify Goodix FW update succeeded
Signed-off-by: Philip Chen philipchen@google.com Change-Id: Ic0049bf240de0a1c7f1b1f39bf155d48bb76fb86 --- M src/mainboard/google/hatch/variants/hatch/overridetree.cb M src/mainboard/google/hatch/variants/helios/overridetree.cb 2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/35350/2
Philip Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35350 )
Change subject: mb/google/hatch/var: Increase Goodix touchscreen reset delay to 500ms ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35350/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35350/1//COMMIT_MSG@11 PS1, Line 11: Goodix FW update would fail.
Can you please add that this is a workaround until a real fix is found?
Done
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35350 )
Change subject: mb/google/hatch/var: Increase Goodix touchscreen reset delay to 500ms ......................................................................
Patch Set 2: Code-Review+2
Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35350 )
Change subject: mb/google/hatch/var: Increase Goodix touchscreen reset delay to 500ms ......................................................................
mb/google/hatch/var: Increase Goodix touchscreen reset delay to 500ms
Even though GT7375P programming guide rev0.4 only requires a reset delay of 120ms, in practice, we have to increase the reset delay to 500ms, or Goodix FW update would fail.
This is a workaround. In the long run, we hope Goodix can fix the power sequence in touch firmware.
BUG=b:138795891, b:138796844 TEST=boot helios board and verify Goodix FW update succeeded
Signed-off-by: Philip Chen philipchen@google.com Change-Id: Ic0049bf240de0a1c7f1b1f39bf155d48bb76fb86 Reviewed-on: https://review.coreboot.org/c/coreboot/+/35350 Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/hatch/variants/hatch/overridetree.cb M src/mainboard/google/hatch/variants/helios/overridetree.cb 2 files changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/src/mainboard/google/hatch/variants/hatch/overridetree.cb b/src/mainboard/google/hatch/variants/hatch/overridetree.cb index 6ed25c8..df2cc38 100644 --- a/src/mainboard/google/hatch/variants/hatch/overridetree.cb +++ b/src/mainboard/google/hatch/variants/hatch/overridetree.cb @@ -98,7 +98,7 @@ register "generic.probed" = "1" register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D15)" - register "generic.reset_delay_ms" = "120" + register "generic.reset_delay_ms" = "500" register "generic.reset_off_delay_ms" = "3" register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D9)" register "generic.enable_delay_ms" = "12" diff --git a/src/mainboard/google/hatch/variants/helios/overridetree.cb b/src/mainboard/google/hatch/variants/helios/overridetree.cb index b3da8c9..8ca878d 100644 --- a/src/mainboard/google/hatch/variants/helios/overridetree.cb +++ b/src/mainboard/google/hatch/variants/helios/overridetree.cb @@ -103,7 +103,7 @@ register "generic.probed" = "1" register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D15)" - register "generic.reset_delay_ms" = "120" + register "generic.reset_delay_ms" = "500" register "generic.reset_off_delay_ms" = "1" register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D9)"
-
Furquan Shaikh (Code Review) -
Philip Chen (Code Review)