Peter Lemenkov has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37385 )
Change subject: mb/lenovo/w530/devicetree: Use subsystemid inheritance ......................................................................
mb/lenovo/w530/devicetree: Use subsystemid inheritance
Change-Id: I0646b18e823c52109e0fb62c85726622156172b9 Signed-off-by: Peter Lemenkov lemenkov@gmail.com --- M src/mainboard/lenovo/t530/variants/w530/devicetree.cb 1 file changed, 32 insertions(+), 74 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/37385/1
diff --git a/src/mainboard/lenovo/t530/variants/w530/devicetree.cb b/src/mainboard/lenovo/t530/variants/w530/devicetree.cb index 0844124..f197f17 100644 --- a/src/mainboard/lenovo/t530/variants/w530/devicetree.cb +++ b/src/mainboard/lenovo/t530/variants/w530/devicetree.cb @@ -37,6 +37,8 @@ register "pci_mmio_size" = "2048"
device domain 0x0 on + subsystemid 0x17aa 0x21f6 inherit + chip southbridge/intel/bd82x6x # Intel Series 6 Cougar Point PCH # GPI routing # 0 No effect (default) @@ -60,67 +62,39 @@ register "superspeed_capable_ports" = "0x0000000f" register "xhci_overcurrent_mapping" = "0x04000201" register "xhci_switchable_ports" = "0x0000000f" - device pci 14.0 on # USB 3.0 Controller - subsystemid 0x17aa 0x21f6 - end - device pci 16.0 on # Management Engine Interface 1 - subsystemid 0x17aa 0x21f6 - end - device pci 16.1 off # Management Engine Interface 2 - end - device pci 16.2 off # Management Engine IDE-R - end - device pci 16.3 on # Management Engine KT - subsystemid 0x17aa 0x21f6 - end + device pci 14.0 on end # USB 3.0 Controller + device pci 16.0 on end # Management Engine Interface 1 + device pci 16.1 off end # Management Engine Interface 2 + device pci 16.2 off end # Management Engine IDE-R + device pci 16.3 on end # Management Engine KT device pci 19.0 on # Intel Gigabit Ethernet subsystemid 0x17aa 0x21f3 end - device pci 1a.0 on # USB2 EHCI #2 - subsystemid 0x17aa 0x21f6 - end - device pci 1b.0 on # High Definition Audio Audio controller - subsystemid 0x17aa 0x21f6 - end + device pci 1a.0 on end # USB2 EHCI #2 + device pci 1b.0 on end # High Definition Audio Audio controller device pci 1c.0 on # PCIe Port #1 - subsystemid 0x17aa 0x21f6 chip drivers/ricoh/rce822 # Ricoh cardreader register "disable_mask" = "0x83" register "sdwppol" = "1" - device pci 00.0 on # Ricoh SD card reader - subsystemid 0x17aa 0x21f6 - end + device pci 00.0 on end # Ricoh SD card reader end end - device pci 1c.1 on # PCIe Port #2 - subsystemid 0x17aa 0x21f6 - end + device pci 1c.1 on end # PCIe Port #2 device pci 1c.2 on # PCIe Port #3 - subsystemid 0x17aa 0x21f6 smbios_slot_desc "7" "3" "ExpressCard Slot" "8" end - device pci 1c.3 off # PCIe Port #4 - end - device pci 1c.4 off # PCIe Port #5 - end - device pci 1c.5 off # PCIe Port #6 - end - device pci 1c.6 off # PCIe Port #7 - end - device pci 1c.7 off # PCIe Port #8 - end - device pci 1d.0 on # USB2 EHCI #1 - subsystemid 0x17aa 0x21f6 - end - device pci 1e.0 off # PCI bridge - end + device pci 1c.3 off end # PCIe Port #4 + device pci 1c.4 off end # PCIe Port #5 + device pci 1c.5 off end # PCIe Port #6 + device pci 1c.6 off end # PCIe Port #7 + device pci 1c.7 off end # PCIe Port #8 + device pci 1d.0 on end # USB2 EHCI #1 + device pci 1e.0 off end # PCI bridge device pci 1f.0 on # LPC bridge PCI-LPC bridge - subsystemid 0x17aa 0x21f6 chip ec/lenovo/pmh7 register "backlight_enable" = "0x01" register "dock_event_enable" = "0x01" - device pnp ff.1 on # dummy - end + device pnp ff.1 on end # dummy end
chip drivers/pc80/tpm @@ -178,41 +152,25 @@ register "has_thinker1" = "1" end end - device pci 1f.2 on # SATA Controller 1 - subsystemid 0x17aa 0x21f6 + device pci 1f.2 on end # SATA Controller 1 end device pci 1f.3 on # SMBus - subsystemid 0x17aa 0x21f6 chip drivers/i2c/at24rf08c # eeprom, 8 virtual devices, same chip - device i2c 54 on - end - device i2c 55 on - end - device i2c 56 on - end - device i2c 57 on - end - device i2c 5c on - end - device i2c 5d on - end - device i2c 5e on - end - device i2c 5f on - end + device i2c 54 on end + device i2c 55 on end + device i2c 56 on end + device i2c 57 on end + device i2c 5c on end + device i2c 5d on end + device i2c 5e on end + device i2c 5f on end end end - device pci 1f.5 off # SATA Controller 2 - end - device pci 1f.6 off # Thermal - end + device pci 1f.5 off end # SATA Controller 2 + device pci 1f.6 off end # Thermal end - device pci 00.0 on # Host bridge Host bridge - subsystemid 0x17aa 0x21f6 - end - device pci 01.0 on # PCIe Bridge for discrete graphics - subsystemid 0x17aa 0x21f6 - end + device pci 00.0 on end # Host bridge Host bridge + device pci 01.0 on end # PCIe Bridge for discrete graphics device pci 02.0 on # Internal graphics VGA controller subsystemid 0x17aa 0x21f5 end
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37385 )
Change subject: mb/lenovo/w530/devicetree: Use subsystemid inheritance ......................................................................
Patch Set 2: Code-Review+2
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37385 )
Change subject: mb/lenovo/w530/devicetree: Use subsystemid inheritance ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37385/2/src/mainboard/lenovo/t530/v... File src/mainboard/lenovo/t530/variants/w530/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/37385/2/src/mainboard/lenovo/t530/v... PS2, Line 156: end remove?
Peter Lemenkov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37385 )
Change subject: mb/lenovo/w530/devicetree: Use subsystemid inheritance ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37385/2/src/mainboard/lenovo/t530/v... File src/mainboard/lenovo/t530/variants/w530/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/37385/2/src/mainboard/lenovo/t530/v... PS2, Line 156: end
remove?
Done
Hello Alexander Couzens, Patrick Rudolph, HAOUAS Elyes, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37385
to look at the new patch set (#3).
Change subject: mb/lenovo/w530/devicetree: Use subsystemid inheritance ......................................................................
mb/lenovo/w530/devicetree: Use subsystemid inheritance
Change-Id: I0646b18e823c52109e0fb62c85726622156172b9 Signed-off-by: Peter Lemenkov lemenkov@gmail.com --- M src/mainboard/lenovo/t530/variants/w530/devicetree.cb 1 file changed, 32 insertions(+), 75 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/37385/3
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37385 )
Change subject: mb/lenovo/w530/devicetree: Use subsystemid inheritance ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37385 )
Change subject: mb/lenovo/w530/devicetree: Use subsystemid inheritance ......................................................................
mb/lenovo/w530/devicetree: Use subsystemid inheritance
Change-Id: I0646b18e823c52109e0fb62c85726622156172b9 Signed-off-by: Peter Lemenkov lemenkov@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/37385 Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/lenovo/t530/variants/w530/devicetree.cb 1 file changed, 32 insertions(+), 75 deletions(-)
Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved
diff --git a/src/mainboard/lenovo/t530/variants/w530/devicetree.cb b/src/mainboard/lenovo/t530/variants/w530/devicetree.cb index 0844124..135627f 100644 --- a/src/mainboard/lenovo/t530/variants/w530/devicetree.cb +++ b/src/mainboard/lenovo/t530/variants/w530/devicetree.cb @@ -37,6 +37,8 @@ register "pci_mmio_size" = "2048"
device domain 0x0 on + subsystemid 0x17aa 0x21f6 inherit + chip southbridge/intel/bd82x6x # Intel Series 6 Cougar Point PCH # GPI routing # 0 No effect (default) @@ -60,67 +62,39 @@ register "superspeed_capable_ports" = "0x0000000f" register "xhci_overcurrent_mapping" = "0x04000201" register "xhci_switchable_ports" = "0x0000000f" - device pci 14.0 on # USB 3.0 Controller - subsystemid 0x17aa 0x21f6 - end - device pci 16.0 on # Management Engine Interface 1 - subsystemid 0x17aa 0x21f6 - end - device pci 16.1 off # Management Engine Interface 2 - end - device pci 16.2 off # Management Engine IDE-R - end - device pci 16.3 on # Management Engine KT - subsystemid 0x17aa 0x21f6 - end + device pci 14.0 on end # USB 3.0 Controller + device pci 16.0 on end # Management Engine Interface 1 + device pci 16.1 off end # Management Engine Interface 2 + device pci 16.2 off end # Management Engine IDE-R + device pci 16.3 on end # Management Engine KT device pci 19.0 on # Intel Gigabit Ethernet subsystemid 0x17aa 0x21f3 end - device pci 1a.0 on # USB2 EHCI #2 - subsystemid 0x17aa 0x21f6 - end - device pci 1b.0 on # High Definition Audio Audio controller - subsystemid 0x17aa 0x21f6 - end + device pci 1a.0 on end # USB2 EHCI #2 + device pci 1b.0 on end # High Definition Audio Audio controller device pci 1c.0 on # PCIe Port #1 - subsystemid 0x17aa 0x21f6 chip drivers/ricoh/rce822 # Ricoh cardreader register "disable_mask" = "0x83" register "sdwppol" = "1" - device pci 00.0 on # Ricoh SD card reader - subsystemid 0x17aa 0x21f6 - end + device pci 00.0 on end # Ricoh SD card reader end end - device pci 1c.1 on # PCIe Port #2 - subsystemid 0x17aa 0x21f6 - end + device pci 1c.1 on end # PCIe Port #2 device pci 1c.2 on # PCIe Port #3 - subsystemid 0x17aa 0x21f6 smbios_slot_desc "7" "3" "ExpressCard Slot" "8" end - device pci 1c.3 off # PCIe Port #4 - end - device pci 1c.4 off # PCIe Port #5 - end - device pci 1c.5 off # PCIe Port #6 - end - device pci 1c.6 off # PCIe Port #7 - end - device pci 1c.7 off # PCIe Port #8 - end - device pci 1d.0 on # USB2 EHCI #1 - subsystemid 0x17aa 0x21f6 - end - device pci 1e.0 off # PCI bridge - end + device pci 1c.3 off end # PCIe Port #4 + device pci 1c.4 off end # PCIe Port #5 + device pci 1c.5 off end # PCIe Port #6 + device pci 1c.6 off end # PCIe Port #7 + device pci 1c.7 off end # PCIe Port #8 + device pci 1d.0 on end # USB2 EHCI #1 + device pci 1e.0 off end # PCI bridge device pci 1f.0 on # LPC bridge PCI-LPC bridge - subsystemid 0x17aa 0x21f6 chip ec/lenovo/pmh7 register "backlight_enable" = "0x01" register "dock_event_enable" = "0x01" - device pnp ff.1 on # dummy - end + device pnp ff.1 on end # dummy end
chip drivers/pc80/tpm @@ -178,41 +152,24 @@ register "has_thinker1" = "1" end end - device pci 1f.2 on # SATA Controller 1 - subsystemid 0x17aa 0x21f6 - end + device pci 1f.2 on end # SATA Controller 1 device pci 1f.3 on # SMBus - subsystemid 0x17aa 0x21f6 chip drivers/i2c/at24rf08c # eeprom, 8 virtual devices, same chip - device i2c 54 on - end - device i2c 55 on - end - device i2c 56 on - end - device i2c 57 on - end - device i2c 5c on - end - device i2c 5d on - end - device i2c 5e on - end - device i2c 5f on - end + device i2c 54 on end + device i2c 55 on end + device i2c 56 on end + device i2c 57 on end + device i2c 5c on end + device i2c 5d on end + device i2c 5e on end + device i2c 5f on end end end - device pci 1f.5 off # SATA Controller 2 - end - device pci 1f.6 off # Thermal - end + device pci 1f.5 off end # SATA Controller 2 + device pci 1f.6 off end # Thermal end - device pci 00.0 on # Host bridge Host bridge - subsystemid 0x17aa 0x21f6 - end - device pci 01.0 on # PCIe Bridge for discrete graphics - subsystemid 0x17aa 0x21f6 - end + device pci 00.0 on end # Host bridge Host bridge + device pci 01.0 on end # PCIe Bridge for discrete graphics device pci 02.0 on # Internal graphics VGA controller subsystemid 0x17aa 0x21f5 end
-
HAOUAS Elyes (Code Review) -
Patrick Georgi (Code Review)
-
Peter Lemenkov (Code Review)