Raul Rangel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40866 )
Change subject: soc/amd/picasso/bootblock/bootblock: Remove duplicate i2c init ......................................................................
soc/amd/picasso/bootblock/bootblock: Remove duplicate i2c init
fch_early_init already calls i2c_soc_early_init().
BUG=b:153675916 TEST=Boot trembyle and only see 1 i2c initialization message
Signed-off-by: Raul E Rangel rrangel@chromium.org Change-Id: I689616fb617904df1781be3abe9d1dc580608173 --- M src/soc/amd/picasso/bootblock/bootblock.c 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/40866/1
diff --git a/src/soc/amd/picasso/bootblock/bootblock.c b/src/soc/amd/picasso/bootblock/bootblock.c index 8ae4db3..de0cb6e 100644 --- a/src/soc/amd/picasso/bootblock/bootblock.c +++ b/src/soc/amd/picasso/bootblock/bootblock.c @@ -27,5 +27,4 @@ printk(BIOS_DEBUG, "Family_Model: %08x\n", val);
fch_early_init(); - i2c_soc_early_init(); }
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40866 )
Change subject: soc/amd/picasso/bootblock/bootblock: Remove duplicate i2c init ......................................................................
Patch Set 1: Code-Review+2
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40866 )
Change subject: soc/amd/picasso/bootblock/bootblock: Remove duplicate i2c init ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40866 )
Change subject: soc/amd/picasso/bootblock/bootblock: Remove duplicate i2c init ......................................................................
soc/amd/picasso/bootblock/bootblock: Remove duplicate i2c init
fch_early_init already calls i2c_soc_early_init().
BUG=b:153675916 TEST=Boot trembyle and only see 1 i2c initialization message
Signed-off-by: Raul E Rangel rrangel@chromium.org Change-Id: I689616fb617904df1781be3abe9d1dc580608173 Reviewed-on: https://review.coreboot.org/c/coreboot/+/40866 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: Aaron Durbin adurbin@chromium.org --- M src/soc/amd/picasso/bootblock/bootblock.c 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved Furquan Shaikh: Looks good to me, approved
diff --git a/src/soc/amd/picasso/bootblock/bootblock.c b/src/soc/amd/picasso/bootblock/bootblock.c index 6a0fd85..56cdbd9 100644 --- a/src/soc/amd/picasso/bootblock/bootblock.c +++ b/src/soc/amd/picasso/bootblock/bootblock.c @@ -60,5 +60,4 @@ printk(BIOS_DEBUG, "Family_Model: %08x\n", val);
fch_early_init(); - i2c_soc_early_init(); }