Attention is currently required from: Jason Nien, Jon Murphy, Martin Roth, Karthik Ramasubramanian.
Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68116 )
Change subject: mb/google/skyrim: Override SPI flash bus speed
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
File src/mainboard/google/skyrim/Kconfig:
https://review.coreboot.org/c/coreboot/+/68116/comment/67879b57_c676654c
PS1, Line 96: default 0x5 if BOARD_GOOGLE_SKYRIM
: default 0xffffffff
Does this mean 100mhz only works on skyrim, and not any of the variants?
Is there a bug to track enabling 100mhz on the variants?
https://review.coreboot.org/c/coreboot/+/68116/comment/8a93b43a_b9e4392f
PS1, Line 143: endif # !EM100
nit: Move the new values after these default values, to match the guybrush `Kconfig` ordering (and make it easier to find the defaults).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68116
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5e8db22151fbc2db1f9e81b3644338348160736d
Gerrit-Change-Number: 68116
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Wed, 05 Oct 2022 19:57:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment