Attention is currently required from: Benjamin Doron, Lean Sheng Tan, Matt DeVillier, Sean Rhodes, Stefan Reinauer.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78636?usp=email )
Change subject: payloads/edk2: Remove the warning about edk2/master not working
......................................................................
Patch Set 2:
(1 comment)
File payloads/external/edk2/Kconfig:
https://review.coreboot.org/c/coreboot/+/78636/comment/0976e9e4_44f15dbf :
PS2, Line 63: Please note, this option will not work on any SOC without modification.
Rather than removing, how about we note the commit which must be in the branch/hash used and why? Pe […]
This seems reasonable to me.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78636?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8350f5114445d2608861ef6e807f958e598dfe07
Gerrit-Change-Number: 78636
Gerrit-PatchSet: 2
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Comment-Date: Sat, 04 Nov 2023 17:19:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Gerrit-MessageType: comment