Tristan Corrick has posted comments on this change. ( https://review.coreboot.org/29307 )
Change subject: src: Remove unneeded include <arch/io.h> ......................................................................
Patch Set 17:
(1 comment)
Thanks for doing this. However, some files (example below) have the #include removed, but still use macros/symbols from arch/io.h. I think it's best not to rely on having the appropriate headers included indirectly, so removing #includes in header files won't break other files.
https://review.coreboot.org/#/c/29307/17/src/mainboard/asus/maximus_iv_gene-... File src/mainboard/asus/maximus_iv_gene-z/romstage.c:
https://review.coreboot.org/#/c/29307/17/src/mainboard/asus/maximus_iv_gene-... PS17, Line 17: `PNP_DEV`, for example, is used in this file, but only defined in arch/io.h.