Attention is currently required from: Subrata Banik, Tim Wawrzynczak, Paul Menzel, Ivy Jian, Michael Niewöhner.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62931 )
Change subject: mb/google/brya/: Add PEG and initial Nvidia dGPU ASL support
......................................................................
Patch Set 5: Code-Review+1
(3 comments)
Patchset:
PS2:
Yeah we'll see how the driver ends up looking, and extend it if needed.
Sounds good
File src/mainboard/google/brya/acpi/gpu_top.asl:
https://review.coreboot.org/c/coreboot/+/62931/comment/53fb1426_e5acf0d4
PS5, Line 32: NVOP
nit: be consistent with space before parentheses (applies to all files)
File src/mainboard/google/brya/acpi/peg.asl:
https://review.coreboot.org/c/coreboot/+/62931/comment/18a6d852_5433d6c9
PS5, Line 7: 0xff
Huh, why this size?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62931
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifce1610210e9636e87dda4b55c8287334adfcc42
Gerrit-Change-Number: 62931
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Comment-Date: Tue, 03 May 2022 08:34:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment