[coreboot-gerrit] Change in ...coreboot[master]: src/lib: Add option to support native display init with vboot 2.0

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33845 )

Change subject: src/lib: Add option to support native display init with vboot 2.0
......................................................................

Patch Set 1:

(1 comment)

I think you should just squash this patch into the previous one. Adding an option without adding the code that makes it do something isn't very useful.

https://review.coreboot.org/#/c/33845/1/src/lib/bootmode.c 
File src/lib/bootmode.c:

https://review.coreboot.org/#/c/33845/1/src/lib/bootmode.c@40 
PS1, Line 40: 	 * display init in normal boot.
Again, let's not tie this to CHROMEOS. I think you can remove this comment completely, honestly... now that this checks a config option specifically meant to just control this (which has its own documentation), the code here should be clear on its own.