I think you should just squash this patch into the previous one. Adding an option without adding the code that makes it do something isn't very useful.
View Change
1 comment:
File src/lib/bootmode.c:
Patch Set #1, Line 40: * display init in normal boot.
Again, let's not tie this to CHROMEOS. I think you can remove this comment completely, honestly... now that this checks a config option specifically meant to just control this (which has its own documentation), the code here should be clear on its own.
To view, visit change 33845. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I51361c267e0317d44a58cc5d740c3beb8924a57b
Gerrit-Change-Number: 33845
Gerrit-PatchSet: 1
Gerrit-Owner: Amol N Sukerkar <amol.n.sukerkar@intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Amol N Sukerkar <amol.n.sukerkar@intel.com>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Lean Sheng Tan <lean.sheng.tan@intel.com>
Gerrit-Reviewer: Sachin Agrawal <sachin.agrawal@intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Fri, 28 Jun 2019 01:28:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment