Asami Doi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33387 )
Change subject: mainboard/emulation/qemu-aarch64: Add new board for ARMv8 ......................................................................
Patch Set 27:
(3 comments)
https://review.coreboot.org/c/coreboot/+/33387/26/Documentation/mainboard/em... File Documentation/mainboard/emulation/qemu-aarch64.md:
https://review.coreboot.org/c/coreboot/+/33387/26/Documentation/mainboard/em... PS26, Line 19: reserved for a FIT image
nit: it's reserved for the kernel, technically, not the FIT image
Thank you!
https://review.coreboot.org/c/coreboot/+/33387/26/src/mainboard/emulation/qe... File src/mainboard/emulation/qemu-aarch64/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/33387/26/src/mainboard/emulation/qe... PS26, Line 8: chip mainboard/emulation/qemu-aarch64
I'm not an sconfig expert, but I think the mainboard is already automatically added as the root devi […]
I removed the mainboard part. It doesn't affect any output messages at all so probably you're right. The mainboard is already added automatically.
https://review.coreboot.org/c/coreboot/+/33387/26/src/mainboard/emulation/qe... PS26, Line 9: chip drivers/generic/generic # I2C0 controller
Does this entry actually serve a purpose? It does nothing and means nothing, I think you should prob […]
This devicetree.cb doesn't have any effect but coreboot needs devicetree.cb during building. This is just a fake file.
If this file is empty, syntax error happens. So we need something not-empty devicetree.cb.