Tristan Corrick has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30767 )
Change subject: mb/asus/h61m-cs: Add ASUS H61M-CS ......................................................................
Patch Set 11:
(4 comments)
For the USB keyboard issue, perhaps it could help if you make the changes suggested here, then rebase on master.
https://review.coreboot.org/#/c/30767/11/src/mainboard/asus/h61m-cs/Kconfig File src/mainboard/asus/h61m-cs/Kconfig:
https://review.coreboot.org/#/c/30767/11/src/mainboard/asus/h61m-cs/Kconfig@... PS11, Line 6: select CPU_INTEL_SOCKET_LGA1155 Again, as per CB:31031, this should be removed.
https://review.coreboot.org/#/c/30767/10/src/mainboard/asus/h61m-cs/devicetr... File src/mainboard/asus/h61m-cs/devicetree.cb:
https://review.coreboot.org/#/c/30767/10/src/mainboard/asus/h61m-cs/devicetr... PS10, Line 60: device pci 1c.5 on # Realtek Gigabit NIC
-[0000:00]-+-00.0 Intel Corporation Xeon E3-1200 v2/3rd Gen Core processor DRAM Controller […]
Okay. Your earlier lspci output suggests that the coalescing isn't working, and I've found the following in a log you pasted on IRC:
PCH: Remap PCIe function 4 to 1 PCI: 00:1c.4 [8086/1c18] enabled PCH: Remap PCIe function 5 to 1 PCI: 00:1c.5 [8086/1c1a] enabled [...] PCH: PCIe map 1c.1 -> 1c.5 PCH: PCIe map 1c.4 -> 1c.1 PCH: PCIe map 1c.5 -> 1c.4
I do recommend removing `pcie_port_coalesce = "1"`, as it might be causing issues.
https://review.coreboot.org/#/c/30767/11/src/mainboard/asus/h61m-cs/devicetr... File src/mainboard/asus/h61m-cs/devicetree.cb:
https://review.coreboot.org/#/c/30767/11/src/mainboard/asus/h61m-cs/devicetr... PS11, Line 19: chip cpu/intel/socket_LGA1155 : device lapic 0x0 on : end : end Please remove this, as per CB:31031
https://review.coreboot.org/#/c/30767/11/src/mainboard/asus/h61m-cs/devicetr... PS11, Line 30: device lapic 0xacac off : end And, also per CB:31031, change this to
device lapic 0x0 on device lapic 0xacac off