John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48630 )
Change subject: drivers/intel/usb4: Enable retimer FW upgrade mux interaction ......................................................................
Patch Set 7:
(6 comments)
https://review.coreboot.org/c/coreboot/+/48630/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48630/6//COMMIT_MSG@7 PS6, Line 7: drivers/intel/usb4/
Please remove the trailing /.
Ack
https://review.coreboot.org/c/coreboot/+/48630/6//COMMIT_MSG@16 PS6, Line 16: Along with kernel and EC update,
Please add references to these changes.
EC and kernel patches are work-in-progress.
https://review.coreboot.org/c/coreboot/+/48630/6//COMMIT_MSG@16 PS6, Line 16: had : been
is
Done
https://review.coreboot.org/c/coreboot/+/48630/6//COMMIT_MSG@16 PS6, Line 16: TEST=Along with kernel and EC update, the Retimer firmware update had : been validated under device attached and no device attached scenarios.
If you added the validation command/procedure, that would be great.
I was referred the following command "cat /sys/bus/thunderbolt/devices/0-0/generation" would trigger for verification. Since kernel patches are still WIP, it seems no need to add here.
https://review.coreboot.org/c/coreboot/+/48630/6/src/drivers/intel/usb4/reti... File src/drivers/intel/usb4/retimer/retimer.c:
https://review.coreboot.org/c/coreboot/+/48630/6/src/drivers/intel/usb4/reti... PS6, Line 111: //
Remove?
Ack
https://review.coreboot.org/c/coreboot/+/48630/6/src/drivers/intel/usb4/reti... PS6, Line 117: * // write the EC RAM for Retimer Upgrade
Ditto.
Ack