6 comments:
Patch Set #6, Line 7: drivers/intel/usb4/
Please remove the trailing /.
Ack
Patch Set #6, Line 16: Along with kernel and EC update,
Please add references to these changes.
EC and kernel patches are work-in-progress.
had
been
is
Done
TEST=Along with kernel and EC update, the Retimer firmware update had
been validated under device attached and no device attached scenarios.
If you added the validation command/procedure, that would be great.
I was referred the following command
"cat /sys/bus/thunderbolt/devices/0-0/generation"
would trigger for verification. Since kernel patches are still WIP, it seems no need to add here.
File src/drivers/intel/usb4/retimer/retimer.c:
Remove?
Ack
Patch Set #6, Line 117: * // write the EC RAM for Retimer Upgrade
Ditto.
Ack
To view, visit change 48630. To unsubscribe, or for help writing mail filters, visit settings.