Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34422 )
Change subject: soc/amd/picasso: Update for vbios ......................................................................
Patch Set 2:
(1 comment)
Can you add information if a) running it under yabel aka secure mode in coreboot works b) loading (atom?) oprom in coreboot is enough to have OS gfx work
I only have limited information at this time. a) It runs and returns successfully but I don't know whether the hardware was sufficiently initialized. b) There are some unpublished steps that are buried in AGESA, however I'm not aware of any additional requirements, e.g. no DRAM Ready message to the PSP like in ST. BTW AMD often says it's not necessary to run the vbios at all, but that's not seemed correct for any integrated graphics I've ever seen.
I’d prefer if you splitted this in two commits.
I don't see a natural way to split it, and it seems to me the changes go together pretty well. I'm not worried about ever needing a complicated revert since the files won't be used until later in history.
https://review.coreboot.org/c/coreboot/+/34422/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34422/2//COMMIT_MSG@7 PS2, Line 7: soc/amd/picasso: Update for vbios
Please make it a statement by using a verb (in imperative mood): […]
Done