Can you add information if
a) running it under yabel aka secure mode in coreboot works
b) loading (atom?) oprom in coreboot is enough to have OS gfx work

I only have limited information at this time.
a) It runs and returns successfully but I don't know whether the hardware was sufficiently initialized.
b) There are some unpublished steps that are buried in AGESA, however I'm not aware of any additional requirements, e.g. no DRAM Ready message to the PSP like in ST. BTW AMD often says it's not necessary to run the vbios at all, but that's not seemed correct for any integrated graphics I've ever seen.

I’d prefer if you splitted this in two commits.

I don't see a natural way to split it, and it seems to me the changes go together pretty well. I'm not worried about ever needing a complicated revert since the files won't be used until later in history.

View Change

1 comment:

To view, visit change 34422. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaf43d7c8da41beb05b58c494f0a6814f8f571b18
Gerrit-Change-Number: 34422
Gerrit-PatchSet: 2
Gerrit-Owner: Marshall Dawson <marshalldawson3rd@gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd@gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Mon, 22 Jul 2019 13:46:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-MessageType: comment